From 7e1fb04f8af4d4e010401c0aed41d896deb0aa44 Mon Sep 17 00:00:00 2001 From: Robin Mueller Date: Tue, 4 Jul 2023 16:51:29 +0200 Subject: [PATCH] possible Apple CLang fixes --- src/fsfw/cfdp/handler/DestHandler.cpp | 4 +++- src/fsfw/cfdp/handler/DestHandler.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/fsfw/cfdp/handler/DestHandler.cpp b/src/fsfw/cfdp/handler/DestHandler.cpp index 4ffa797f..364897ee 100644 --- a/src/fsfw/cfdp/handler/DestHandler.cpp +++ b/src/fsfw/cfdp/handler/DestHandler.cpp @@ -388,7 +388,9 @@ ReturnValue_t cfdp::DestHandler::handleTransferCompletion() { } ReturnValue_t cfdp::DestHandler::tryBuildingAbsoluteDestName(size_t destNameSize) { - char baseNameBuf[tp.destName.size()]{}; + // Maximum allowed path size is 255 characters, so this should be enough to hold the full + // base name in any case. + char baseNameBuf[524]{}; FilesystemParams fparamsSrc(tp.sourceName.data()); size_t baseNameLen = 0; ReturnValue_t result = diff --git a/src/fsfw/cfdp/handler/DestHandler.h b/src/fsfw/cfdp/handler/DestHandler.h index 9057b3f5..6668b04d 100644 --- a/src/fsfw/cfdp/handler/DestHandler.h +++ b/src/fsfw/cfdp/handler/DestHandler.h @@ -6,6 +6,7 @@ #include #include +#include #include "RemoteConfigTableIF.h" #include "UserBase.h"