From e4c74ec060df2beb86eb34f1b2a9a8b1193adbd8 Mon Sep 17 00:00:00 2001 From: "Robin.Mueller" Date: Mon, 12 Oct 2020 16:57:37 +0200 Subject: [PATCH] added todos --- action/ActionHelper.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/action/ActionHelper.cpp b/action/ActionHelper.cpp index 9fd117f3..8122885b 100644 --- a/action/ActionHelper.cpp +++ b/action/ActionHelper.cpp @@ -101,8 +101,8 @@ ReturnValue_t ActionHelper::reportData(MessageQueueId_t reportTo, // another dedicated message. ActionMessage::setDataReply(&reply, replyId, storeAddress); - //TODO Service Implementation sucks at the moment - // why does it suck and why would someone need to hide the sender? + // TODO: Service Implementation sucks at the moment + // TODO: why does it suck and why would someone need to hide the sender? if (hideSender) { result = MessageQueueSenderIF::sendMessage(reportTo, &reply); } @@ -124,8 +124,6 @@ ReturnValue_t ActionHelper::reportData(MessageQueueId_t reportTo, bool hideSender) { CommandMessage reply; store_address_t storeAddress; - uint8_t *dataPtr = nullptr; - size_t size = 0; ReturnValue_t result = ipcStore->addData(&storeAddress, data, dataSize); if (result != HasReturnvaluesIF::RETURN_OK) { return result; @@ -142,8 +140,8 @@ ReturnValue_t ActionHelper::reportData(MessageQueueId_t reportTo, // another dedicated message. ActionMessage::setDataReply(&reply, replyId, storeAddress); - //TODO Service Implementation sucks at the moment - // why does it suck and why would someone need to hide the sender? + // TODO: Service Implementation sucks at the moment + // TODO: why does it suck and why would someone need to hide the sender? if (hideSender) { result = MessageQueueSenderIF::sendMessage(reportTo, &reply); }