Adaptions to make shared power lines possible #57

mspahr · 2025-04-07T09:04:59+02:00

mspahr commented

2025-04-07 09:04:59 +02:00

To make shared power lines on SOURCE possible, I added a bit of functionality to the SubsystemBase. The newly introduced function SubsystemBase::convertToDeviceObjectId() allows the user to manually override the objectId from the mode-tree. This is necessary because the fsfw is accessing the health-state of an object directly via the healthTable (and not sending messages, like for mode changes) - therefore "ignoring" mode-tree relations with this direct access. I added a default implementation of this function which directly returns it's input - therefore, this is backwards compatible.

Additionally (and not really related), I made the recovery-time (the time the device is in MODE_OFF during a recovery) accessible and modifiable by the user. This was still an open #todo based on the comments in the fsfw. For SOURCE, this is needed due to the long time (mutliple seconds) the PCDU actually needs to change the state of a power line.

To make shared power lines on _SOURCE_ possible, I added a bit of functionality to the SubsystemBase. The newly introduced function `SubsystemBase::convertToDeviceObjectId()` allows the user to manually override the objectId from the mode-tree. This is necessary because the fsfw is accessing the health-state of an object directly via the healthTable (and not sending messages, like for mode changes) - therefore "ignoring" mode-tree relations with this direct access. I added a default implementation of this function which directly returns it's input - therefore, this is backwards compatible. Additionally (and not really related), I made the recovery-time (the time the device is in MODE_OFF during a recovery) accessible and modifiable by the user. This was still an open #todo based on the comments in the fsfw. For SOURCE, this is needed due to the long time (mutliple seconds) the PCDU actually needs to change the state of a power line.

mspahr added 3 commits 2025-04-07 09:04:59 +02:00

add an adaption point which a user can use to convert a objectId of a shared power switch into a objectId of a device handler b665b2effe

Check if objectId exists in childrednmap first; this will prevent a hardfault 95520d7d0c

make the recovery timeout accessable to the user 297ec261ce

mspahr changed title from ~~WIP: Adaptions to make shared power lines possible~~ to Adaptions to make shared power lines possible

2025-04-07 20:23:38 +02:00

mspahr commented

2025-04-07 20:24:34 +02:00

This would be ready to be merged. @muellerr Could you please review this? Thank you!