Asynchronous ServiceInterfacePrinter #65

2026-01-23T13:11:36+01:00

ritzmannc commented

2026-01-23 13:11:36 +01:00

This makes the ServiceInterfacePrinter asynchronous, writing log messages into a buffer which are later printed by a dedicated print task.
This is needed in SOURCE as multiple tasks printing at the same time can interrupt each other leading to mangled log messages.

This makes the ServiceInterfacePrinter asynchronous, writing log messages into a buffer which are later printed by a dedicated print task. This is needed in SOURCE as multiple tasks printing at the same time can interrupt each other leading to mangled log messages.

ritzmannc added 2 commits 2026-01-23 13:11:37 +01:00

Add async printing functionality a625a06b7d

Fix Host TaskFactory::printMissedDeadline warning acf60e55e8

ritzmannc requested review from muellerr 2026-01-23 13:24:25 +01:00

muellerr reviewed

2026-02-13 13:30:02 +01:00

src/fsfw/serviceinterface/ServiceInterfacePrinter.cpp

						
				@@ -41,0 +70,4 @@

				  }

				  size_t len = 0;

				  // char *bufferPosition = printBuffers[bufferIdx];

muellerr commented

2026-02-13 13:30:02 +01:00

can this be removed?

👍 1

ritzmannc marked this conversation as resolved

muellerr commented

2026-02-13 13:30:43 +01:00

how was this tested? I'd like to especially avoid buffer overflow crashes/issues, adn there is a test suite in place.

ritzmannc added 1 commit 2026-02-13 16:35:29 +01:00

Remove legacy code 52129e0c84

ritzmannc commented

2026-02-13 16:47:32 +01:00

how was this tested? I'd like to especially avoid buffer overflow crashes/issues, adn there is a test suite in place.

The code was tested by hand on both FlatSat and Hosted (Linux).
All the formatting concerned with user input utilizes bounds checking so there shouldn't be any possibility for an out of bounds write.
A proper test suite may be complicated with the current version of the code but can be done with a slight refactoring if desired.

> how was this tested? I'd like to especially avoid buffer overflow crashes/issues, adn there is a test suite in place. The code was tested by hand on both FlatSat and Hosted (Linux). All the formatting concerned with user input utilizes bounds checking so there shouldn't be any possibility for an out of bounds write. A proper test suite may be complicated with the current version of the code but can be done with a slight refactoring if desired.

ritzmannc added 1 commit 2026-02-17 16:40:44 +01:00

Add FSFW_PRINT_BUFFER_AMOUNT to FSFW template config 7692e598d6

ritzmannc added 1 commit 2026-02-19 00:34:50 +01:00

Fix of by one errors and set the position after the last char to a null byte. 45150c8ce3

muellerr merged commit 3668e61d5c into main

2026-03-03 19:28:49 +01:00

muellerr referenced this issue from a commit

2026-03-03 19:28:50 +01:00

Merge pull request 'Asynchronous ServiceInterfacePrinter' (#65) from ritzmannc/fsfw:ritzmann/sif-async-print into main

Sign in to join this conversation.