devicehandlers/FixedSlotSequence.cpp

@@ -89,15 +89,9 @@ uint32_t FixedSlotSequence::getLengthMs() const {
 
 ReturnValue_t FixedSlotSequence::checkSequence() const {
 	if(slotList.empty()) {
-	    sif::error << "Fixed Slot Sequence: Slot list is empty!" << std::endl;
+		sif::error << "Fixed Slot Sequence: Slot list is empty!" << std::endl;
-	    // does check sequence have to be const?
+		return HasReturnvaluesIF::RETURN_FAILED;
-	    // if I want to check a class, I need the ability to set
-	    // internal class states.
-	    //isEmpty = true;
-	    std::exit(0);
 	}
-    // Iterate through slotList and check successful creation.
-	// Checks if timing is ok (must be ascending) and if all handlers were found.
 	auto slotIt = slotList.begin();
 	uint32_t count = 0;
 	uint32_t time = 0;

devicehandlers/FixedSlotSequence.h

@@ -13,13 +13,19 @@ using SlotListIter = std::multiset<FixedSequenceSlot>::iterator;
 /**
  * @brief	This class is the representation of a Polling Sequence Table in software.
  *
- * @details	The FixedSlotSequence object maintains the dynamic execution of device handler objects.
+ * @details
- * 			The main idea is to create a list of device handlers, to announce all handlers to the
+ * The FixedSlotSequence object maintains the dynamic execution of
- * 			polling sequence and to maintain a list of polling slot objects. This slot list represents the
+ * device handler objects.
- * 			Polling Sequence Table in software. Each polling slot contains information to indicate when and
+ *
- * 			which device handler shall be executed within a given polling period.
+ * The main idea is to create a list of device handlers, to announce all
- * 			The sequence is then executed by iterating through this slot list.
+ * handlers to thepolling sequence and to maintain a list of
- * 			Handlers are invoking by calling a certain function stored in the handler list.
+ * polling slot objects. This slot list represents the Polling Sequence Table
+ * in software.
+ *
+ * Each polling slot contains information to indicate when and
+ * which device handler shall be executed within a given polling period.
+ * The sequence is then executed by iterating through this slot list.
+ * Handlers are invoking by calling a certain function stored in the handler list.
  */
 class FixedSlotSequence {
 public:
@@ -112,7 +118,12 @@ public:
 	 */
 	SlotListIter current;
 
-	virtual ReturnValue_t checkSequence() const;
+	/**
+	 * Iterate through slotList and check successful creation.
+	 * Checks if timing is ok (must be ascending) and if all handlers were found.
+	 * @return
+	 */
+	ReturnValue_t checkSequence() const;
 protected:
 
 	/**

osal/FreeRTOS/FixedTimeslotTask.cpp

@@ -57,18 +57,18 @@ ReturnValue_t FixedTimeslotTask::startTask() {
 
 ReturnValue_t FixedTimeslotTask::addSlot(object_id_t componentId,
 		uint32_t slotTimeMs, int8_t executionStep) {
-	if (objectManager->get<ExecutableObjectIF>(componentId) != NULL) {
+	if (objectManager->get<ExecutableObjectIF>(componentId) != nullptr) {
 		if(slotTimeMs == 0) {
-			// TODO: FreeRTOS throws errors for zero values.
+			// FreeRTOS throws a sanity error for zero values, so we set
-			// maybe there is a better solution than this.
+			// the time to one millisecond.
 			slotTimeMs = 1;
 		}
 		pst.addSlot(componentId, slotTimeMs, executionStep, this);
 		return HasReturnvaluesIF::RETURN_OK;
 	}
 
-	sif::error << "Component " << std::hex << componentId
+	sif::error << "Component " << std::hex << componentId <<
-		  << " not found, not adding it to pst" << std::endl;
+			" not found, not adding it to pst" << std::endl;
 	return HasReturnvaluesIF::RETURN_FAILED;
 }
 

osal/linux/FixedTimeslotTask.cpp

@@ -42,14 +42,14 @@ uint32_t FixedTimeslotTask::getPeriodMs() const {
 
 ReturnValue_t FixedTimeslotTask::addSlot(object_id_t componentId,
 		uint32_t slotTimeMs, int8_t executionStep) {
-	if (!objectManager->get<ExecutableObjectIF>(componentId)) {
+	if (objectManager->get<ExecutableObjectIF>(componentId) != nullptr) {
-		sif::error << "Component " << std::hex << componentId
+		pst.addSlot(componentId, slotTimeMs, executionStep, this);
-				   << " not found, not adding it to pst" << std::endl;
+		return HasReturnvaluesIF::RETURN_OK;
-		return HasReturnvaluesIF::RETURN_FAILED;
 	}
 
-	pst.addSlot(componentId, slotTimeMs, executionStep, this);
+	sif::error << "Component " << std::hex << componentId <<
-	return HasReturnvaluesIF::RETURN_OK;
+			" not found, not adding it to pst" << std::endl;
+	return HasReturnvaluesIF::RETURN_FAILED;
 }
 
 ReturnValue_t FixedTimeslotTask::checkSequence() const {

osal/rtems/PollingTask.cpp

@@ -66,10 +66,16 @@ ReturnValue_t PollingTask::startTask() {
 	}
 }
 
-ReturnValue_t PollingTask::addSlot(object_id_t componentId, uint32_t slotTimeMs,
+ReturnValue_t PollingTask::addSlot(object_id_t componentId,
-		int8_t executionStep) {
+		uint32_t slotTimeMs, int8_t executionStep) {
-	pst.addSlot(componentId, slotTimeMs, executionStep, this);
+	if (objectManager->get<ExecutableObjectIF>(componentId) != nullptr) {
-	return HasReturnvaluesIF::RETURN_OK;
+		pst.addSlot(componentId, slotTimeMs, executionStep, this);
+		return HasReturnvaluesIF::RETURN_OK;
+	}
+
+	error << "Component " << std::hex << componentId <<
+			" not found, not adding it to pst" << std::endl;
+	return HasReturnvaluesIF::RETURN_FAILED;
 }
 
 uint32_t PollingTask::getPeriodMs() const {