From 8a50746251096aac2ea7bfa277396b5a9f4003fd Mon Sep 17 00:00:00 2001 From: meggert Date: Tue, 12 Dec 2023 16:01:30 +0100 Subject: [PATCH 1/2] i blame robin for not finding this in his review --- mission/controller/acs/AttitudeEstimation.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mission/controller/acs/AttitudeEstimation.cpp b/mission/controller/acs/AttitudeEstimation.cpp index e287b22f..5e07642f 100644 --- a/mission/controller/acs/AttitudeEstimation.cpp +++ b/mission/controller/acs/AttitudeEstimation.cpp @@ -24,10 +24,10 @@ void AttitudeEstimation::quest(acsctrl::SusDataProcessed *susData, // Normalize Data double normMgmB[3] = {0, 0, 0}, normMgmI[3] = {0, 0, 0}, normSusB[3] = {0, 0, 0}, normSusI[3] = {0, 0, 0}; - VectorOperations::normalize(susData->susVecTot.value, normMgmB, 3); - VectorOperations::normalize(susData->sunIjkModel.value, normMgmI, 3); - VectorOperations::normalize(mgmData->mgmVecTot.value, normSusB, 3); - VectorOperations::normalize(mgmData->magIgrfModel.value, normSusI, 3); + VectorOperations::normalize(susData->susVecTot.value, normSusB, 3); + VectorOperations::normalize(susData->sunIjkModel.value, normSusI, 3); + VectorOperations::normalize(mgmData->mgmVecTot.value, normMgmB, 3); + VectorOperations::normalize(mgmData->magIgrfModel.value, normMgmI, 3); // Create Helper Vectors double normHelperB[3] = {0, 0, 0}, normHelperI[3] = {0, 0, 0}, helperCross[3] = {0, 0, 0}, From 4858c1ea57a8d990fc6e976c667bcdb729d5689c Mon Sep 17 00:00:00 2001 From: meggert Date: Tue, 12 Dec 2023 17:03:58 +0100 Subject: [PATCH 2/2] changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b89cacbe..fe4c44f9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,10 @@ will consitute of a breaking change warranting a new major release: # [unreleased] +## Fixed + +- Faulty mapping of input values for QUEST algorithm. + # [v7.5.0] 2023-12-06 - `eive-tmtc` v5.12.0