diff --git a/CHANGELOG.md b/CHANGELOG.md index d16da7fc..7cb32c1f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,12 @@ will consitute of a breaking change warranting a new major release: # [unreleased] +## Fixed + +- Proper Faulty/External Control handling for the dual lane assemblies. +- ACS board devices: Go to ON mode instead of going to NORMAL mode directly. +- SUS device handlers: Go to ON mode on startup instead of NORMAL mode. + ## Changed - Enabled periodic hosuekeeping generation for release images. diff --git a/mission/acs/GyrAdis1650XHandler.cpp b/mission/acs/GyrAdis1650XHandler.cpp index dd30775e..63a28366 100644 --- a/mission/acs/GyrAdis1650XHandler.cpp +++ b/mission/acs/GyrAdis1650XHandler.cpp @@ -28,11 +28,7 @@ void GyrAdis1650XHandler::doStartUp() { } if (breakCountdown.hasTimedOut()) { updatePeriodicReply(true, adis1650x::REPLY); - if (goToNormalMode) { - setMode(MODE_NORMAL); - } else { - setMode(MODE_ON); - } + setMode(MODE_ON); internalState = InternalState::NONE; } } @@ -208,8 +204,6 @@ adis1650x::BurstModes GyrAdis1650XHandler::getBurstMode() { return adis1650x::burstModeFromMscCtrl(currentCtrlReg); } -void GyrAdis1650XHandler::setToGoToNormalModeImmediately() { goToNormalMode = true; } - void GyrAdis1650XHandler::enablePeriodicPrintouts(bool enable, uint8_t divider) { periodicPrintout = enable; debugDivider.setDivider(divider); diff --git a/mission/acs/GyrAdis1650XHandler.h b/mission/acs/GyrAdis1650XHandler.h index 5a2a2842..5d906f61 100644 --- a/mission/acs/GyrAdis1650XHandler.h +++ b/mission/acs/GyrAdis1650XHandler.h @@ -21,7 +21,6 @@ class GyrAdis1650XHandler : public DeviceHandlerBase { adis1650x::Type type); void enablePeriodicPrintouts(bool enable, uint8_t divider); - void setToGoToNormalModeImmediately(); // DeviceHandlerBase abstract function implementation void doStartUp() override; @@ -47,7 +46,6 @@ class GyrAdis1650XHandler : public DeviceHandlerBase { AdisGyroConfigDataset configDataset; double sensitivity = adis1650x::SENSITIVITY_UNSET; - bool goToNormalMode = false; bool warningSwitch = true; enum class InternalState { NONE, STARTUP, SHUTDOWN }; diff --git a/mission/acs/GyrL3gCustomHandler.cpp b/mission/acs/GyrL3gCustomHandler.cpp index b235a2ef..fd576791 100644 --- a/mission/acs/GyrL3gCustomHandler.cpp +++ b/mission/acs/GyrL3gCustomHandler.cpp @@ -23,11 +23,7 @@ void GyrL3gCustomHandler::doStartUp() { if (internalState == InternalState::STARTUP) { if (commandExecuted) { - if (goNormalModeImmediately) { - setMode(MODE_NORMAL); - } else { - setMode(_MODE_TO_ON); - } + setMode(MODE_ON); internalState = InternalState::NONE; commandExecuted = false; } @@ -145,8 +141,6 @@ uint32_t GyrL3gCustomHandler::getTransitionDelayMs(Mode_t from, Mode_t to) { return this->transitionDelayMs; } -void GyrL3gCustomHandler::setToGoToNormalMode(bool enable) { this->goNormalModeImmediately = true; } - ReturnValue_t GyrL3gCustomHandler::initializeLocalDataPool(localpool::DataPool &localDataPoolMap, LocalDataPoolManager &poolManager) { localDataPoolMap.emplace(l3gd20h::ANG_VELOC_X, new PoolEntry({0.0})); diff --git a/mission/acs/GyrL3gCustomHandler.h b/mission/acs/GyrL3gCustomHandler.h index 44ddd826..08d1b706 100644 --- a/mission/acs/GyrL3gCustomHandler.h +++ b/mission/acs/GyrL3gCustomHandler.h @@ -32,11 +32,6 @@ class GyrL3gCustomHandler : public DeviceHandlerBase { */ void setAbsoluteLimits(float limitX, float limitY, float limitZ); - /** - * @brief Configure device handler to go to normal mode immediately - */ - void setToGoToNormalMode(bool enable); - protected: /* DeviceHandlerBase overrides */ ReturnValue_t buildTransitionDeviceCommand(DeviceCommandId_t *id) override; @@ -69,7 +64,6 @@ class GyrL3gCustomHandler : public DeviceHandlerBase { bool commandExecuted = false; uint8_t statusReg = 0; - bool goNormalModeImmediately = false; uint8_t ctrlReg1Value = l3gd20h::CTRL_REG_1_VAL; uint8_t ctrlReg2Value = l3gd20h::CTRL_REG_2_VAL; diff --git a/mission/acs/MgmLis3CustomHandler.cpp b/mission/acs/MgmLis3CustomHandler.cpp index f081cd7e..d1dd5eff 100644 --- a/mission/acs/MgmLis3CustomHandler.cpp +++ b/mission/acs/MgmLis3CustomHandler.cpp @@ -20,7 +20,7 @@ void MgmLis3CustomHandler::doStartUp() { } if (internalState == InternalState::STARTUP) { if (commandExecuted) { - setMode(MODE_NORMAL); + setMode(MODE_ON); internalState = InternalState::NONE; commandExecuted = false; } diff --git a/mission/acs/MgmRm3100CustomHandler.cpp b/mission/acs/MgmRm3100CustomHandler.cpp index 891fad0f..e57effda 100644 --- a/mission/acs/MgmRm3100CustomHandler.cpp +++ b/mission/acs/MgmRm3100CustomHandler.cpp @@ -25,7 +25,7 @@ void MgmRm3100CustomHandler::doStartUp() { if (commandExecuted) { commandExecuted = false; internalState = InternalState::NONE; - setMode(MODE_NORMAL); + setMode(MODE_ON); } } } diff --git a/mission/acs/SusHandler.cpp b/mission/acs/SusHandler.cpp index 46255165..0032a11d 100644 --- a/mission/acs/SusHandler.cpp +++ b/mission/acs/SusHandler.cpp @@ -20,7 +20,7 @@ void SusHandler::doStartUp() { } if (internalState == InternalState::STARTUP) { if (commandExecuted) { - setMode(MODE_NORMAL); + setMode(MODE_ON); internalState = InternalState::NONE; commandExecuted = false; } diff --git a/tmtc b/tmtc index f6fcb2fb..333faaa5 160000 --- a/tmtc +++ b/tmtc @@ -1 +1 @@ -Subproject commit f6fcb2fb282d79b1e250722eba46a319603b0232 +Subproject commit 333faaa5f70646bfde1101f8e0538505574d1d7e