From e0f94039b46ed3939d4b5c5e2a8fbe8193154262 Mon Sep 17 00:00:00 2001 From: Robin Mueller Date: Fri, 31 Mar 2023 12:47:55 +0200 Subject: [PATCH] found some bugs --- mission/com/PersistentSingleTmStoreTask.cpp | 1 - mission/com/PersistentSingleTmStoreTask.h | 1 - mission/com/SyrlinksHandler.cpp | 5 ----- 3 files changed, 7 deletions(-) diff --git a/mission/com/PersistentSingleTmStoreTask.cpp b/mission/com/PersistentSingleTmStoreTask.cpp index f84738ad..2d05b25f 100644 --- a/mission/com/PersistentSingleTmStoreTask.cpp +++ b/mission/com/PersistentSingleTmStoreTask.cpp @@ -8,7 +8,6 @@ PersistentSingleTmStoreTask::PersistentSingleTmStoreTask( object_id_t objectId, StorageManagerIF& ipcStore, PersistentTmStoreWithTmQueue& tmStore, VirtualChannel& channel, Event eventIfDumpDone, Event eventIfCancelled, SdCardMountedIF& sdcMan) : TmStoreTaskBase(objectId, ipcStore, channel, sdcMan), - modeHelper(this), storeWithQueue(tmStore), dumpContext(eventIfDumpDone, eventIfCancelled) {} diff --git a/mission/com/PersistentSingleTmStoreTask.h b/mission/com/PersistentSingleTmStoreTask.h index d8a1979b..4cbf1544 100644 --- a/mission/com/PersistentSingleTmStoreTask.h +++ b/mission/com/PersistentSingleTmStoreTask.h @@ -17,7 +17,6 @@ class PersistentSingleTmStoreTask : public TmStoreTaskBase, public ExecutableObj ReturnValue_t performOperation(uint8_t opCode) override; private: - ModeHelper modeHelper; PersistentTmStoreWithTmQueue& storeWithQueue; DumpContext dumpContext; Countdown tcHandlingCd = Countdown(400); diff --git a/mission/com/SyrlinksHandler.cpp b/mission/com/SyrlinksHandler.cpp index 84eebeda..297ffd88 100644 --- a/mission/com/SyrlinksHandler.cpp +++ b/mission/com/SyrlinksHandler.cpp @@ -99,10 +99,6 @@ ReturnValue_t SyrlinksHandler::buildNormalDeviceCommand(DeviceCommandId_t* id) { } ReturnValue_t SyrlinksHandler::buildTransitionDeviceCommand(DeviceCommandId_t* id) { - if (transitionCommandPending) { - return NOTHING_TO_SEND; - } - transitionCommandPending = true; switch (internalState) { case InternalState::ENABLE_TEMPERATURE_PROTECTION: { *id = syrlinks::WRITE_LCL_CONFIG; @@ -129,7 +125,6 @@ ReturnValue_t SyrlinksHandler::buildTransitionDeviceCommand(DeviceCommandId_t* i return buildCommandFromCommand(*id, nullptr, 0); } default: { - transitionCommandPending = false; break; } }