From 18b342e94b59123b986fca3242ba375be3c6aefd Mon Sep 17 00:00:00 2001
From: Robin Mueller <robin.mueller.m@gmail.com>
Date: Tue, 17 May 2022 18:12:05 +0200
Subject: [PATCH] vector as core container is ok

---
 src/fsfw/osal/linux/PeriodicPosixTask.cpp | 7 ++++---
 src/fsfw/osal/linux/PeriodicPosixTask.h   | 4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/fsfw/osal/linux/PeriodicPosixTask.cpp b/src/fsfw/osal/linux/PeriodicPosixTask.cpp
index 26b6f53e..44d669df 100644
--- a/src/fsfw/osal/linux/PeriodicPosixTask.cpp
+++ b/src/fsfw/osal/linux/PeriodicPosixTask.cpp
@@ -1,6 +1,7 @@
 #include "fsfw/osal/linux/PeriodicPosixTask.h"
 
-#include <errno.h>
+#include <set>
+#include <cerrno>
 
 #include "fsfw/objectmanager/ObjectManager.h"
 #include "fsfw/serviceinterface/ServiceInterface.h"
@@ -23,7 +24,7 @@ void* PeriodicPosixTask::taskEntryPoint(void* arg) {
   PeriodicPosixTask* originalTask(reinterpret_cast<PeriodicPosixTask*>(arg));
   // The task's functionality is called.
   originalTask->taskFunctionality();
-  return NULL;
+  return nullptr;
 }
 
 ReturnValue_t PeriodicPosixTask::addComponent(object_id_t object, uint8_t opCode) {
@@ -43,7 +44,7 @@ ReturnValue_t PeriodicPosixTask::addComponent(ExecutableObjectIF* object, uint8_
 #endif
     return HasReturnvaluesIF::RETURN_FAILED;
   }
-  objectList.emplace(object, opCode);
+  objectList.push_back({object, opCode});
   object->setTaskIF(this);
 
   return HasReturnvaluesIF::RETURN_OK;
diff --git a/src/fsfw/osal/linux/PeriodicPosixTask.h b/src/fsfw/osal/linux/PeriodicPosixTask.h
index 1142c854..a3c6b187 100644
--- a/src/fsfw/osal/linux/PeriodicPosixTask.h
+++ b/src/fsfw/osal/linux/PeriodicPosixTask.h
@@ -1,7 +1,7 @@
 #ifndef FRAMEWORK_OSAL_LINUX_PERIODICPOSIXTASK_H_
 #define FRAMEWORK_OSAL_LINUX_PERIODICPOSIXTASK_H_
 
-#include <set>
+#include <vector>
 
 #include "../../objectmanager/ObjectManagerIF.h"
 #include "../../tasks/ExecutableObjectIF.h"
@@ -61,7 +61,7 @@ class PeriodicPosixTask : public PosixThread, public PeriodicTaskIF {
  private:
   //! Typedef for the List of objects. Will contain the objects to execute and their respective
   //! op codes
-  using ObjectList = std::multiset<std::pair<ExecutableObjectIF*, uint8_t>>;
+  using ObjectList = std::vector<std::pair<ExecutableObjectIF*, uint8_t>>;
   /**
    * @brief	This attribute holds a list of objects to be executed.
    */