From 9ef63825f3d8486b05c3f6193ae0503833e6f8a4 Mon Sep 17 00:00:00 2001
From: Robin Mueller <muellerr@irs.uni-stuttgart.de>
Date: Wed, 16 Aug 2023 13:15:34 +0200
Subject: [PATCH] optimization

---
 src/fsfw/cfdp/handler/DestHandler.cpp | 8 ++++----
 src/fsfw/cfdp/handler/UserBase.h      | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/fsfw/cfdp/handler/DestHandler.cpp b/src/fsfw/cfdp/handler/DestHandler.cpp
index 953cad86..999cb155 100644
--- a/src/fsfw/cfdp/handler/DestHandler.cpp
+++ b/src/fsfw/cfdp/handler/DestHandler.cpp
@@ -356,15 +356,15 @@ ReturnValue_t cfdp::DestHandler::startTransaction(MetadataPduReader& reader,
                              transactionParams.fileSize);
   params.destFileName = transactionParams.destName.data();
   params.sourceFileName = transactionParams.sourceName.data();
-  unsigned tlvIdx = 0;
+  params.numberOfMsgsToUser = 0;
   for (const auto& opt : tlvVec) {
     if (opt.getType() == TlvType::MSG_TO_USER) {
-      msgToUserVec[tlvIdx] = MessageToUserTlv(opt.getValue(), opt.getLengthField());
-      tlvIdx++;
+      msgToUserVec[params.numberOfMsgsToUser] =
+          MessageToUserTlv(opt.getValue(), opt.getLengthField());
+      params.numberOfMsgsToUser++;
     }
   }
   params.msgsToUserArray = msgToUserVec.data();
-  params.msgsToUserLen = tlvIdx;
   destParams.user.metadataRecvdIndication(params);
   return result;
 }
diff --git a/src/fsfw/cfdp/handler/UserBase.h b/src/fsfw/cfdp/handler/UserBase.h
index 47df48c0..6141eea9 100644
--- a/src/fsfw/cfdp/handler/UserBase.h
+++ b/src/fsfw/cfdp/handler/UserBase.h
@@ -35,7 +35,7 @@ struct MetadataRecvdParams {
   Fss fileSize{};
   const char* sourceFileName = "";
   const char* destFileName = "";
-  size_t msgsToUserLen = 0;
+  size_t numberOfMsgsToUser = 0;
   const MessageToUserTlv* msgsToUserArray = nullptr;
 };