diff --git a/src/fsfw/controller/ControllerBase.cpp b/src/fsfw/controller/ControllerBase.cpp index 98907210..c41c4121 100644 --- a/src/fsfw/controller/ControllerBase.cpp +++ b/src/fsfw/controller/ControllerBase.cpp @@ -109,5 +109,5 @@ const HasModesIF& ControllerBase::getModeIF() const { return *this; } ModeTreeChildIF& ControllerBase::getModeTreeChildIF() { return *this; } ReturnValue_t ControllerBase::connectModeTreeParent(HasModeTreeChildrenIF& parent) { - return modetree::connectModeTreeParent(parent, *this, healthHelper, modeHelper); + return modetree::connectModeTreeParent(parent, *this, &healthHelper, modeHelper); } diff --git a/src/fsfw/devicehandlers/DeviceHandlerBase.cpp b/src/fsfw/devicehandlers/DeviceHandlerBase.cpp index 67cd6a8b..d6e39edc 100644 --- a/src/fsfw/devicehandlers/DeviceHandlerBase.cpp +++ b/src/fsfw/devicehandlers/DeviceHandlerBase.cpp @@ -1608,7 +1608,7 @@ void DeviceHandlerBase::disableCommandsAndReplies() { } ReturnValue_t DeviceHandlerBase::connectModeTreeParent(HasModeTreeChildrenIF& parent) { - return modetree::connectModeTreeParent(parent, *this, healthHelper, modeHelper); + return modetree::connectModeTreeParent(parent, *this, &healthHelper, modeHelper); } const HasHealthIF* DeviceHandlerBase::getOptHealthIF() const { return this; } diff --git a/src/fsfw/pus/Service11TelecommandScheduling.tpp b/src/fsfw/pus/Service11TelecommandScheduling.tpp index 962d84ac..2ad11277 100644 --- a/src/fsfw/pus/Service11TelecommandScheduling.tpp +++ b/src/fsfw/pus/Service11TelecommandScheduling.tpp @@ -2,12 +2,12 @@ #include +#include "fsfw/globalfunctions/CRC.h" #include "fsfw/objectmanager/ObjectManager.h" #include "fsfw/serialize/SerializeAdapter.h" #include "fsfw/serviceinterface.h" -#include "fsfw/tmtcservices/AcceptsTelecommandsIF.h" #include "fsfw/tmtcpacket/pus/tc/PusTcIF.h" -#include "fsfw/globalfunctions/CRC.h" +#include "fsfw/tmtcservices/AcceptsTelecommandsIF.h" static constexpr auto DEF_END = SerializeIF::Endianness::BIG; @@ -180,7 +180,7 @@ inline ReturnValue_t Service11TelecommandScheduling::doInsertActivi if (CRC::crc16ccitt(data, size) != 0) { return CONTAINED_TC_CRC_MISSMATCH; } - + // store currentPacket and receive the store address store_address_t addr{}; if (tcStore->addData(&addr, data, size) != returnvalue::OK || diff --git a/src/fsfw/subsystem/SubsystemBase.cpp b/src/fsfw/subsystem/SubsystemBase.cpp index 7f215f60..5cfe59a3 100644 --- a/src/fsfw/subsystem/SubsystemBase.cpp +++ b/src/fsfw/subsystem/SubsystemBase.cpp @@ -284,7 +284,7 @@ ReturnValue_t SubsystemBase::setHealth(HealthState health) { HasHealthIF::HealthState SubsystemBase::getHealth() { return healthHelper.getHealth(); } ReturnValue_t SubsystemBase::connectModeTreeParent(HasModeTreeChildrenIF& parent) { - return modetree::connectModeTreeParent(parent, *this, healthHelper, modeHelper); + return modetree::connectModeTreeParent(parent, *this, &healthHelper, modeHelper); } object_id_t SubsystemBase::getObjectId() const { return SystemObject::getObjectId(); } diff --git a/src/fsfw/subsystem/helper.cpp b/src/fsfw/subsystem/helper.cpp index e65ef5a9..7b29825a 100644 --- a/src/fsfw/subsystem/helper.cpp +++ b/src/fsfw/subsystem/helper.cpp @@ -2,12 +2,14 @@ ReturnValue_t modetree::connectModeTreeParent(HasModeTreeChildrenIF& parent, const ModeTreeChildIF& child, - HealthHelper& healthHelper, ModeHelper& modeHelper) { + HealthHelper* healthHelper, ModeHelper& modeHelper) { ReturnValue_t result = parent.registerChild(child); if (result != returnvalue::OK) { return result; } - healthHelper.setParentQueue(parent.getCommandQueue()); + if (healthHelper != nullptr) { + healthHelper->setParentQueue(parent.getCommandQueue()); + } modeHelper.setParentQueue(parent.getCommandQueue()); return returnvalue::OK; } diff --git a/src/fsfw/subsystem/helper.h b/src/fsfw/subsystem/helper.h index 71a5563f..7a394e49 100644 --- a/src/fsfw/subsystem/helper.h +++ b/src/fsfw/subsystem/helper.h @@ -7,7 +7,7 @@ namespace modetree { ReturnValue_t connectModeTreeParent(HasModeTreeChildrenIF& parent, const ModeTreeChildIF& child, - HealthHelper& healthHelper, ModeHelper& modeHelper); + HealthHelper* healthHelper, ModeHelper& modeHelper); }