From dd193fd64d302e5592dfddc8a4395101d921b61b Mon Sep 17 00:00:00 2001
From: "Robin.Mueller" <robin.mueller.m@gmail.com>
Date: Thu, 4 Jun 2020 21:27:37 +0200
Subject: [PATCH] obj manager.cpp improvements

---
 objectmanager/ObjectManager.cpp | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/objectmanager/ObjectManager.cpp b/objectmanager/ObjectManager.cpp
index b12c66d9..2f47950f 100644
--- a/objectmanager/ObjectManager.cpp
+++ b/objectmanager/ObjectManager.cpp
@@ -65,10 +65,10 @@ void ObjectManager::initialize() {
 	this->produceObjects();
 	ReturnValue_t return_value = RETURN_FAILED;
 	uint32_t error_count = 0;
-	for (auto it = this->objectList.begin(); it != objectList.end(); it++ ) {
-		return_value = it->second->initialize();
+	for (auto const& it : objectList) {
+		return_value = it.second->initialize();
 		if ( return_value != RETURN_OK ) {
-			object_id_t var = it->first;
+			object_id_t var = it.first;
 			sif::error << "Object 0x" << std::hex <<  std::setw(8) <<
 					std::setfill('0')<< var << " failed to initialize " <<
 					"with code 0x" << return_value << std::dec << std::endl;
@@ -81,11 +81,10 @@ void ObjectManager::initialize() {
 	}
 	//Init was successful. Now check successful interconnections.
 	error_count = 0;
-	for (auto listIter = this->objectList.begin();
-			listIter != objectList.end(); listIter++ ) {
-		return_value = listIter->second->checkObjectConnections();
+	for (auto const& it : objectList) {
+		return_value = it.second->checkObjectConnections();
 		if ( return_value != RETURN_OK ) {
-			sif::error << "Object " << std::hex <<  (int) listIter->first
+			sif::error << "Object " << std::hex <<  (int) it.first
 			        << " connection check failed with code 0x" << return_value
 			        << std::dec << std::endl;
 			error_count++;