From 45ea09291a76c8d609a0315fa7f1ba59ef2b64a4 Mon Sep 17 00:00:00 2001
From: Steffen Gaisser <gaisser@irs.uni-stuttgart.de>
Date: Fri, 18 Feb 2022 19:57:36 +0100
Subject: [PATCH] Still test for InternalError Reporter

---
 .../internalerror/TestInternalErrorReporter.cpp   | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/tests/src/fsfw_tests/unit/internalerror/TestInternalErrorReporter.cpp b/tests/src/fsfw_tests/unit/internalerror/TestInternalErrorReporter.cpp
index d394166e..1103037d 100644
--- a/tests/src/fsfw_tests/unit/internalerror/TestInternalErrorReporter.cpp
+++ b/tests/src/fsfw_tests/unit/internalerror/TestInternalErrorReporter.cpp
@@ -3,6 +3,7 @@
 #include <fsfw/internalerror/InternalErrorReporter.h>
 #include <fsfw/objectmanager/ObjectManager.h>
 #include <fsfw/timemanager/CCSDSTime.h>
+#include <fsfw/housekeeping/HousekeepingSnapshot.h>
 
 #include <array>
 #include <catch2/catch_test_macros.hpp>
@@ -34,6 +35,7 @@ TEST_CASE("Internal Error Reporter", "[TestInternalError]") {
         auto result = hkQueue->sendMessage(testQueue->getId(), &message);
         REQUIRE(result == retval::CATCH_OK);
         internalErrorReporter->performOperation(0);
+        uint32_t queueHits = 0;
         {
             CommandMessage hkMessage;
             result = hkQueue->receiveMessage(&hkMessage);
@@ -45,10 +47,13 @@ TEST_CASE("Internal Error Reporter", "[TestInternalError]") {
             InternalErrorDataset dataset(objects::NO_OBJECT);
             CCSDSTime::CDS_short time;
             ConstAccessorPair data = ipcStore->getData(storeAddress);
+            REQUIRE(data.first == HasReturnvaluesIF::RETURN_OK);
             HousekeepingSnapshot hkSnapshot(&time, &dataset);
             const uint8_t* buffer = data.second.data();
             size_t size = data.second.size();
-            hkSnapshot.deSerialize(&buffer, &size, SerializeIF::Endianness::MACHINE);
+            result = hkSnapshot.deSerialize(&buffer, &size, SerializeIF::Endianness::MACHINE);
+            REQUIRE(result == HasReturnvaluesIF::RETURN_OK);
+            queueHits = dataset.queueHits.value;
         }
         result = hkQueue->sendMessage(testQueue->getId(), &message);
         REQUIRE(result == MessageQueueIF::FULL);
@@ -64,6 +69,14 @@ TEST_CASE("Internal Error Reporter", "[TestInternalError]") {
             
             ConstAccessorPair data = ipcStore->getData(storeAddress);
             REQUIRE(data.first == HasReturnvaluesIF::RETURN_OK);
+            CCSDSTime::CDS_short time;
+            InternalErrorDataset dataset(objects::NO_OBJECT);
+            HousekeepingSnapshot hkSnapshot(&time, &dataset);
+            const uint8_t* buffer = data.second.data();
+            size_t size = data.second.size();
+            result = hkSnapshot.deSerialize(&buffer, &size, SerializeIF::Endianness::MACHINE);
+            REQUIRE(result == HasReturnvaluesIF::RETURN_OK);
+            REQUIRE(dataset.queueHits == (queueHits + 1));
         }
     }
     delete testQueue;