From b0c479cab9bffedfcf5529727b72be673d3282d5 Mon Sep 17 00:00:00 2001
From: Robin Mueller <muellerr@irs.uni-stuttgart.de>
Date: Wed, 3 Aug 2022 11:34:30 +0200
Subject: [PATCH] remove some shadowing warnings

---
 unittests/cfdp/testTlvsLvs.cpp | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/unittests/cfdp/testTlvsLvs.cpp b/unittests/cfdp/testTlvsLvs.cpp
index 98dec980..90dd688c 100644
--- a/unittests/cfdp/testTlvsLvs.cpp
+++ b/unittests/cfdp/testTlvsLvs.cpp
@@ -153,10 +153,10 @@ TEST_CASE("CFDP TLV LV", "[CfdpTlvLv]") {
     REQUIRE(result == HasReturnvaluesIF::RETURN_OK);
     REQUIRE(deserSize == 3);
     REQUIRE(rawBuf[0] == 2);
-    uint16_t sourceId = 0;
-    result = SerializeAdapter::deSerialize(&sourceId, rawBuf.data() + 1, &deserSize,
+    uint16_t sourceIdRaw = 0;
+    result = SerializeAdapter::deSerialize(&sourceIdRaw, rawBuf.data() + 1, &deserSize,
                                            SerializeIF::Endianness::BIG);
-    REQUIRE(sourceId == 0x0ff0);
+    REQUIRE(sourceIdRaw == 0x0ff0);
 
     auto lvEmpty = Lv(nullptr, 0);
     REQUIRE(lvEmpty.getSerializedSize() == 1);
@@ -169,7 +169,7 @@ TEST_CASE("CFDP TLV LV", "[CfdpTlvLv]") {
   }
 
   SECTION("LV Deserialization") {
-    std::array<uint8_t, 8> lvRawBuf;
+    std::array<uint8_t, 8> lvRawBuf{};
     serPtr = lvRawBuf.data();
     result =
         sourceId.serialize(&serPtr, &deserSize, lvRawBuf.size(), SerializeIF::Endianness::NETWORK);
@@ -186,10 +186,10 @@ TEST_CASE("CFDP TLV LV", "[CfdpTlvLv]") {
     REQUIRE(result == HasReturnvaluesIF::RETURN_OK);
     REQUIRE(uninitLv.getSerializedSize() == 3);
     const uint8_t* storedValue = uninitLv.getValue(nullptr);
-    uint16_t sourceId = 0;
-    result = SerializeAdapter::deSerialize(&sourceId, storedValue, &deserSize,
+    uint16_t sourceIdRaw = 0;
+    result = SerializeAdapter::deSerialize(&sourceIdRaw, storedValue, &deserSize,
                                            SerializeIF::Endianness::BIG);
-    REQUIRE(sourceId == 0x0ff0);
+    REQUIRE(sourceIdRaw == 0x0ff0);
 
     auto lvEmpty = Lv(nullptr, 0);
     REQUIRE(lvEmpty.getSerializedSize() == 1);
@@ -306,7 +306,7 @@ TEST_CASE("CFDP TLV LV", "[CfdpTlvLv]") {
     FaultHandlerOverrideTlv faultOverrideTlv(cfdp::ConditionCode::FILESTORE_REJECTION,
                                              cfdp::FaultHandlerCode::NOTICE_OF_CANCELLATION);
     size_t sz = 0;
-    ReturnValue_t result =
+    result =
         faultOverrideTlv.serialize(&serPtr, &sz, rawBuf.size(), SerializeIF::Endianness::NETWORK);
     REQUIRE(faultOverrideTlv.getSerializedSize() == 3);
     REQUIRE(sz == 3);