Commit Graph

55 Commits

Author SHA1 Message Date
deb8ce3744 merged upstream master 2020-05-17 15:53:29 +02:00
e8a1912fda Merge remote-tracking branch 'upstram/master' into mueller_DeviceHandlerBase_AllRefactoring 2020-05-17 15:50:40 +02:00
f4ad38f07f replyMap insertion improvements 2020-05-17 15:47:17 +02:00
7ceb6f3c96 override for executeAction() 2020-05-17 15:43:45 +02:00
fb0834ffe1 added cookie caching and deletion 2020-05-17 15:28:00 +02:00
b8e7b12a63 commented whole SWITCH IO BOARD block 2020-05-17 13:10:09 +02:00
614deea323 last size_t replacements 2020-05-07 23:38:28 +02:00
33eae034c7 replace device comIF uint32_t with size_t 2020-05-07 23:14:29 +02:00
3b63dd72e3 added missing sif prefixes 2020-05-07 19:41:42 +02:00
10628ddbb6 Merge remote-tracking branch 'upstream/master' into mueller_sifRenaming_soooMany 2020-05-07 19:28:06 +02:00
119455f3fd replaced exit by returning failed 2020-05-05 19:33:06 +02:00
c4486e79ec removed exit for empty pst 2020-05-05 19:30:26 +02:00
432dbbd26e removed sif 2020-05-05 18:57:30 +02:00
a6b3cee898 class comment formatting 2020-05-05 18:56:45 +02:00
75da7a4c50 comment moved to header 2020-05-05 18:55:05 +02:00
2c6b446500 it is done :-)
However, commented outputs are not changed yet.
2020-04-23 19:13:18 +02:00
b78b3ac68a added performOperationHook() 2020-04-19 22:17:14 +02:00
225e1b98a0 some bugfixes in cpp file to enable compilation 2020-04-19 22:10:02 +02:00
fd100cb994 header function order change
fillCOmmandANdREplyMAp is now closer to its helper functions
2020-04-19 16:10:44 +02:00
f4c925e671 Merge branch 'mueller_DeviceHandlerBase_API_change_CookieIF' into mueller_DeviceHandlerBase_AllRefactoring 2020-04-19 15:57:39 +02:00
7f08bb3506 removed ioboardAddress, max reply Len 2020-04-19 15:54:28 +02:00
36dbf6e1ce Merge branch 'mueller_DeviceHandlerBase_ctor_reduction' into mueller_DeviceHandlerBase_AllRefactoring 2020-04-19 15:51:58 +02:00
1820ad14b7 API change introduced, using new device comIF
also changed child handler base.
2020-04-19 15:48:17 +02:00
c8983650f7 Merge branch 'mueller_DeviceHandlerBase_Changes' into mueller_newDeviceCommunicationIF 2020-04-19 15:36:42 +02:00
bb650ac784 Merge remote-tracking branch 'origin/mueller_CookieToCookieIF' into mueller_newDeviceCommunicationIF 2020-04-19 15:30:14 +02:00
ff47fa191a Communication interface rework
As discussed, open/reOpen not used anymore, replaced by
initializeInterface call.
Using CookieIF.
2020-04-19 15:25:17 +02:00
520ed881bb wrong function call fixed 2020-04-19 15:16:44 +02:00
ce554c615c reduced massive ctor size
this was done by moving zero or nullptr initialization
into the header file
2020-04-19 15:15:33 +02:00
eacedf7ed6 DHB: replyLen in replyMap now
both maps are closer together now as well
2020-04-19 15:01:27 +02:00
74b8c3eef4 new returnvalue DeviceComIF
explicitely setting receivedDataLen to 0 in readReceivedMessage() does
not trigger error anymore
2020-04-19 14:52:27 +02:00
62644bdfc9 DeviceHandlerIF fixed some indentation error
still some unclarities about returnvalues
so I added a comment on what the returnvalues
in DHB and DH interface mean
2020-04-19 14:45:28 +02:00
1ec1d057b8 renamed rmap to com (more generic) 2020-04-19 14:08:20 +02:00
7126c19ee0 Restructured header file
Abstract functions are closer to the top
because they must be implemented and documentation
should be near the top.
Important virtual functions moved up too.
Additional documentation added and existing adapted
to 80 column width.
I tried to reduce the number of included files and sorted them a bit
2020-04-19 14:03:47 +02:00
574d6051ba new returnvalue for scanForReply
to ignore full packet
DeviceCommunicationIF sendMessage function takes const data pointer now
2020-04-19 13:41:43 +02:00
0c0c8ec448 device handler base indentation 2020-04-19 13:29:50 +02:00
0cb2abfe7e old cookie added again
will be replaced in separate branch/pull request
2020-04-19 13:26:40 +02:00
abe7239018 reset, splitting up merge request 2020-04-19 13:24:10 +02:00
a1f36e6ae5 added std:: before uint32_t typedef 2020-04-18 15:05:51 +02:00
db34c45b67 removed self-inclusion 2020-04-18 14:16:46 +02:00
9c958c06fe Changed Cookie to CookieIF 2020-04-18 14:10:38 +02:00
81ab5a6914 As discussed, renamed Cookie to CookieIF.
Also added documentation on the purpose of this class
2020-04-18 14:03:37 +02:00
ee23a7c0b5 fix 2020-04-06 14:02:33 +02:00
f28886e970 Moved crc calculation into its own class, renamed function to show which
crc is calculated.
2020-04-06 13:22:42 +02:00
511c0db8c7 Cookie -> CookieIF, DHB changes
According to changes agreed on 01.04.2020,
slight refactoring of DHB:
requestLen is set to 0 if no respective reply is enabled
2020-04-01 12:43:53 +02:00
ac4275ef05 some minor changes 2020-03-27 14:44:54 +01:00
bfb0234d41 more refactoring 2020-03-24 15:59:08 +01:00
ea41514553 new cookie.cpp + cookieIF.h 2020-03-23 19:17:53 +01:00
59812199fd new cookieIF 2020-03-23 19:16:01 +01:00
029b2133e6 new adaptions for cookie + comIF changes
hook for performOp() added
2020-03-23 18:03:00 +01:00
e03aff3731 Device Handler Base Proposals
1. Interface functions moved closer to top (and functions which should
be implemented)
2. ioBoardAddress renamed to logicalAddress. getter FUnction added.
3. debug interface for easier debugging of device handlers
4. new documentation
5. new return value for scanForReply to ignore full packet
2020-02-03 22:34:15 +01:00