From 3acc72470d97b8c3e299b250b911a7f7a43da445 Mon Sep 17 00:00:00 2001 From: Robin Mueller Date: Wed, 27 Jul 2022 17:00:57 +0200 Subject: [PATCH] some clang-tidy imorovements --- example/utility/TmFunnel.cpp | 2 +- example/utility/TmFunnel.h | 11 +++++------ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/example/utility/TmFunnel.cpp b/example/utility/TmFunnel.cpp index abbe68b..4cf640c 100644 --- a/example/utility/TmFunnel.cpp +++ b/example/utility/TmFunnel.cpp @@ -17,7 +17,7 @@ TmFunnel::TmFunnel(object_id_t objectId, uint32_t messageDepth) messageDepth, MessageQueueMessage::MAX_MESSAGE_SIZE); } -TmFunnel::~TmFunnel() {} +TmFunnel::~TmFunnel() = default; MessageQueueId_t TmFunnel::getReportReceptionQueue(uint8_t virtualChannel) { return tmQueue->getId(); diff --git a/example/utility/TmFunnel.h b/example/utility/TmFunnel.h index 9a7dbce..52eee67 100644 --- a/example/utility/TmFunnel.h +++ b/example/utility/TmFunnel.h @@ -25,13 +25,12 @@ class TmFunnel : public AcceptsTelemetryIF, friend void(Factory::setStaticFrameworkObjectIds)(); public: - TmFunnel(object_id_t objectId, uint32_t messageDepth = 20); - virtual ~TmFunnel(); + explicit TmFunnel(object_id_t objectId, uint32_t messageDepth = 20); + ~TmFunnel() override; - virtual MessageQueueId_t - getReportReceptionQueue(uint8_t virtualChannel = 0) override; - virtual ReturnValue_t performOperation(uint8_t operationCode = 0) override; - virtual ReturnValue_t initialize() override; + MessageQueueId_t getReportReceptionQueue(uint8_t virtualChannel) override; + ReturnValue_t performOperation(uint8_t operationCode) override; + ReturnValue_t initialize() override; protected: static object_id_t downlinkDestination;