From 9c9daffbbc322a8f7687de95efee3fd2da369ab3 Mon Sep 17 00:00:00 2001 From: Robin Mueller Date: Wed, 7 Sep 2022 18:40:10 +0200 Subject: [PATCH] some more TODOs --- bsp_hosted/core/CfdpHandler.cpp | 2 +- bsp_hosted/core/CfdpHandler.h | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/bsp_hosted/core/CfdpHandler.cpp b/bsp_hosted/core/CfdpHandler.cpp index ed4a26b..1e15e41 100644 --- a/bsp_hosted/core/CfdpHandler.cpp +++ b/bsp_hosted/core/CfdpHandler.cpp @@ -11,7 +11,7 @@ CfdpHandler::CfdpHandler(const HandlerCfg& cfg) destHandler( DestHandlerParams(cfg.cfg, *this, *this, cfg.packetInfoList, cfg.lostSegmentsList), FsfwParams(cfg.packetDest, nullptr, this)) { - // TODO: Make configurable? + // TODO: Make queue params configurable, or better yet, expect it to be passed externally msgQueue = QueueFactory::instance()->createMessageQueue(); destHandler.setMsgQueue(*msgQueue); } diff --git a/bsp_hosted/core/CfdpHandler.h b/bsp_hosted/core/CfdpHandler.h index d7b7dab..45c8b10 100644 --- a/bsp_hosted/core/CfdpHandler.h +++ b/bsp_hosted/core/CfdpHandler.h @@ -33,13 +33,18 @@ class CfdpHandler : public SystemObject, public AcceptsTelecommandsIF { public: explicit CfdpHandler(const HandlerCfg& cfg); - bool getRemoteCfg(const cfdp::EntityId& remoteId, cfdp::RemoteEntityCfg** cfg) override; + [[nodiscard]] const char* getName() const override; [[nodiscard]] uint32_t getIdentifier() const override; [[nodiscard]] MessageQueueId_t getRequestQueue() const override; ReturnValue_t initialize() override; ReturnValue_t performOperation(uint8_t operationCode) override; + + // CFDP remote table interface + bool getRemoteCfg(const cfdp::EntityId& remoteId, cfdp::RemoteEntityCfg** cfg) override; + + // CFDP user overrides void transactionIndication(const cfdp::TransactionId& id) override; void eofSentIndication(const cfdp::TransactionId& id) override; void transactionFinishedIndication(const cfdp::TransactionFinishedParams& params) override;