From 06bea2f621def14c75bfcda436d496cd6701360a Mon Sep 17 00:00:00 2001
From: Robin Mueller <muellerr@irs.uni-stuttgart.de>
Date: Tue, 9 Aug 2022 10:59:24 +0200
Subject: [PATCH] test inNull and bool operator

---
 src/fsfw/cfdp/pdu/HeaderReader.cpp   |  2 +-
 unittests/cfdp/testFileDirective.cpp | 26 ++++++++++++++++++--------
 2 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/src/fsfw/cfdp/pdu/HeaderReader.cpp b/src/fsfw/cfdp/pdu/HeaderReader.cpp
index c946ce275..06a403476 100644
--- a/src/fsfw/cfdp/pdu/HeaderReader.cpp
+++ b/src/fsfw/cfdp/pdu/HeaderReader.cpp
@@ -134,4 +134,4 @@ bool HeaderReader::isNull() const {
   return pointers.rawPtr == nullptr or pointers.fixedHeader == nullptr;
 }
 
-HeaderReader::operator bool() const { return isNull(); }
+HeaderReader::operator bool() const { return not isNull(); }
diff --git a/unittests/cfdp/testFileDirective.cpp b/unittests/cfdp/testFileDirective.cpp
index 3a4818ecb..d7c35456b 100644
--- a/unittests/cfdp/testFileDirective.cpp
+++ b/unittests/cfdp/testFileDirective.cpp
@@ -16,9 +16,9 @@ TEST_CASE("CFDP File Directive", "[cfdp]") {
   uint8_t* serTarget = serBuf.data();
   const uint8_t* deserTarget = serTarget;
   size_t serSize = 0;
+  auto fdSer = FileDirectiveCreator(pduConf, FileDirectives::ACK, 4);
 
-  SECTION("File Directive") {
-    auto fdSer = FileDirectiveCreator(pduConf, FileDirectives::ACK, 4);
+  SECTION("Serialization") {
     REQUIRE(fdSer.getSerializedSize() == 8);
     serTarget = serBuf.data();
     serSize = 0;
@@ -38,24 +38,34 @@ TEST_CASE("CFDP File Directive", "[cfdp]") {
     // Dest ID
     REQUIRE(serBuf[6] == 1);
     REQUIRE(serBuf[7] == FileDirectives::ACK);
+  }
 
-    serTarget = serBuf.data();
-    size_t deserSize = 20;
-    serSize = 0;
-    REQUIRE(fdSer.deSerialize(&deserTarget, &deserSize, SerializeIF::Endianness::NETWORK) ==
-            HasReturnvaluesIF::RETURN_FAILED);
+  SECTION("Serialization fails") {
     REQUIRE(fdSer.serialize(nullptr, nullptr, 85, SerializeIF::Endianness::NETWORK) ==
             HasReturnvaluesIF::RETURN_FAILED);
+  }
+
+  SECTION("Buffer Too Short") {
     for (uint8_t idx = 0; idx < 8; idx++) {
       serTarget = serBuf.data();
       serSize = 0;
       REQUIRE(fdSer.serialize(&serTarget, &serSize, idx, SerializeIF::Endianness::NETWORK) ==
               SerializeIF::BUFFER_TOO_SHORT);
     }
+  }
 
+  SECTION("Deserialize") {
+    CHECK(fdSer.serialize(&serTarget, &serSize, serBuf.size(), SerializeIF::Endianness::NETWORK) ==
+          result::OK);
+    serTarget = serBuf.data();
+
+    REQUIRE(fdSer.deSerialize(&deserTarget, &serSize, SerializeIF::Endianness::NETWORK) ==
+            HasReturnvaluesIF::RETURN_FAILED);
     deserTarget = serBuf.data();
-    deserSize = 0;
+    CHECK(serSize == 8);
     auto fdDeser = FileDirectiveReader(deserTarget, serBuf.size());
+    REQUIRE(not fdDeser.isNull());
+    REQUIRE(fdDeser);
     REQUIRE(fdDeser.getEndianness() == SerializeIF::Endianness::NETWORK);
     fdDeser.setEndianness(SerializeIF::Endianness::MACHINE);
     REQUIRE(fdDeser.getEndianness() == SerializeIF::Endianness::MACHINE);