diff --git a/datalinklayer/Clcw.cpp b/datalinklayer/Clcw.cpp index 448d4d7bc..0ffa7abf6 100644 --- a/datalinklayer/Clcw.cpp +++ b/datalinklayer/Clcw.cpp @@ -55,7 +55,8 @@ void Clcw::setBitLock(bool bitLock) { } void Clcw::print() { - debug << "Clcw::print: Clcw is: " << std::hex << getAsWhole() << std::dec << std::endl; + debug << "Clcw::print: Clcw is: " << std::hex << getAsWhole() + << std::dec << std::endl; } void Clcw::setWhole(uint32_t rawClcw) { diff --git a/datapool/DataPool.h b/datapool/DataPool.h index a9af8af0b..857bc3b2c 100644 --- a/datapool/DataPool.h +++ b/datapool/DataPool.h @@ -42,7 +42,8 @@ private: /** * \brief This is the actual data pool itself. * \details It is represented by a map - * with the data pool id as index and a pointer to a single PoolEntry as value. + * with the data pool id as index and a pointer to a single + * PoolEntry as value. */ std::map data_pool; public: diff --git a/datapool/PoolEntry.cpp b/datapool/PoolEntry.cpp index e5d4ffdef..655b467a0 100644 --- a/datapool/PoolEntry.cpp +++ b/datapool/PoolEntry.cpp @@ -60,7 +60,8 @@ uint8_t PoolEntry::getValid() { template void PoolEntry::print() { for (uint8_t size = 0; size < this->length; size++ ) { - debug << "| " << std::hex << (double)this->address[size] << (this->valid? " (valid) " : " (invalid) "); + debug << "| " << std::hex << (double)this->address[size] + << (this->valid? " (valid) " : " (invalid) "); } debug << std::dec << std::endl; } diff --git a/health/HealthHelper.cpp b/health/HealthHelper.cpp index 8fc413edd..931645d1a 100644 --- a/health/HealthHelper.cpp +++ b/health/HealthHelper.cpp @@ -89,8 +89,7 @@ void HealthHelper::handleSetHealthCommand(CommandMessage* message) { } if (MessageQueueSenderIF::sendMessage(message->getSender(), &reply, owner->getCommandQueue()) != HasReturnvaluesIF::RETURN_OK) { - debug - << "HealthHelper::handleHealthCommand: sending health reply failed." - << std::endl; + debug << "HealthHelper::handleHealthCommand: sending health " + "reply failed." << std::endl; } } diff --git a/osal/FreeRTOS/BinarySemaphore.cpp b/osal/FreeRTOS/BinarySemaphore.cpp index 546c5a46d..05c97ae2e 100644 --- a/osal/FreeRTOS/BinarySemaphore.cpp +++ b/osal/FreeRTOS/BinarySemaphore.cpp @@ -21,26 +21,68 @@ BinarySemaphore::~BinarySemaphore() { vSemaphoreDelete(handle); } +// This copy ctor is important as it prevents the assignment to a ressource +// (other.handle) variable which is later deleted! +BinarySemaphore::BinarySemaphore(const BinarySemaphore& other) { + xSemaphoreCreateBinary(handle); + if(handle == nullptr) { + error << "Binary semaphore creation failure" << std::endl; + } +} + +BinarySemaphore& BinarySemaphore::operator =(const BinarySemaphore& s) { + if(this != &s) { + xSemaphoreCreateBinary(handle); + if(handle == nullptr) { + error << "Binary semaphore creation failure" << std::endl; + } + } + return *this; +} + +BinarySemaphore::BinarySemaphore(BinarySemaphore&& s) { + xSemaphoreCreateBinary(handle); + if(handle == nullptr) { + error << "Binary semaphore creation failure" << std::endl; + } +} + +BinarySemaphore& BinarySemaphore::operator =( + BinarySemaphore&& s) { + if(&s != this) { + xSemaphoreCreateBinary(handle); + if(handle == nullptr) { + error << "Binary semaphore creation failure" << std::endl; + } + } + return *this; +} + ReturnValue_t BinarySemaphore::takeBinarySemaphore(uint32_t timeoutMs) { if(handle == nullptr) { - return HasReturnvaluesIF::RETURN_FAILED; + return SEMAPHORE_NULLPOINTER; } - TickType_t timeout = portMAX_DELAY; - if(timeoutMs != 0) { - timeout = pdMS_TO_TICKS(timeoutMs); + TickType_t timeout = BinarySemaphore::NO_BLOCK_TICKS; + if(timeoutMs == BinarySemaphore::BLOCK_TIMEOUT) { + timeout = BinarySemaphore::BLOCK_TIMEOUT_TICKS; + } + else if(timeoutMs > BinarySemaphore::NO_BLOCK_TIMEOUT){ + timeout = pdMS_TO_TICKS(timeoutMs); } BaseType_t returncode = xSemaphoreTake(handle, timeout); if (returncode == pdPASS) { return HasReturnvaluesIF::RETURN_OK; - } else { - return SEMAPHORE_NOT_FOUND; + } + else { + return SEMAPHORE_TIMEOUT; } } -ReturnValue_t BinarySemaphore::takeBinarySemaphoreTickTimeout(TickType_t timeoutTicks) { +ReturnValue_t BinarySemaphore::takeBinarySemaphoreTickTimeout( + TickType_t timeoutTicks) { if(handle == nullptr) { - return SEMAPHORE_NOT_FOUND; + return SEMAPHORE_NULLPOINTER; } BaseType_t returncode = xSemaphoreTake(handle, timeoutTicks); @@ -53,7 +95,7 @@ ReturnValue_t BinarySemaphore::takeBinarySemaphoreTickTimeout(TickType_t timeout ReturnValue_t BinarySemaphore::giveBinarySemaphore() { if (handle == nullptr) { - return HasReturnvaluesIF::RETURN_FAILED; + return SEMAPHORE_NULLPOINTER; } BaseType_t returncode = xSemaphoreGive(handle); if (returncode == pdPASS) { @@ -69,7 +111,7 @@ SemaphoreHandle_t BinarySemaphore::getSemaphore() { ReturnValue_t BinarySemaphore::giveBinarySemaphore(SemaphoreHandle_t semaphore) { if (semaphore == nullptr) { - return HasReturnvaluesIF::RETURN_FAILED; + return SEMAPHORE_NULLPOINTER; } BaseType_t returncode = xSemaphoreGive(semaphore); if (returncode == pdPASS) { @@ -86,11 +128,12 @@ void BinarySemaphore::resetSemaphore() { } } + // Be careful with the stack size here. This is called from an ISR! ReturnValue_t BinarySemaphore::giveBinarySemaphoreFromISR(SemaphoreHandle_t semaphore, BaseType_t * higherPriorityTaskWoken) { if (semaphore == nullptr) { - return HasReturnvaluesIF::RETURN_FAILED; + return SEMAPHORE_NULLPOINTER; } BaseType_t returncode = xSemaphoreGiveFromISR(semaphore, higherPriorityTaskWoken); if (returncode == pdPASS) { @@ -99,11 +142,10 @@ ReturnValue_t BinarySemaphore::giveBinarySemaphoreFromISR(SemaphoreHandle_t sema // TODO: I don't know if this will ever happen but if it does, // I want to to know in case this causes issues. If it doesn't // we should remove this. - TRACE_INFO("Binary Semaphore: Higher priority task unblocked!"); TaskManagement::requestContextSwitch(CallContext::isr); } return HasReturnvaluesIF::RETURN_OK; } else { - return HasReturnvaluesIF::RETURN_FAILED; + return SEMAPHORE_NOT_OWNED; } } diff --git a/osal/FreeRTOS/BinarySemaphore.h b/osal/FreeRTOS/BinarySemaphore.h index a809f0bb1..541266929 100644 --- a/osal/FreeRTOS/BinarySemaphore.h +++ b/osal/FreeRTOS/BinarySemaphore.h @@ -20,22 +20,51 @@ class BinarySemaphore: public HasReturnvaluesIF { public: static const uint8_t INTERFACE_ID = CLASS_ID::SEMAPHORE_IF; - /** Semaphore object not found */ - static const ReturnValue_t SEMAPHORE_NOT_FOUND = MAKE_RETURN_CODE(1); - /** Semaphore timeout */ - static const ReturnValue_t SEMAPHORE_TIMEOUT = MAKE_RETURN_CODE(2); + //! No block time, poll the semaphore. Can also be used as tick type. + //! Can be passed as tick type and ms value. + static constexpr uint32_t NO_BLOCK_TIMEOUT = 0; + static constexpr TickType_t NO_BLOCK_TICKS = 0; + //! No block time, poll the semaphore. + //! Can be passed as tick type and ms value. + static constexpr TickType_t BLOCK_TIMEOUT_TICKS = portMAX_DELAY; + static constexpr uint32_t BLOCK_TIMEOUT = portMAX_DELAY; + + //! Semaphore timeout + static constexpr ReturnValue_t SEMAPHORE_TIMEOUT = MAKE_RETURN_CODE(1); /** The current semaphore can not be given, because it is not owned */ - static const ReturnValue_t SEMAPHORE_NOT_OWNED = MAKE_RETURN_CODE(3); + static constexpr ReturnValue_t SEMAPHORE_NOT_OWNED = MAKE_RETURN_CODE(2); + static constexpr ReturnValue_t SEMAPHORE_NULLPOINTER = MAKE_RETURN_CODE(3); /** * Create a binary semaphore */ BinarySemaphore(); + /** + * Copy ctor + * @param + */ + BinarySemaphore(const BinarySemaphore&); + + /** + * Copy assignment + */ + BinarySemaphore& operator=(const BinarySemaphore&); + + /** + * Move constructor + */ + BinarySemaphore (BinarySemaphore &&); + + /** + * Move assignment + */ + BinarySemaphore & operator=(BinarySemaphore &&); + /** * Delete the binary semaphore to prevent a memory leak */ - ~BinarySemaphore(); + virtual ~BinarySemaphore(); /** * Take the binary semaphore. @@ -46,7 +75,8 @@ public: * @return -@c RETURN_OK on success * -@c RETURN_FAILED on failure */ - ReturnValue_t takeBinarySemaphore(uint32_t timeoutMs); + ReturnValue_t takeBinarySemaphore(uint32_t timeoutMs = + BinarySemaphore::NO_BLOCK_TIMEOUT); /** * Same as lockBinarySemaphore() with timeout in FreeRTOS ticks. @@ -54,7 +84,8 @@ public: * @return -@c RETURN_OK on success * -@c RETURN_FAILED on failure */ - ReturnValue_t takeBinarySemaphoreTickTimeout(TickType_t timeoutTicks); + ReturnValue_t takeBinarySemaphoreTickTimeout(TickType_t timeoutTicks = + BinarySemaphore::NO_BLOCK_TICKS); /** * Give back the binary semaphore @@ -96,8 +127,4 @@ private: SemaphoreHandle_t handle; }; - - - - #endif /* FRAMEWORK_OSAL_FREERTOS_BINARYSEMPAHORE_H_ */ diff --git a/serialize/SerialBufferAdapter.cpp b/serialize/SerialBufferAdapter.cpp index 618e8a152..f97d0d588 100644 --- a/serialize/SerialBufferAdapter.cpp +++ b/serialize/SerialBufferAdapter.cpp @@ -5,19 +5,19 @@ template SerialBufferAdapter::SerialBufferAdapter(const void* buffer, count_t bufferLength, bool serializeLength) : - m_serialize_length(serializeLength), - m_const_buffer(static_cast(buffer)), m_buffer(nullptr), - m_buffer_length(bufferLength) { + serializeLength(serializeLength), + constBuffer(static_cast(buffer)), m_buffer(nullptr), + bufferLength(bufferLength) { } template SerialBufferAdapter::SerialBufferAdapter(void* buffer, count_t bufferLength, bool serializeLength) : - m_serialize_length(serializeLength), m_buffer_length(bufferLength) { + serializeLength(serializeLength), bufferLength(bufferLength) { uint8_t * member_buffer = static_cast(buffer); m_buffer = member_buffer; - m_const_buffer = member_buffer; + constBuffer = member_buffer; } @@ -28,37 +28,37 @@ SerialBufferAdapter::~SerialBufferAdapter() { template ReturnValue_t SerialBufferAdapter::serialize(uint8_t** buffer, size_t* size, const size_t max_size, bool bigEndian) const { - uint32_t serializedLength = m_buffer_length; - if (m_serialize_length) { + uint32_t serializedLength = bufferLength; + if (serializeLength) { serializedLength += AutoSerializeAdapter::getSerializedSize( - &m_buffer_length); + &bufferLength); } if (*size + serializedLength > max_size) { return BUFFER_TOO_SHORT; } else { - if (m_serialize_length) { - AutoSerializeAdapter::serialize(&m_buffer_length, buffer, size, + if (serializeLength) { + AutoSerializeAdapter::serialize(&bufferLength, buffer, size, max_size, bigEndian); } - if (m_const_buffer != nullptr) { - memcpy(*buffer, m_const_buffer, m_buffer_length); + if (constBuffer != nullptr) { + memcpy(*buffer, constBuffer, bufferLength); } else if (m_buffer != nullptr) { - memcpy(*buffer, m_buffer, m_buffer_length); + memcpy(*buffer, m_buffer, bufferLength); } else { return HasReturnvaluesIF::RETURN_FAILED; } - *size += m_buffer_length; - (*buffer) += m_buffer_length; + *size += bufferLength; + (*buffer) += bufferLength; return HasReturnvaluesIF::RETURN_OK; } } template size_t SerialBufferAdapter::getSerializedSize() const { - if (m_serialize_length) { - return m_buffer_length + AutoSerializeAdapter::getSerializedSize(&m_buffer_length); + if (serializeLength) { + return bufferLength + AutoSerializeAdapter::getSerializedSize(&bufferLength); } else { - return m_buffer_length; + return bufferLength; } } template @@ -66,15 +66,15 @@ ReturnValue_t SerialBufferAdapter::deSerialize(const uint8_t** buffer, ssize_t* size, bool bigEndian) { //TODO Ignores Endian flag! if (buffer != NULL) { - if(m_serialize_length){ + if(serializeLength){ // Suggestion (would require removing rest of the block inside this if clause !): //ReturnValue_t result = AutoSerializeAdapter::deSerialize(&bufferLength,buffer,size,bigEndian); //if (result != HasReturnvaluesIF::RETURN_OK) { // return result; //} count_t serializedSize = AutoSerializeAdapter::getSerializedSize( - &m_buffer_length); - if((*size - m_buffer_length - serializedSize) >= 0){ + &bufferLength); + if((*size - bufferLength - serializedSize) >= 0){ *buffer += serializedSize; *size -= serializedSize; }else{ @@ -82,10 +82,10 @@ ReturnValue_t SerialBufferAdapter::deSerialize(const uint8_t** buffer, } } //No Else If, go on with buffer - if (*size - m_buffer_length >= 0) { - *size -= m_buffer_length; - memcpy(m_buffer, *buffer, m_buffer_length); - (*buffer) += m_buffer_length; + if (*size - bufferLength >= 0) { + *size -= bufferLength; + memcpy(m_buffer, *buffer, bufferLength); + (*buffer) += bufferLength; return HasReturnvaluesIF::RETURN_OK; } else { return STREAM_TOO_SHORT; @@ -106,17 +106,17 @@ uint8_t * SerialBufferAdapter::getBuffer() { template const uint8_t * SerialBufferAdapter::getConstBuffer() { - if(m_const_buffer == nullptr) { + if(constBuffer == nullptr) { error << "Wrong access function for stored type ! Use getBuffer()" << std::endl; return nullptr; } - return m_const_buffer; + return constBuffer; } template void SerialBufferAdapter::setBuffer(void * buffer, count_t buffer_length) { m_buffer = static_cast(buffer); - m_buffer_length = buffer_length; + bufferLength = buffer_length; } diff --git a/serialize/SerialBufferAdapter.h b/serialize/SerialBufferAdapter.h index ff2083de1..cf3ae07ed 100644 --- a/serialize/SerialBufferAdapter.h +++ b/serialize/SerialBufferAdapter.h @@ -52,10 +52,10 @@ public: const uint8_t * getConstBuffer(); void setBuffer(void* buffer_, count_t bufferLength_); private: - bool m_serialize_length = false; - const uint8_t *m_const_buffer = nullptr; + bool serializeLength = false; + const uint8_t *constBuffer = nullptr; uint8_t *m_buffer = nullptr; - count_t m_buffer_length = 0; + count_t bufferLength = 0; }; diff --git a/serviceinterface/ServiceInterfaceStream.h b/serviceinterface/ServiceInterfaceStream.h index 32bc263ee..44cf1168f 100644 --- a/serviceinterface/ServiceInterfaceStream.h +++ b/serviceinterface/ServiceInterfaceStream.h @@ -7,7 +7,8 @@ #include #include -//Unfortunately, there must be a forward declaration of log_fe (MUST be defined in main), to let the system know where to write to. +//Unfortunately, there must be a forward declaration of log_fe +// (MUST be defined in main), to let the system know where to write to. extern std::ostream debug; extern std::ostream info; extern std::ostream warning; diff --git a/timemanager/CCSDSTime.cpp b/timemanager/CCSDSTime.cpp index 29aafb68d..47cab911d 100644 --- a/timemanager/CCSDSTime.cpp +++ b/timemanager/CCSDSTime.cpp @@ -196,7 +196,8 @@ ReturnValue_t CCSDSTime::convertFromASCII(Clock::TimeOfDay_t* to, const uint8_t* to->usecond = (second - floor(second)) * 1000000; return RETURN_OK; } -// Warning: Compiler/Linker fails ambiguously if library does not implement C99 I/O +// Warning: Compiler/Linker fails ambiguously if library does not implement +// C99 I/O #else uint16_t year; uint8_t month;