From 97b01f837ceaf876ec2939150c444c23e7d6040e Mon Sep 17 00:00:00 2001
From: "Robin.Mueller" <robin.mueller.m@gmail.com>
Date: Fri, 10 Jul 2020 14:29:17 +0200
Subject: [PATCH] srv8 improvements

---
 pus/Service8FunctionManagement.cpp   |  9 +++++-
 pus/servicepackets/Service8Packets.h | 41 ++++++++++++++--------------
 2 files changed, 29 insertions(+), 21 deletions(-)

diff --git a/pus/Service8FunctionManagement.cpp b/pus/Service8FunctionManagement.cpp
index 812398b94..50102b04c 100644
--- a/pus/Service8FunctionManagement.cpp
+++ b/pus/Service8FunctionManagement.cpp
@@ -59,8 +59,15 @@ ReturnValue_t Service8FunctionManagement::prepareCommand(
 
 ReturnValue_t Service8FunctionManagement::prepareDirectCommand(
 		CommandMessage *message, const uint8_t *tcData, size_t tcDataLen) {
+    if(tcDataLen < sizeof(object_id_t) + sizeof(ActionId_t)) {
+        sif::debug << "Service8FunctionManagement::prepareDirectCommand:"
+                << " TC size smaller thant minimum size of direct command."
+                << std::endl;
+        return CommandingServiceBase::INVALID_TC;
+    }
+
 	// Create direct command instance by extracting data from Telecommand
-	DirectCommand command(tcData,tcDataLen);
+	DirectCommand command(tcData, tcDataLen);
 
 	// store additional parameters into the IPC Store
 	store_address_t parameterAddress;
diff --git a/pus/servicepackets/Service8Packets.h b/pus/servicepackets/Service8Packets.h
index 5ef912806..86681c142 100644
--- a/pus/servicepackets/Service8Packets.h
+++ b/pus/servicepackets/Service8Packets.h
@@ -8,10 +8,7 @@
  *   3. Return Code
  *   4. Optional step number for step replies
  *
- * Data reply (subservice 132) consists of
- *   1. Target Object ID
- *   2. Action ID
- *   3. Data
+
  *
  *  \date 01.07.2019
  *  \author R. Mueller
@@ -29,23 +26,21 @@
 
 
 /**
- * \brief Subservice 128
- * \ingroup spacepackets
+ * @brief Subservice 128
+ * @ingroup spacepackets
  */
 class DirectCommand: public SerialLinkedListAdapter<SerializeIF> { //!< [EXPORT] : [SUBSERVICE] 128
 public:
-	//typedef uint16_t typeOfMaxData;
-	//static const typeOfMaxData MAX_DATA = 256;
-	DirectCommand(const uint8_t* dataBuffer_, uint32_t size_) {
-		size_t size = sizeof(objectId);
-		SerializeAdapter::deSerialize(&objectId,&dataBuffer_,&size,
+
+	DirectCommand(const uint8_t* tcData, size_t size) {
+		SerializeAdapter::deSerialize(&objectId, &tcData, &size,
 		        SerializeIF::Endianness::BIG);
-		size = sizeof(actionId);
-		SerializeAdapter::deSerialize(&actionId,&dataBuffer_,&size,
+		SerializeAdapter::deSerialize(&actionId, &tcData, &size,
 		        SerializeIF::Endianness::BIG);
-		parameterBuffer = dataBuffer_;
-		parametersSize = size_ - sizeof(objectId) - sizeof(actionId);
+		parameterBuffer = tcData;
+		parametersSize = size;
 	}
+
 	ActionId_t getActionId() const {
 		return actionId;
 	}
@@ -73,8 +68,12 @@ private:
 
 
 /**
- * \brief Subservice 130
- * \ingroup spacepackets
+ * @brief Subservice 130
+ * Data reply (subservice 130) consists of
+ *   1. Target Object ID
+ *   2. Action ID
+ *   3. Data
+ * @ingroup spacepackets
  */
 class DataReply: public SerialLinkedListAdapter<SerializeIF> { //!< [EXPORT] : [SUBSERVICE] 130
 public:
@@ -100,8 +99,10 @@ private:
 
 
 /**
- * \brief Subservice 132
- * \ingroup spacepackets
+ * @brief Subservice 132
+ * @details
+ * Not used yet. Telecommand Verification takes care of this.
+ * @ingroup spacepackets
  */
 class DirectReply: public SerialLinkedListAdapter<SerializeIF> { //!< [EXPORT] : [SUBSERVICE] 132
 public:
@@ -124,7 +125,7 @@ private:
 			returnCode.setNext(&step);
 		}
 	}
-	bool isDataReply; //!< [EXPORT] : [IGNORE]
+
 	bool isStep; //!< [EXPORT] : [IGNORE]
 	SerializeElement<object_id_t> objectId; //!< [EXPORT] : [IGNORE]
 	SerializeElement<ActionId_t> actionId; //!< [EXPORT] : [IGNORE]