From a5e6107001a7b19d1f22a617849be27d640ec3d0 Mon Sep 17 00:00:00 2001 From: Ulrich Mohr Date: Wed, 14 Sep 2022 16:31:36 +0200 Subject: [PATCH] bug found by unittest --- src/fsfw/action/SimpleActionHelper.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/fsfw/action/SimpleActionHelper.cpp b/src/fsfw/action/SimpleActionHelper.cpp index e9573a344..34ff2d2a7 100644 --- a/src/fsfw/action/SimpleActionHelper.cpp +++ b/src/fsfw/action/SimpleActionHelper.cpp @@ -57,7 +57,7 @@ void SimpleActionHelper::prepareExecution(MessageQueueId_t commandedBy, ActionId } Action* action = actionIter->second; result = action->deSerialize(&dataPtr, &size, SerializeIF::Endianness::NETWORK); - if (result != HasReturnvaluesIF::RETURN_OK){ + if ((result != returnvalue::OK) or (size != 0)) { CommandMessage reply; ActionMessage::setStepReply(&reply, actionId, 0, HasActionsIF::INVALID_PARAMETERS); queueToUse->sendMessage(commandedBy, &reply);