Bugfix for Space Packet Parser #673

Merged

mohr merged 3 commits from eive/fsfw:mueller/fixes-tmtc-server-sp-parser into development

2022-09-01 14:12:17 +02:00

muellerr commented

2022-09-01 08:55:18 +02:00

Owner

The previous implementation was buggy and did not work when several space packets were clumped together, which happens when the packets are sent with a very short delay (0-0.1 seconds). Also, the API structure made it confusing to use. This might even be the reason it did not work, so I improved that. The parser is not used anywhere else.
I would actually prefer an implementation which uses a whole framing layer. I think the current scheme was used because TCP guarantees data delivery, but using something like DLE or COBS might be the cleaner way.

- The previous implementation was buggy and did not work when several space packets were clumped together, which happens when the packets are sent with a very short delay (0-0.1 seconds). Also, the API structure made it confusing to use. This might even be the reason it did not work, so I improved that. The parser is not used anywhere else. - I would actually prefer an implementation which uses a whole framing layer. I think the current scheme was used because TCP guarantees data delivery, but using something like DLE or [COBS](https://en.wikipedia.org/wiki/Consistent_Overhead_Byte_Stuffing) might be the cleaner way.

muellerr added 1 commit 2022-09-01 08:55:19 +02:00

fsfw/fsfw/pipeline/pr-development This commit looks good Details

28ecd0e5c6

bugfix for SP parser

muellerr changed title from ~~bugfix for SP parser~~ to TODO: bugfix for SP parser

2022-09-01 08:55:41 +02:00

muellerr changed title from ~~TODO: bugfix for SP parser~~ to WIP: bugfix for SP parser

2022-09-01 08:55:57 +02:00

muellerr added this to the v6.0.0 milestone 2022-09-01 08:56:00 +02:00

muellerr added the

Breaking API Change

labels 2022-09-01 08:56:10 +02:00

muellerr removed the

label 2022-09-01 08:58:48 +02:00

muellerr added 1 commit 2022-09-01 10:52:43 +02:00

fsfw/fsfw/pipeline/pr-development This commit looks good Details

01651f0521 more simplfications

muellerr commented

2022-09-01 10:53:15 +02:00

Author

Owner

If this is merged after #655 , i might add some unittests

If this is merged after https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/655 , i might add some unittests

muellerr changed title from ~~WIP: bugfix for SP parser~~ to Bugfix for Space Packet Parser

2022-09-01 11:15:08 +02:00

muellerr added 1 commit 2022-09-01 11:21:05 +02:00

fsfw/fsfw/pipeline/pr-development This commit looks good Details

67980cb592 Merge branch 'development' into mueller/fixes-tmtc-server-sp-parser

mohr approved these changes 2022-09-01 14:10:41 +02:00

mohr left a comment

Owner

Seems fine.

+1 on using a dedicated framing layer when sending Spacepackets over TCP.

Seems fine. +1 on using a dedicated framing layer when sending Spacepackets over TCP.

mohr merged commit eb8e236cd4 into development

2022-09-01 14:12:17 +02:00

mohr referenced this issue from a commit

2022-09-01 14:12:17 +02:00

Merge pull request 'Bugfix for Space Packet Parser' (#673) from eive/fsfw:mueller/fixes-tmtc-server-sp-parser into development

mohr deleted branch mueller/fixes-tmtc-server-sp-parser

2022-09-01 14:12:23 +02:00

Sign in to join this conversation.

No reviewers

No Label

Breaking API Change

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#673

No description provided.