Local Pool Update Remove Add Data Ignore Fault Argument #701

Merged
gaisser merged 16 commits from eive/fsfw:mueller/local-pool-update-remove-ignore-fault-arg into development 2022-11-14 14:49:37 +01:00
Owner
  • Like #685 but remove API which expects ignore fault flag (getFreeElement and addData). Make it a member of LocalPool.
    If this is merged, #685 can be closed

  • Remaining Questions: It is possible to avoid the explicit namespace specifiers by giving the helper functions unique names. Consider whether this could be a better solution, this also makes the purpose of the functions clearer

- Like https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/685 but remove API which expects ignore fault flag (getFreeElement and addData). Make it a member of LocalPool. If this is merged, https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/685 can be closed - Remaining Questions: It is possible to avoid the explicit namespace specifiers by giving the helper functions unique names. Consider whether this could be a better solution, this also makes the purpose of the functions clearer
muellerr added 12 commits 2022-10-24 16:08:30 +02:00
fsfw/fsfw/pipeline/head Build started... Details
fsfw/fsfw/pipeline/pr-development This commit looks good Details
b3c0e24611
bump changelog
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
e063b44899
add link to PR
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
1db77753e3
Merge remote-tracking branch 'origin/development' into mueller/local-pool-update
fsfw/fsfw/pipeline/pr-development This commit looks good Details
bfe120636c
this should have the same effect
fsfw/fsfw/pipeline/pr-development This commit looks good Details
dd2f42d22b
Merge branch 'development' into mueller/local-pool-update
fsfw/fsfw/pipeline/pr-development This commit looks good Details
73e313c35b
Merge branch 'development' into mueller/local-pool-update
fsfw/fsfw/pipeline/pr-development This commit looks good Details
d26f230bee
builds
muellerr requested review from mohr 2022-10-24 16:08:36 +02:00
muellerr requested review from gaisser 2022-10-24 16:08:44 +02:00
muellerr added 1 commit 2022-10-24 16:39:31 +02:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
81a7de2814
make dtor virtual
muellerr added 1 commit 2022-10-28 10:05:59 +02:00
muellerr added this to the v6.0.0 milestone 2022-10-28 10:07:12 +02:00
muellerr changed title from Local Pool Update Remote Ignore Fault Argument to Local Pool Update Remove Ignore Fault Argument 2022-11-14 14:14:56 +01:00
muellerr changed title from Local Pool Update Remove Ignore Fault Argument to Local Pool Update Remove Add Data Ignore Fault Argument 2022-11-14 14:19:26 +01:00
muellerr added 1 commit 2022-11-14 14:20:47 +01:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
1bea2344f6
remove using declaraction
mohr approved these changes 2022-11-14 14:40:04 +01:00
muellerr added the
Breaking API Change
label 2022-11-14 14:40:52 +01:00
gaisser approved these changes 2022-11-14 14:47:04 +01:00
gaisser left a comment
Owner

LGTM

LGTM
gaisser added 1 commit 2022-11-14 14:47:13 +01:00
gaisser added a new dependency 2022-11-14 14:48:27 +01:00
gaisser merged commit 69d338f9bb into development 2022-11-14 14:49:36 +01:00
gaisser deleted branch mueller/local-pool-update-remove-ignore-fault-arg 2022-11-14 14:50:06 +01:00
Sign in to join this conversation.
No description provided.