fsfw/fsfw
fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Device Handler Base Proposals #15

Closed
muellerr wants to merge 3 commits from KSat:mueller_DeviceHandlerBase_Changes into master
pull from: KSat:mueller_DeviceHandlerBase_Changes
merge into: fsfw:master
Conversation 3 Commits 3 Files Changed 2 +128 -99
muellerr commented 2020-02-05 17:46:23 +01:00
Owner
Copy Link
  1. Interface functions moved closer to top (and functions which should
    be implemented)
  2. ioBoardAddress renamed to logicalAddress. getter FUnction added.
  3. debug interface for easier debugging of device handlers
  4. new documentation
  5. new return value for scanForReply to ignore full packet
1. Interface functions moved closer to top (and functions which should be implemented) 2. ioBoardAddress renamed to logicalAddress. getter FUnction added. 3. debug interface for easier debugging of device handlers 4. new documentation 5. new return value for scanForReply to ignore full packet
gaisser added the
feature
 label 2020-03-20 15:18:38 +01:00
muellerr commented 2020-03-23 18:01:00 +01:00
Author
Owner
Copy Link

Rework for new Com IF in progress, replacing uint32_t by size_t (triggers chain reaction with some other framework components still using uint32_t)...
Work - in -progress

Rework for new Com IF in progress, replacing uint32_t by size_t (triggers chain reaction with some other framework components still using uint32_t)... Work - in -progress
muellerr commented 2020-03-23 19:24:29 +01:00
Author
Owner
Copy Link

New CookieIF generic interface to avoid dynamnic casting in factory.
also introduces setMaxReplyLength as virtual abstract function.

this function is called in DHB to set the maxReplyLength passed from child device handlers.

New CookieIF generic interface to avoid dynamnic casting in factory. also introduces setMaxReplyLength as virtual abstract function. this function is called in DHB to set the maxReplyLength passed from child device handlers.
muellerr commented 2020-04-01 12:50:23 +02:00
Author
Owner
Copy Link

Changes agreed on 01.04 incorporated.
Cookie.h renamed to CookieIF.h , documentation added.

  • requestLen in requestReceiveMessage is now set to 0 if no respective reply was found.
  • requestLen is set in the command and reply map set up.
  • Documentation for requestReceiveMessage() adapted.
  • maxReplyLen is not passed to DHB anymore, its supposed to be part of the specific communication used(comIF or cookie)
  • logicalAddress not member of DHB anymore, DHB should not know about the logicalAddress, which is a part of the specific communication used.
Changes agreed on 01.04 incorporated. Cookie.h renamed to CookieIF.h , documentation added. - requestLen in requestReceiveMessage is now set to 0 if no respective reply was found. - requestLen is set in the command and reply map set up. - Documentation for requestReceiveMessage() adapted. - maxReplyLen is not passed to DHB anymore, its supposed to be part of the specific communication used(comIF or cookie) - logicalAddress not member of DHB anymore, DHB should not know about the logicalAddress, which is a part of the specific communication used.
muellerr closed this pull request 2020-05-23 21:28:34 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
feature
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#15
No description provided.
Delete Branch "KSat:mueller_DeviceHandlerBase_Changes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?