fsfw/fsfw
fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Action folder: minor form improvements, include guards #235

Merged
gaisser merged 13 commits from KSat/fsfw:mueller/action-update into master 2020-10-29 19:59:07 +01:00
Conversation 2 Commits 13 Files Changed 5 +151 -59
muellerr commented 2020-10-10 17:21:45 +02:00
Owner
Copy Link

Also added new function in ActionHelper to handle raw data reporting.

Also added new function in ActionHelper to handle raw data reporting.
muellerr changed title from minor form improvements, include guards to Action folder: minor form improvements, include guards 2020-10-12 18:33:04 +02:00
muellerr added the
feature
 label 2020-10-12 18:33:13 +02:00
gaisser reviewed 2020-10-27 14:35:23 +01:00
action/ActionHelper.cpp Outdated
@ -112,0 +141,4 @@
ActionMessage::setDataReply(&reply, replyId, storeAddress);
// TODO: Service Implementation sucks at the moment
// TODO: why does it suck and why would someone need to hide the sender?
gaisser commented 2020-10-27 14:35:23 +01:00
Owner
Copy Link

Please remove these comments.

Please remove these comments.
gaisser reviewed 2020-10-27 14:35:40 +01:00
action/ActionHelper.cpp Outdated
@ -98,2 +104,2 @@
//TODO Service Implementation sucks at the moment
if (hideSender){
// TODO: Service Implementation sucks at the moment
// TODO: why does it suck and why would someone need to hide the sender?
gaisser commented 2020-10-27 14:35:40 +01:00
Owner
Copy Link

Please remove these comments.

Please remove these comments.
gaisser added this to the Release Apollo-Sojus-Test-Project (ASTP) 0.0.1 milestone 2020-10-27 14:36:07 +01:00
gaisser merged commit de5e62a9c8 into master 2020-10-29 19:59:06 +01:00
gaisser deleted branch mueller/action-update 2020-10-29 19:59:10 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
feature
Milestone
No items
No Milestone Release Apollo-Sojus-Test-Project (ASTP) 0.0.1
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#235
No description provided.
Delete Branch "KSat/fsfw:mueller/action-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?