Added CFDP packet stack #528

2021-12-03T15:39:59+01:00

muellerr commented

2021-12-03 15:39:59 +01:00

This PR adds the packet stack for the CCSDS File Delivery Protocol.
It also refactors the existing TMTC infastructure to allow sending
of CFDP packets to the CCSDS handlers.

This includes the whole PDU (Protocol Data Unit) stack:

File Data PDUs

and all file directive PDUs

ACK PDU
NAK PDU
Metadata PDU
Finished PDU
Prompt PDU
Keep Alive PDU
EOF PDU

The PR includes a full set of unittests for the packet stack
with a coverage of 90+ %.

The refactoring of the existing TMTC infastructure includes non-ideal
solutions like diamond inheritance.
Avoiding this solution would require refactoring the packet stack.
This would be a good idea anyway because the existing stack is tightly
coupled to the FSFW, making reuse more difficult if only the stack is
planned to be used without the store functionalities etc.

The PDU implementation provided here is only weakly coupled to the FSFW,
only using components like returnvalues or the Serialization modules.
There are dedicated serializers and deserializers, which also helps in
creating small focused modules which are easy to test. Deserializers mostly operate
on raw buffers and expose their functionality through the parseData function while
serializers provide a convenient high-level interface.

Some of the modules here were provied by Matthias Tompert.

This PR adds the packet stack for the CCSDS File Delivery Protocol. It also refactors the existing TMTC infastructure to allow sending of CFDP packets to the CCSDS handlers. This includes the whole PDU (Protocol Data Unit) stack: - File Data PDUs and all file directive PDUs - ACK PDU - NAK PDU - Metadata PDU - Finished PDU - Prompt PDU - Keep Alive PDU - EOF PDU The PR includes a full set of unittests for the packet stack with a coverage of 90+ %. The refactoring of the existing TMTC infastructure includes non-ideal solutions like diamond inheritance. Avoiding this solution would require refactoring the packet stack. This would be a good idea anyway because the existing stack is tightly coupled to the FSFW, making reuse more difficult if only the stack is planned to be used without the store functionalities etc. The PDU implementation provided here is only weakly coupled to the FSFW, only using components like returnvalues or the Serialization modules. There are dedicated serializers and deserializers, which also helps in creating small focused modules which are easy to test. Deserializers mostly operate on raw buffers and expose their functionality through the `parseData` function while serializers provide a convenient high-level interface. Some of the modules here were provied by Matthias Tompert.

muellerr added 1 commit 2021-12-03 15:40:03 +01:00

Added CFDP packet stack 5907f8ee9d

This PR adds the packet stack for the CCSDS File Delivery Protocol.
It also refactors the existing TMTC infastructure to allow sending
of CFDP packets to the CCSDS handlers.

This includes the whole PDU (Protocol Data Unit) stack:

- File Data PDUs

and all file directive PDUs

- ACK PDU
- NAK PDU
- Metadata PDU
- Finished PDU
- Prompt PDU
- Keep Alive PDU
- EOF PDU

The PR includes a full set of unittests for the packet stack
with a coverage of 90+ %.

The refactoring of the existing TMTC infastructure includes non-ideal
solutions like diamond inheritance.
Avoiding this solution would require refactoring the packet stack.
This would be a good idea anyway because the existing stack is tightly
coupled to the FSFW, making reuse more difficult if only the stack is
planned to be used without the store functionalities etc.

The PDU implementation provided here is only weakly coupled to the FSFW,
only using components like returnvalues or the Serialization modules.
There are dedicated serializers and deserializers, which also helps in
creating small focused modules which are easy to test.

Some of the modules here were provied by Matthias Tompert.

muellerr requested review from mohr 2021-12-03 15:40:16 +01:00

muellerr requested review from gaisser 2021-12-03 15:40:23 +01:00

muellerr added this to the v3.0.0 milestone 2021-12-03 15:41:27 +01:00

muellerr added the feature Refactor Breaking API Change labels 2021-12-03 15:41:40 +01:00

gaisser added 1 commit 2021-12-06 15:07:53 +01:00

Merge branch 'development' into mueller/cfdp-pdus

fsfw/fsfw/pipeline/pr-development There was a failure building this commit

Details

c3a0aabfb8

muellerr added 2 commits 2021-12-06 16:12:40 +01:00

Merge remote-tracking branch 'upstream/development' into mueller/cfdp-pdus 602fa3a956

Merge branch 'mueller/cfdp-pdus' of https://egit.irs.uni-stuttgart.de/KSat/fsfw into mueller/cfdp-pdus