do send read hook #545

meierj · 2022-02-03T10:50:42+01:00

meierj commented

2022-02-03 10:50:42 +01:00

a function to insert device specific code during the doSendRead step
required this to stop the DHB from permanently polling the communication interface

* a function to insert device specific code during the doSendRead step * required this to stop the DHB from permanently polling the communication interface

meierj added 1 commit 2022-02-03 10:50:50 +01:00

fsfw/fsfw/pipeline/head fixing jenkins bug Details

fsfw/fsfw/pipeline/pr-development This commit looks good Details

06ffe27fcc do send read hook

mohr commented

2022-02-04 14:31:52 +01:00

Could you explain why you would want to do this? The ComIF is per design a polling interface, which needs to be polled to get any new data.

Do you have some special way of knowing when to poll and when not to poll?

Or do you have a device which will not reply at all? In this case, you might be able to just do not schedule the two read steps for the device at all.

It is just that for me, this does not make much sense in the contex of a polling interface and as such I am not much inclined to add this.

Could you explain why you would want to do this? The ComIF is per design a polling interface, which needs to be polled to get any new data. Do you have some special way of knowing when to poll and when not to poll? Or do you have a device which will not reply at all? In this case, you might be able to just do not schedule the two read steps for the device at all. It is just that for me, this does not make much sense in the contex of a polling interface and as such I am not much inclined to add this.

mohr self-assigned this 2022-02-04 14:32:03 +01:00

muellerr added 1 commit 2022-02-07 14:17:10 +01:00

fsfw/fsfw/pipeline/pr-development This commit looks good Details

fsfw/fsfw/pipeline/head This commit looks good Details

8ab8c57f9c Merge branch 'development' into meier/doSendReadHook

mohr commented

2022-02-07 14:23:41 +01:00

As per developer meeting:
Functionality is used for temporarily passing access to a communication interface to a subtask.

As currently there is no better way to implement this, it is seen as acceptable implementation.

As per developer meeting: Functionality is used for temporarily passing access to a communication interface to a subtask. As currently there is no better way to implement this, it is seen as acceptable implementation.

mohr approved these changes 2022-02-07 14:24:09 +01:00

mohr left a comment

doe not look good to me, but I will accept it ;)

mohr added this to the v4.0.0 milestone 2022-02-07 14:37:24 +01:00

mohr added the

API Change

label 2022-02-07 14:37:59 +01:00

mohr merged commit 9b17b282c6 into development

2022-02-07 14:42:05 +01:00

mohr referenced this issue from a commit

2022-02-07 14:42:06 +01:00

Merge pull request 'do send read hook' (#545) from meier/doSendReadHook into development