Activates new gcc compiler flags #568

Merged
muellerr merged 8 commits from gaisser/fsfw:gaisser_compiler_flags into development 2022-03-07 14:44:10 +01:00
Owner

Activates compiler flags according to #446.

  • Fixed some issues that came up and were easy to fix
  • Reported #566 and #567
  • Fixed some missing includes
  • Fixed some const completeness
  • Added unit tests for CRC and some CCSDSTime functions which have been changed by this commit
  • Applied Clang format
Activates compiler flags according to #446. * Fixed some issues that came up and were easy to fix * Reported #566 and #567 * Fixed some missing includes * Fixed some const completeness * Added unit tests for CRC and some CCSDSTime functions which have been changed by this commit * Applied Clang format
gaisser added 4 commits 2022-02-23 22:40:43 +01:00
gaisser added this to the v5.0.0 milestone 2022-02-23 22:43:38 +01:00
gaisser added the
bug
build
labels 2022-02-23 22:43:50 +01:00
muellerr requested changes 2022-02-24 10:39:21 +01:00
@ -1,11 +1,13 @@
#ifndef FSFW_SRC_FSFW_CFDP_FILESTOREREQUESTBASE_H_
#define FSFW_SRC_FSFW_CFDP_FILESTOREREQUESTBASE_H_
#include <FSFWConfig.h>
Owner

Would be good to replace this with #include "fsfw/FSFW.h". That file includes the config but is also able to sanitize some of the values.

Would be good to replace this with `#include "fsfw/FSFW.h"`. That file includes the config but is also able to sanitize some of the values.
Author
Owner

Done

Done
gaisser marked this conversation as resolved
muellerr requested changes 2022-02-24 10:42:06 +01:00
@ -1,6 +1,8 @@
#ifndef FSFW_SERVICEINTERFACE_SERVICEINTERFACEPRINTER
#define FSFW_SERVICEINTERFACE_SERVICEINTERFACEPRINTER
#include <FSFWConfig.h>
Owner

Use #include "fsfw/FSFW.h" here

Use `#include "fsfw/FSFW.h"` here
Author
Owner

Done

Done
gaisser marked this conversation as resolved
@ -1,5 +1,7 @@
#include "fsfw/storagemanager/LocalPool.h"
#include <FSFWConfig.h>
Owner

Use #include "fsfw/FSFW.h" here

Use `#include "fsfw/FSFW.h"` here
Author
Owner

Done

Done
gaisser marked this conversation as resolved
gaisser added 1 commit 2022-02-24 11:23:19 +01:00
Fixed include based on Feedback
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
0e8328fca3
gaisser added 1 commit 2022-02-28 15:30:05 +01:00
Merge branch 'development' into gaisser_compiler_flags
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
68ca6fd122
gaisser added 1 commit 2022-03-07 13:09:25 +01:00
Merge branch 'development' into gaisser_compiler_flags
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
14b44f8bb2
gaisser added 1 commit 2022-03-07 14:39:05 +01:00
muellerr approved these changes 2022-03-07 14:42:37 +01:00
muellerr merged commit 5912ddd2a2 into development 2022-03-07 14:44:10 +01:00
muellerr deleted branch gaisser_compiler_flags 2022-03-07 14:44:11 +01:00
Sign in to join this conversation.
No description provided.