fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Allow passing a MqArgs struct to the MQ creation #583

Merged
mohr merged 12 commits from eive/fsfw:mueller/ipc-pass-arbitrary-args-to-mq into development 2022-04-25 14:43:53 +02:00
Conversation 2 Commits 12 Files Changed 22 +309 -712
muellerr commented 2022-03-22 17:51:11 +01:00
Owner
Copy Link
  • The struct contains context information (which can be extended)
    and an arbitrary user argument in form of a void pointer.
    This makes the API a lot more flexible. Even if a MQ is not tied to a particular
    object, in most use-cases it is. The object information can make debugging easier
  • Simplified and streamlined MessageQueue code. There is a lot of generic code where the actual interface implementation is the same across multiple OSALs. I moved this implementation to a base class where this was the case
- The struct contains context information (which can be extended) and an arbitrary user argument in form of a void pointer. This makes the API a lot more flexible. Even if a MQ is not tied to a particular object, in most use-cases it is. The object information can make debugging easier - Simplified and streamlined MessageQueue code. There is a lot of generic code where the actual interface implementation is the same across multiple OSALs. I moved this implementation to a base class where this was the case
muellerr added 1 commit 2022-03-22 17:51:16 +01:00
Allow passing a MqArgs struct to the MQ creation
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
a0dfdfab2c 
The struct contains context information (which can be extended)
and an arbitrary user argument in form of a void pointer.
This makes the API a lot more flexible
muellerr added the
API Change
 label 2022-03-22 17:56:12 +01:00
muellerr added this to the v5.0.0 milestone 2022-03-22 17:56:15 +01:00
gaisser requested changes 2022-03-28 17:00:14 +02:00
gaisser left a comment
Owner
Copy Link

I'm not a big fan of void* args stuff but I can see that this might be useful in some cases.

I'm not a big fan of void* args stuff but I can see that this might be useful in some cases.
src/fsfw/ipc/definitions.h
@ -0,0 +5,4 @@
struct MqArgs {
MqArgs(){};
MqArgs(object_id_t objectId, void* args = nullptr) : objectId(objectId), args(args) {}
object_id_t objectId = 0;
gaisser commented 2022-03-28 16:52:53 +02:00
Owner
Copy Link

This should be NO_OBJECT instead of 0

This should be NO_OBJECT instead of 0
gaisser marked this conversation as resolved
src/fsfw/osal/rtems/MessageQueue.cpp Outdated
@ -8,3 +8,3 @@
MessageQueue::MessageQueue(size_t message_depth, size_t max_message_size)
MessageQueue::MessageQueue(size_t message_depth, size_t max_message_size, MqArgs* args)
: id(0), lastPartner(0), defaultDestination(NO_QUEUE), internalErrorReporter(nullptr) {
gaisser commented 2022-03-28 16:58:06 +02:00
Owner
Copy Link

Not part of your Code but we should use NO_QUEUE for id und lastPartner

Not part of your Code but we should use NO_QUEUE for id und lastPartner
gaisser marked this conversation as resolved
mohr commented 2022-03-31 14:31:32 +02:00
Owner
Copy Link

I support the idea, two remarks:

  1. PLease implement it for all available OSALs, right now only the linux MQ has a member storing the data.

  2. Would it make sense to add a getter in the MQIF? This way, one could generically use the metadata, as otherwise the object needs to be casted to the correct implementation, which is cumbersome during debugging and borderline forbidden in running code.

I support the idea, two remarks: 1. PLease implement it for all available OSALs, right now only the linux MQ has a member storing the data. 2. Would it make sense to add a getter in the MQIF? This way, one could generically use the metadata, as otherwise the object needs to be casted to the correct implementation, which is cumbersome during debugging and borderline forbidden in running code.
muellerr added 1 commit 2022-03-31 14:42:23 +02:00
Merge branch 'development' into mueller/ipc-pass-arbitrary-args-to-mq
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
fcb6437388
gaisser changed title from Allow passing a MqArgs struct to the MQ creation to WIP: Allow passing a MqArgs struct to the MQ creation 2022-04-04 14:06:36 +02:00
muellerr added 1 commit 2022-04-04 17:21:15 +02:00
Merge branch 'development' into mueller/ipc-pass-arbitrary-args-to-mq
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
a011e70665
muellerr added 2 commits 2022-04-11 13:55:10 +02:00 
- Generic code was duplicated across all OSALs.
  Is contained in generic base class now
- Remove duplicate documentation
tests running again
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
82df132e7d
muellerr added 1 commit 2022-04-11 13:59:50 +02:00
take upstream impl of local data pool manager
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
ed2c2af4a0
muellerr added 1 commit 2022-04-11 14:00:52 +02:00
correct init value for object ID
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
8c2105ae0a
muellerr commented 2022-04-11 14:03:37 +02:00
Author
Owner
Copy Link
  • Added getMqArgs function to interface
  • Added MQ Args Storing to all OSALs by integrating it in new MessageQueueBase class
- Added `getMqArgs` function to interface - Added MQ Args Storing to all OSALs by integrating it in new `MessageQueueBase` class
muellerr added 1 commit 2022-04-11 14:07:11 +02:00
update IF method
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
95f018a0b0
muellerr requested review from mohr 2022-04-11 14:30:38 +02:00
muellerr changed title from WIP: Allow passing a MqArgs struct to the MQ creation to Allow passing a MqArgs struct to the MQ creation 2022-04-11 14:38:18 +02:00
muellerr added 1 commit 2022-04-11 16:12:00 +02:00
Merge branch 'development' into mueller/ipc-pass-arbitrary-args-to-mq
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
82f46992f6
muellerr added 2 commits 2022-04-11 16:13:59 +02:00
muellerr added 1 commit 2022-04-12 17:06:34 +02:00
Merge branch 'development' into mueller/ipc-pass-arbitrary-args-to-mq
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
97e98eae24
gaisser approved these changes 2022-04-25 14:41:56 +02:00
mohr approved these changes 2022-04-25 14:42:02 +02:00
mohr self-assigned this 2022-04-25 14:43:21 +02:00
mohr merged commit 126ac52975 into development 2022-04-25 14:43:53 +02:00
mohr deleted branch mueller/ipc-pass-arbitrary-args-to-mq 2022-04-25 14:43:53 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
gaisser
mohr
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v5.0.0
Assignees
Clear assignees
No Assignees
mohr
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#583
No description provided.
Delete Branch "eive/fsfw:mueller/ipc-pass-arbitrary-args-to-mq"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?