fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

Possible Ring Buffer Fix #586

Merged
muellerr merged 20 commits from eive/fsfw:mueller/possible-ring-buffer-fix into development 2022-07-25 10:12:40 +02:00
Conversation 3 Commits 20 Files Changed 3 +32 -8
muellerr commented 2022-03-24 16:47:22 +01:00
Owner
Copy Link

Avoid memory leak if passed data is greater than maximum allowed size and overwriteOld iset set to true.

Avoid memory leak if passed data is greater than maximum allowed size and overwriteOld iset set to true.
muellerr added 2 commits 2022-03-24 16:47:29 +01:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
a891769a02
ring buffer cfg error warning
muellerr requested review from gaisser 2022-03-24 16:47:36 +01:00
muellerr added this to the v5.0.0 milestone 2022-03-24 16:47:43 +01:00
muellerr added the
bug
 label 2022-03-24 16:47:48 +01:00
muellerr added 1 commit 2022-03-24 16:51:48 +01:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
8a44c498c5 add two additional tests for ring buffer
muellerr added 1 commit 2022-03-24 20:58:06 +01:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
879223f38f
added nullptr check
muellerr added 1 commit 2022-03-24 21:01:28 +01:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
23f8e5cb41
some more tests fail
gaisser added 1 commit 2022-03-25 15:21:56 +01:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
ad57e6713e Fixed Unittests
gaisser added the
Breaking API Change
 label 2022-03-25 15:23:37 +01:00
gaisser added 1 commit 2022-03-25 15:27:34 +01:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
70f575396d Added changelog
gaisser commented 2022-03-25 15:29:09 +01:00
Owner
Copy Link

Fixed Unittests

Fixed Unittests
gaisser refused to review 2022-03-25 15:30:34 +01:00
gaisser requested review from mohr 2022-03-25 15:30:39 +01:00
gaisser changed title from WIP: Possible Ring Buffer Fix to Possible Ring Buffer Fix 2022-03-25 18:38:06 +01:00
muellerr added 1 commit 2022-03-28 15:03:06 +02:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
f598f7030f
Merge remote-tracking branch 'upstream/development' into mueller/possible-ring-buffer-fix
muellerr added 1 commit 2022-03-28 15:07:58 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
b7a316008a
increase allowed read bytes
muellerr added 1 commit 2022-04-11 17:35:59 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
7a5ce57bbc Merge branch 'development' into mueller/possible-ring-buffer-fix
muellerr added 5 commits 2022-04-25 15:12:01 +02:00
fsfw/fsfw/pipeline/head Build started... Details
fsfw/fsfw/pipeline/pr-development This commit looks good Details
6aa54fe1d4
added missing empty implementation
fsfw/fsfw/pipeline/pr-development This commit looks good Details
7c2e50b665
added related PR in changelog
fsfw/fsfw/pipeline/pr-development This commit looks good Details
b03a6684f9 Merge branch 'development' into mueller/small-stm32-hal-bugifx
muellerr added 1 commit 2022-04-25 15:17:01 +02:00
muellerr added 1 commit 2022-04-27 08:42:28 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
d3e7037759 Merge branch 'development' into mueller/possible-ring-buffer-fix
muellerr commented 2022-04-27 08:43:45 +02:00
Author
Owner
Copy Link

After talk about this PR: There will be an update to this PR where the function will actually cut off the tail of a packet which is too large and write the remaining packet size (maximum ring buffer size) into the ring buffer if overwriteOld is set to true.

After talk about this PR: There will be an update to this PR where the function will actually cut off the tail of a packet which is too large and write the remaining packet size (maximum ring buffer size) into the ring buffer if `overwriteOld` is set to true.
mohr commented 2022-05-06 10:39:27 +02:00
Owner
Copy Link

During implementation of the updated functionality for the overwriteOld flag, it showed that the overwriteOld flag might not be handled correctly in some cases.

Setting this PR to WIP until I figure it out.

During implementation of the updated functionality for the `overwriteOld` flag, it showed that the `overwriteOld` flag might not be handled correctly in some cases. Setting this PR to WIP until I figure it out.
mohr changed title from Possible Ring Buffer Fix to WIP: Possible Ring Buffer Fix 2022-05-06 10:39:36 +02:00
muellerr added 1 commit 2022-05-11 11:34:42 +02:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
e1604b292c Merge branch 'development' into mueller/possible-ring-buffer-fix
muellerr added 1 commit 2022-05-13 11:30:36 +02:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
ff40a71582
Merge remote-tracking branch 'upstream/development' into mueller/possible-ring-buffer-fix
muellerr added 1 commit 2022-05-16 15:13:53 +02:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
d871f55a89
Merge remote-tracking branch 'upstream/development' into mueller/possible-ring-buffer-fix
muellerr added 20 commits 2022-06-21 10:48:06 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
7fee852dbd
re-apply updated auto-formatter
fsfw/fsfw/pipeline/pr-development This commit looks good Details
e1dd27b9dd cache the TCP client address now
fsfw/fsfw/pipeline/pr-development This commit looks good Details
13cda86d23
remove commented code
fsfw/fsfw/pipeline/head This commit looks good Details
d0fc360697
apply afmt
fsfw/fsfw/pipeline/head This commit looks good Details
dac700b80a
static STORE renamed
fsfw/fsfw/pipeline/head This commit looks good Details
8e2597f609
clang-format
fsfw/fsfw/pipeline/head This commit looks good Details
fsfw/fsfw/pipeline/pr-development This commit looks good Details
0b53b4873f
bugfix for srv11
fsfw/fsfw/pipeline/pr-development This commit looks good Details
f288d5120d Merge branch 'development' into mueller/tc-11-tweaks
fsfw/fsfw/pipeline/pr-development This commit looks good Details
34658ef7db
afmt
fsfw/fsfw/pipeline/pr-development This commit looks good Details
e60a665de4
added 3 new subservices
fsfw/fsfw/pipeline/pr-development This commit looks good Details
f7cde80088
added missing delete
fsfw/fsfw/pipeline/head This commit looks good Details
fsfw/fsfw/pipeline/pr-development This commit looks good Details
e59f1f26bf
return end iterator instead of crashing
fsfw/fsfw/pipeline/pr-development This commit looks good Details
7dddcdfd55 Merge branch 'development' into mueller/possible-fix-ccsds-distrib
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
45792e86b9 Merge remote-tracking branch 'upstream/development' into mueller/possible-ring-buffer-fix
muellerr added 1 commit 2022-06-21 10:48:57 +02:00
muellerr added 1 commit 2022-07-18 14:38:06 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
4da18172b3 Merge branch 'development' into mueller/possible-ring-buffer-fix
muellerr changed title from WIP: Possible Ring Buffer Fix to Possible Ring Buffer Fix 2022-07-20 09:26:49 +02:00
muellerr added 1 commit 2022-07-21 13:23:49 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
9bbe1dc716 Merge branch 'development' into mueller/possible-ring-buffer-fix
muellerr merged commit c96e304b68 into development 2022-07-25 10:12:40 +02:00
muellerr deleted branch mueller/possible-ring-buffer-fix 2022-07-25 10:12:42 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
mohr
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v5.0.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#586
No description provided.
Delete Branch "eive/fsfw:mueller/possible-ring-buffer-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?