Possible Ring Buffer Fix #586

Merged

muellerr merged 20 commits from eive/fsfw:mueller/possible-ring-buffer-fix into development 2022-07-25 10:12:40 +02:00

Conversation 3 Commits 20 Files Changed 3 +32 -8

muellerr commented 2022-03-24 16:47:22 +01:00

Owner

Copy Link

Avoid memory leak if passed data is greater than maximum allowed size and overwriteOld iset set to true.

Avoid memory leak if passed data is greater than maximum allowed size and overwriteOld iset set to true.

muellerr added 2 commits 2022-03-24 16:47:29 +01:00

possibly important fix for ring buffer write df97c582d7

ring buffer cfg error warning a891769a02

muellerr requested review from gaisser 2022-03-24 16:47:36 +01:00

muellerr added this to the v5.0.0 milestone 2022-03-24 16:47:43 +01:00

muellerr added the

bug

label 2022-03-24 16:47:48 +01:00

muellerr added 1 commit 2022-03-24 16:51:48 +01:00

add two additional tests for ring buffer 8a44c498c5

muellerr added 1 commit 2022-03-24 20:58:06 +01:00

added nullptr check 879223f38f

muellerr added 1 commit 2022-03-24 21:01:28 +01:00

some more tests fail 23f8e5cb41

gaisser added 1 commit 2022-03-25 15:21:56 +01:00

Fixed Unittests ad57e6713e

gaisser added the

Breaking API Change

label 2022-03-25 15:23:37 +01:00

gaisser added 1 commit 2022-03-25 15:27:34 +01:00

Added changelog 70f575396d

gaisser commented 2022-03-25 15:29:09 +01:00

Owner

Copy Link

Fixed Unittests

Fixed Unittests

gaisser refused to review 2022-03-25 15:30:34 +01:00

gaisser requested review from mohr 2022-03-25 15:30:39 +01:00

gaisser changed title from WIP: Possible Ring Buffer Fix to Possible Ring Buffer Fix 2022-03-25 18:38:06 +01:00

muellerr added 1 commit 2022-03-28 15:03:06 +02:00

Merge remote-tracking branch 'upstream/development' into mueller/possible-ring-buffer-fix f598f7030f

muellerr added 1 commit 2022-03-28 15:07:58 +02:00

increase allowed read bytes b7a316008a

muellerr added 1 commit 2022-04-11 17:35:59 +02:00

Merge branch 'development' into mueller/possible-ring-buffer-fix 7a5ce57bbc

muellerr added 5 commits 2022-04-25 15:12:01 +02:00

added missing empty implementation 6aa54fe1d4

added related PR in changelog 7c2e50b665

Merge branch 'development' into mueller/small-stm32-hal-bugifx b03a6684f9

Merge pull request 'added missing empty implementation in STM32 SPI HAL' (#599) from mueller/small-stm32-hal-bugifx into development ... 5ac88f2b15

Reviewed-on: #599

Merge remote-tracking branch 'upstream/development' into mueller/possible-ring-buffer-fix b7ffd2653b

muellerr added 1 commit 2022-04-25 15:17:01 +02:00

Merge remote-tracking branch 'upstream/development' into mueller/possible-ring-buffer-fix 755dcf66a3

muellerr added 1 commit 2022-04-27 08:42:28 +02:00

Merge branch 'development' into mueller/possible-ring-buffer-fix d3e7037759

muellerr commented 2022-04-27 08:43:45 +02:00

Author

Owner

Copy Link

After talk about this PR: There will be an update to this PR where the function will actually cut off the tail of a packet which is too large and write the remaining packet size (maximum ring buffer size) into the ring buffer if overwriteOld is set to true.

After talk about this PR: There will be an update to this PR where the function will actually cut off the tail of a packet which is too large and write the remaining packet size (maximum ring buffer size) into the ring buffer if `overwriteOld` is set to true.

mohr commented 2022-05-06 10:39:27 +02:00

Owner

Copy Link

During implementation of the updated functionality for the overwriteOld flag, it showed that the overwriteOld flag might not be handled correctly in some cases.

Setting this PR to WIP until I figure it out.

During implementation of the updated functionality for the `overwriteOld` flag, it showed that the `overwriteOld` flag might not be handled correctly in some cases. Setting this PR to WIP until I figure it out.

mohr changed title from Possible Ring Buffer Fix to WIP: Possible Ring Buffer Fix 2022-05-06 10:39:36 +02:00

muellerr added 1 commit 2022-05-11 11:34:42 +02:00

Merge branch 'development' into mueller/possible-ring-buffer-fix e1604b292c

muellerr added 1 commit 2022-05-13 11:30:36 +02:00

Merge remote-tracking branch 'upstream/development' into mueller/possible-ring-buffer-fix ff40a71582

muellerr added 1 commit 2022-05-16 15:13:53 +02:00

Merge remote-tracking branch 'upstream/development' into mueller/possible-ring-buffer-fix d871f55a89

muellerr added 20 commits 2022-06-21 10:48:06 +02:00

minor improvements for auto-formatter 1e7032f89c

re-apply updated auto-formatter 7fee852dbd

cache the TCP client address now e1dd27b9dd

remove commented code 13cda86d23

Merge pull request 'Apply cmake-format and auto-format script on all CMakeLists.txt file' (#628) from eive/fsfw:mueller/apply-clang-format-on-all-files into development ... 576414438c

Reviewed-on: #628

apply afmt d0fc360697

static STORE renamed dac700b80a

clang-format 8e2597f609

bugfix for srv11 0b53b4873f

Merge branch 'development' into mueller/tcp-server-cache-client-addr 5e62258aa6

Merge pull request 'cache the TCP client address now' (#630) from eive/fsfw:mueller/tcp-server-cache-client-addr into development ... 5a425a1c58

Reviewed-on: #630

Merge branch 'development' into mueller/tc-11-tweaks f288d5120d

afmt 34658ef7db

added 3 new subservices e60a665de4

added missing delete f7cde80088

return end iterator instead of crashing e59f1f26bf

Merge pull request 'PUS11 TC sched update and bugfixes' (#632) from mueller/tc-11-tweaks into development ... 261eea381e

Reviewed-on: #632

Merge branch 'development' into mueller/possible-fix-ccsds-distrib 7dddcdfd55

Merge pull request 'return end iterator instead of crashing' (#633) from mueller/possible-fix-ccsds-distrib into development ... c7cf8e710d

Reviewed-on: #633

Merge remote-tracking branch 'upstream/development' into mueller/possible-ring-buffer-fix 45792e86b9

muellerr added 1 commit 2022-06-21 10:48:57 +02:00

Merge remote-tracking branch 'upstream/development' into mueller/possible-ring-buffer-fix 2ebefdffae

muellerr added 1 commit 2022-07-18 14:38:06 +02:00

Merge branch 'development' into mueller/possible-ring-buffer-fix 4da18172b3

muellerr changed title from WIP: Possible Ring Buffer Fix to Possible Ring Buffer Fix 2022-07-20 09:26:49 +02:00

muellerr added 1 commit 2022-07-21 13:23:49 +02:00

Merge branch 'development' into mueller/possible-ring-buffer-fix 9bbe1dc716

muellerr merged commit c96e304b68 into development 2022-07-25 10:12:40 +02:00

muellerr referenced this issue from a commit 2022-07-25 10:12:40 +02:00

Merge pull request 'Possible Ring Buffer Fix' (#586) from eive/fsfw:mueller/possible-ring-buffer-fix into development

muellerr deleted branch mueller/possible-ring-buffer-fix 2022-07-25 10:12:42 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

mohr

Labels

Clear labels

API Change

Changes the API, so Users need to adapted

Breaking API Change

Changes the API in a non backwards compatible way

bug

Something is not working

build

Issues related to the buildsystem, including CI

cosmetics

Small change most users won't notice

Documentation

Improvement of code documentation

duplicate

This issue or pull request already exists

feature

New feature

help wanted

Need some help

hotfix

Quick or important fix that is merged directly into master, causing a new revision

invalid

#worksforme

question

More information is needed

Refactor

Contains a refactoring of some code

Tests

Issues related to testing code

wontfix

This won't be fixed

No Label

Breaking API Change

bug

Milestone

No items

No Milestone v5.0.0

Assignees

Clear assignees

ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#586

No description provided.