Refactor Local Pool API #667

Merged

mohr merged 4 commits from mueller/refactor-local-pool-api into development 2022-09-12 14:32:09 +02:00

Conversation 1 Commits 4 Files Changed 8

+160 -58

muellerr commented 2022-08-30 11:04:18 +02:00

Owner

Copy Link

Copy Source

Builds on top #655 .

Improve the core API of ProvidesDataPoolSubscriptionIF by adding functions which take one wrapper struct. This also makes it more flexible. The old API format was kept to ensure that existing code does not break for this PR but is marked as [[deprecated]]

Migration

Calls like this:

poolManager.subscribeForPeriodicPacket(internalErrorSid, false,
      static_cast<float>(getPeriodicOperationFrequency()) / static_cast<float>(1000.0), true);

look like this now

  poolManager.subscribeForDiagPeriodicPacket({internalErrorSid, false,
      static_cast<float>(getPeriodicOperationFrequency()) / static_cast<float>(1000.0)});

Builds on top https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/655 . Improve the core API of `ProvidesDataPoolSubscriptionIF` by adding functions which take one wrapper struct. This also makes it more flexible. The old API format was kept to ensure that existing code does not break for this PR but is marked as `[[deprecated]]` ## Migration Calls like this: ```cpp poolManager.subscribeForPeriodicPacket(internalErrorSid, false, static_cast<float>(getPeriodicOperationFrequency()) / static_cast<float>(1000.0), true); ``` look like this now ```cpp poolManager.subscribeForDiagPeriodicPacket({internalErrorSid, false, static_cast<float>(getPeriodicOperationFrequency()) / static_cast<float>(1000.0)}); ```

muellerr added 131 commits 2022-08-30 11:04:23 +02:00

refactored space packet interface 0a7f2c6646

add new PUS TC IF 546e173cef

add space packet creator class d7a2eada94

additional ctor for space packet creator 0c5f623780

added basic sp creator test 3c72a42ce1

hmm this is problematic 7e2fdc06cd

update changelog e4d7182d93

Merge remote-tracking branch 'origin/development' into mueller/refactor-tmtc-stack 490a80e49f

apply auto-formatter ddf38b65c3

finished creator unittests 3d2af203f2

start ccsds reader unittests 95b476d4bd

start PUS TC refactoring 5fffbd4a90

a lot of refactoring 6c636661b6

start refactoring PUS TM handling d80941514f

create new TmSendHelper 9860061fc6

switched to new tmtc stack API be35bd53a6

various bugfixes and improvements d8b6cb39ac

some fixes e5ee96259d

delete a few old classes 23f264096c

added sp reader unittests 08e0b0f1a0

fnished PUS TC creator unittests 5af3138e81

delete code which is not used anymore 61bc867bed

minor changes, virtual dtors added 0981ee6f7e

rename namespace affde6bad5

finished basic TC unittests 0dfaba81f9

add empty test files bfee4fd90a

verify successfull TM serialization 67776241de

added some missing implementations 9275ccb79b

APID getter bugfix f28b9ea61b

PUS TM creator tests done cecaec6007

start TM reader unittests 2dfbce6174

completed basic test set b350018cad

completed baseline PUS TM unittests cb05329dd9

add basic CCSDS tests 133894f4ba

Merge branch 'mueller/expand-serialize-if' into mueller/refactor-tmtc-stack c9d37e8d62

some tests 99aaf7068d

Merge branch 'mueller/expand-serialize-if' into mueller/refactor-tmtc-stack 9ccd9fd775

extended serialize if further 55a238d553

Merge branch 'mueller/expand-serialize-if' into mueller/refactor-tmtc-stack fd55de9e95

remove doubly defines b66fd63cb4

Merge branch 'mueller/expand-serialize-if' into mueller/refactor-tmtc-stack f629d60aaf

store helper d474c4a7ee

some renaming f0c8fd2688

replace c include 4921527022

added base for tm store test 63ee88af17

replace some API components with references 832367fb30

fixes for Linux OSAL clock 4989bd0f02

using uint32_t as store_address requires explicit cast 899d021e00

some more ref replacements 973d4ee8a5

more ref replacements e2ad37e3e6

Merge branch 'mueller/expand-serialize-if' into mueller/refactor-tmtc-stack ca1e921b94

finished tm store helper tests 36e3956efb

set up new internal error reporter mock 1a7d7b172b

improving mocks 9ee6da47e9

Merge remote-tracking branch 'origin/development' into mueller/refactor-tmtc-stack 5fd5d488ff

cleaning up message queue mock and subscription API 6d0fa36f8a

normal queue sufficient 935e135f1c

all tests running again a88f767cca

completed send helper tests 586993c081

some more tests using TM send helper c83f75c515

add old api but mark it deprecated 7d87274844

fix memory leak 6d00fc65c0

this should fix the mmeory leak c12669fe50

maybe this teardown fixes the leak db33f9cc7e

more leaks 747243684d

possible double delete e48b6f1432

add new HasReturnvaluesIF features bdf71d4e66

Merge branch 'mueller/expand-retval-if' into mueller/refactor-tmtc-stack 4ed028000d

added additional TM store and send helper 500a5602bd

some more API improvements and replacements f1c37203a4

add new tests 332e9dbfd5

add new VerificationReporterIF 75c824ec80

created PSB mock 146a0e3828

removed some obsolete code f14c812aff

adapt PSB so it can be unittested properly d98b79cf5e

default PUS receiver set automatically now 1954ce0ea4

test auto-initializers 8bf0fb9885

psb unittests almost complete 152c01b2ec

PSB unittests complete 681738dcc6

some printout fixes 9eb652e585

example compiles again 18ee2ab903

some of the deprecation warnings run amok 064b195c75

this gets rid of some warnings 86692e202d

add helper methods to disable crc calculation 059fb10558

updates for PusDistributor 740644f2c8

various bugs and improvements 083d08ae2a

switch off debugging switches c5ad9b5fa9

pass timeReader to Pus ZC writer f591b9793c

send time stampers properly now 234ccdf764

small bugfix 0a38d2e22d

afmt 356d778743

some more minor fixes 4e571e5082

set queue of tm send helper d641d63531

another bugfix in CSB f03b7cd660

remove nullptr check 7e8afcc12f

tests running again 93acac02f5

update serialize IF 85dbef20b0

improvements for creator API 5bb7023ff3

Simple SerializeIF adaptions ... b485afea57

- Returns serialized or deserialized size

add tm zc test 72bc5d4d60

Merge remote-tracking branch 'origin/mueller/expand-retval-if' into mueller/refactor-tmtc-stack fb4ba487b5

some more fixes 30ba9ab916

completed ZcWriter unittests cb118176a0

test no crc generation 1b5fa2a8fa

some more fail tests 8f6f0e1d45

set sec header flag and add unit test for it fc3412fa35

do not use TC info for failed TC retrieval da106fd96f

Merge branch 'development' into mueller/refactor-tmtc-stack 9796abfc7d

Merge remote-tracking branch 'origin/development' into mueller/refactor-tmtc-stack d7ec04bf4b

fix unittests 9e064fe800

merge retval refactoring 1037102349

flip verif reporter ctor arguments 8fd8a37f59

better name for global object 875174c4ad

update changelog 239d053562

important bugfix for verif reporter ff6de8e378

Merge branch 'mueller/refactor-tmtc-stack' into mueller/refactor-tmtc-stack-with-retval-refactoring 2a4ab0af7b

apply auto-formatter dab1b1d067

Merge remote-tracking branch 'origin/development' into mueller/refactor-tmtc-stack-with-retval-refactoring 10f34e5a48

tests running again ba5c6410d6

small changelog update a46d8c34d9

Merge branch 'development' into mueller/refactor-tmtc-stack 6bcb208968

fix for static fw obj setter 3bffb4f968

Merge branch 'mueller/refactor-tmtc-stack' of https://egit.irs.uni-stuttgart.de/fsfw/fsfw into mueller/refactor-tmtc-stack 1bb487373d

remove TODO b499dedd76

default initialization of CDS short struct cb23911ccd

avoid duplicate code 2cab73d972

delete commented function 342a56410c

use old lpm api 92d65aa3a5

afmt 0cc8af5eb0

Merge branch 'mueller/refactor-tmtc-stack' of https://egit.irs.uni-stuttgart.de/fsfw/fsfw into mueller/refactor-tmtc-stack 10fc4dd89d

use cfg struct for local pool API 9fedd03ed8

muellerr added a new dependency 2022-08-30 11:04:32 +02:00

#655 Refactor TMTC Stack, improve test framework

muellerr added 1 commit 2022-08-30 15:01:13 +02:00

make two helper functions protected 9131ca688b

muellerr added 10 commits 2022-09-01 17:51:45 +02:00

better name aea9db75cb

move data wrapper a9277622ce

add new data wrapper helper type 20d42add03

extend data wrapper 0f27c7e7e7

data wrapper update c756297e5c

Merge branch 'mueller/data-wrapper' into mueller/refactor-tmtc-stack 8e6cee7761

Merge remote-tracking branch 'origin/development' into mueller/refactor-tmtc-stack 5c20cc804e

test fix 04bff7a522

Merge remote-tracking branch 'origin/development' into mueller/refactor-local-pool-api 5f8c549993

Merge branch 'mueller/refactor-tmtc-stack' into mueller/refactor-local-pool-api 9202c6c17f

mohr added the Breaking API Change label 2022-09-12 14:18:02 +02:00

mohr added this to the v6.0.0 milestone 2022-09-12 14:18:10 +02:00

mohr approved these changes 2022-09-12 14:18:52 +02:00

mohr referenced this issue from a commit 2022-09-12 14:32:08 +02:00

Merge pull request 'Refactor Local Pool API' (#667) from mueller/refactor-local-pool-api into development

mohr merged commit 9ee1896553 into development 2022-09-12 14:32:09 +02:00

mohr deleted branch mueller/refactor-local-pool-api 2022-09-12 14:32:12 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

mohr

Labels

Clear labels

API Change

Changes the API, so Users need to adapted

Breaking API Change

Changes the API in a non backwards compatible way

bug

Something is not working

build

Issues related to the buildsystem, including CI

cosmetics

Small change most users won't notice

Documentation

Improvement of code documentation

duplicate

This issue or pull request already exists

feature

New feature

help wanted

Need some help

hotfix

Quick or important fix that is merged directly into master, causing a new revision

invalid

#worksforme

question

More information is needed

Refactor

Contains a refactoring of some code

Tests

Issues related to testing code

wontfix

This won't be fixed

No labels Breaking API Change

Milestone

No items

No Milestone v6.0.0

Assignees

Clear assignees

ahinkel (Andy Hinkel) gaisser (Steffen Gaisser) jenkins_buildfix meierj (Jakob Meier) mohr (Ulrich Mohr) mspahr muellerr (Robin Müller) tbaumgartl (Tobias Baumgartl)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Depends on

#655 Refactor TMTC Stack, improve test framework

fsfw/fsfw

Reference: fsfw/fsfw#667