Bugfix for Space Packet Parser #673

muellerr · 2022-09-01T08:55:18+02:00

muellerr commented

2022-09-01 08:55:18 +02:00

The previous implementation was buggy and did not work when several space packets were clumped together, which happens when the packets are sent with a very short delay (0-0.1 seconds). Also, the API structure made it confusing to use. This might even be the reason it did not work, so I improved that. The parser is not used anywhere else.
I would actually prefer an implementation which uses a whole framing layer. I think the current scheme was used because TCP guarantees data delivery, but using something like DLE or COBS might be the cleaner way.

- The previous implementation was buggy and did not work when several space packets were clumped together, which happens when the packets are sent with a very short delay (0-0.1 seconds). Also, the API structure made it confusing to use. This might even be the reason it did not work, so I improved that. The parser is not used anywhere else. - I would actually prefer an implementation which uses a whole framing layer. I think the current scheme was used because TCP guarantees data delivery, but using something like DLE or [COBS](https://en.wikipedia.org/wiki/Consistent_Overhead_Byte_Stuffing) might be the cleaner way.

muellerr added 1 commit 2022-09-01 08:55:19 +02:00

bugfix for SP parser

fsfw/fsfw/pipeline/pr-development This commit looks good

Details

28ecd0e5c6

muellerr changed title from ~~bugfix for SP parser~~ to TODO: bugfix for SP parser

2022-09-01 08:55:41 +02:00

muellerr changed title from ~~TODO: bugfix for SP parser~~ to WIP: bugfix for SP parser

2022-09-01 08:55:57 +02:00

muellerr added this to the v6.0.0 milestone 2022-09-01 08:56:00 +02:00

muellerr added the

bug