fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Refactor TM and TC acceptor interfaces #684

Merged
gaisser merged 7 commits from mueller/refactor-accepts-tc-tm-if into development 2022-10-24 17:10:04 +02:00
Conversation 1 Commits 7 Files Changed 31 +103 -70
muellerr commented 2022-09-14 20:22:11 +02:00
Owner
Copy Link
  • Make the interface functions const where it makes sense
  • New getName function. Is simple and cheap enough and can make debugging a lot easier
  • This is only a breaking change for external AcceptsTelecommandsIF and AcceptsTelemetryIF implementors
- Make the interface functions const where it makes sense - New `getName` function. Is simple and cheap enough and can make debugging a lot easier - This is only a breaking change for external `AcceptsTelecommandsIF` and `AcceptsTelemetryIF` implementors
muellerr added 2 commits 2022-09-14 20:22:13 +02:00
adding files manually 0849c8a08d
all necessary modifications
Some checks are pending
fsfw/fsfw/pipeline/head Build started...
Details
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
237e29cc59
muellerr requested review from mohr 2022-09-14 20:22:18 +02:00
muellerr added this to the v6.0.0 milestone 2022-09-14 20:22:22 +02:00
muellerr added the Breaking API Change label 2022-09-14 20:22:24 +02:00
muellerr requested review from gaisser 2022-09-15 10:22:38 +02:00
muellerr added a new dependency 2022-09-15 10:35:51 +02:00
#682 CFDP Update
muellerr added 1 commit 2022-09-15 10:38:22 +02:00
update changelog
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
1efc0d2855
muellerr added 1 commit 2022-09-15 10:48:22 +02:00
Merge remote-tracking branch 'origin/development' into mueller/refactor-accepts-tc-tm-if
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
8501477a78
muellerr added 1 commit 2022-09-15 11:00:59 +02:00
Merge remote-tracking branch 'origin/development' into mueller/refactor-accepts-tc-tm-if
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
83b7b8707c
gaisser approved these changes 2022-10-10 15:45:00 +02:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
gaisser added 1 commit 2022-10-10 15:45:09 +02:00
Merge branch 'development' into mueller/refactor-accepts-tc-tm-if
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
f3e9277e59
gaisser added 1 commit 2022-10-24 14:57:46 +02:00
Merge branch 'development' into mueller/refactor-accepts-tc-tm-if
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
955579c856
gaisser merged commit 94f1f1f908 into development 2022-10-24 17:10:04 +02:00
gaisser deleted branch mueller/refactor-accepts-tc-tm-if 2022-10-24 17:10:06 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mohr
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 Documentation
Improvement of code documentation
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 wontfix
This won't be fixed
No Label Breaking API Change
Milestone
No items
No Milestone v6.0.0
Assignees
Clear assignees
ahinkel gaisser jenkins_buildfix meierj mohr muellerr tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Blocks
#682 CFDP Update
fsfw/fsfw
Reference: fsfw/fsfw#684
Delete Branch "mueller/refactor-accepts-tc-tm-if"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?