Storage Manager Update #685

Closed
muellerr wants to merge 11 commits from mueller/local-pool-update into development
Owner
  • Move some generic StorageManagerIF implementations from LocalPool to
    interface itself so it can be re-used more easily.
  • This is only a breaking change for external StorageManagerIF implementations
- Move some generic `StorageManagerIF` implementations from `LocalPool` to interface itself so it can be re-used more easily. - This is only a breaking change for external `StorageManagerIF` implementations
muellerr added 2 commits 2022-09-15 10:32:04 +02:00
bump changelog
Some checks are pending
fsfw/fsfw/pipeline/head Build started...
fsfw/fsfw/pipeline/pr-development This commit looks good
b3c0e24611
muellerr added 1 commit 2022-09-15 10:32:19 +02:00
add link to PR
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
e063b44899
muellerr changed title from mueller/local-pool-update to Storage Manager Update 2022-09-15 10:32:25 +02:00
muellerr added the
Breaking API Change
label 2022-09-15 10:32:29 +02:00
muellerr added this to the v6.0.0 milestone 2022-09-15 10:32:31 +02:00
muellerr requested review from mohr 2022-09-15 10:32:38 +02:00
muellerr added a new dependency 2022-09-15 10:35:58 +02:00
muellerr added 1 commit 2022-09-15 10:49:05 +02:00
Merge remote-tracking branch 'origin/development' into mueller/local-pool-update
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
1db77753e3
muellerr added 1 commit 2022-09-15 11:00:25 +02:00
Merge remote-tracking branch 'origin/development' into mueller/local-pool-update
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
4f7f8310c9
mohr requested changes 2022-10-10 15:11:20 +02:00
@ -349,3 +318,27 @@ bool LocalPool::hasDataAtId(store_address_t storeId) const {
}
return false;
}
Owner

Why are these functions overwritten, calling the base class implementation which is already available per inheritance?

Why are these functions overwritten, calling the base class implementation which is already available per inheritance?
Author
Owner

These need to "made available", either by re-exposing the IF calls like this or using
using StorageManagerIF::<functionName> in the header. I think the second way is better, will update the code to do it like that. Not doing any of those two will require the caller code to use a fully scoped function call, e.g. they must write myPool.StorageManagerIF::<functionCall>

These need to "made available", either by re-exposing the IF calls like this or using `using StorageManagerIF::<functionName>` in the header. I think the second way is better, will update the code to do it like that. Not doing any of those two will require the caller code to use a fully scoped function call, e.g. they must write `myPool.StorageManagerIF::<functionCall>`
mohr marked this conversation as resolved
muellerr added 1 commit 2022-10-17 15:08:46 +02:00
this should have the same effect
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
bfe120636c
muellerr added 1 commit 2022-10-24 14:34:59 +02:00
Merge branch 'development' into mueller/local-pool-update
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
dd2f42d22b
gaisser added 1 commit 2022-10-24 14:35:30 +02:00
Merge branch 'development' into mueller/local-pool-update
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
73e313c35b
mohr approved these changes 2022-10-24 14:37:16 +02:00
muellerr added 2 commits 2022-10-24 14:39:06 +02:00
muellerr added 1 commit 2022-10-28 10:03:28 +02:00
Merge remote-tracking branch 'origin/development' into mueller/local-pool-update
Some checks failed
fsfw/fsfw/pipeline/pr-development This commit looks good
fsfw/fsfw/pipeline/head There was a failure building this commit
1eba774c0a
Owner

Merged in #701

Merged in #701
gaisser closed this pull request 2022-11-14 14:52:09 +01:00
gaisser deleted branch mueller/local-pool-update 2022-11-14 14:52:37 +01:00
mohr removed this from the v6.0.0 milestone 2023-02-09 16:07:42 +01:00
mohr added this to the v6.0.0 milestone 2023-02-10 10:56:34 +01:00
mohr removed this from the v6.0.0 milestone 2023-02-10 10:56:52 +01:00
Some checks failed
fsfw/fsfw/pipeline/pr-development This commit looks good
fsfw/fsfw/pipeline/head There was a failure building this commit

Pull request closed

Sign in to join this conversation.
No description provided.