fsfw/fsfw
fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Storage Manager Update #685

Closed
muellerr wants to merge 11 commits from mueller/local-pool-update into development
pull from: mueller/local-pool-update
merge into: fsfw:development
Conversation 3 Commits 11 Files Changed 9 +87 -78
muellerr commented 2022-09-15 10:32:01 +02:00
Owner
Copy Link
  • Move some generic StorageManagerIF implementations from LocalPool to
    interface itself so it can be re-used more easily.
  • This is only a breaking change for external StorageManagerIF implementations
- Move some generic `StorageManagerIF` implementations from `LocalPool` to interface itself so it can be re-used more easily. - This is only a breaking change for external `StorageManagerIF` implementations
muellerr added 2 commits 2022-09-15 10:32:04 +02:00
bump changelog
Some checks are pending
fsfw/fsfw/pipeline/head Build started...
Details
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
b3c0e24611
muellerr added 1 commit 2022-09-15 10:32:19 +02:00
add link to PR
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
e063b44899
muellerr changed title from mueller/local-pool-update to Storage Manager Update 2022-09-15 10:32:25 +02:00
muellerr added the
Breaking API Change
 label 2022-09-15 10:32:29 +02:00
muellerr added this to the v6.0.0 milestone 2022-09-15 10:32:31 +02:00
muellerr requested review from mohr 2022-09-15 10:32:38 +02:00
muellerr added a new dependency 2022-09-15 10:35:58 +02:00
#682 CFDP Update
muellerr added 1 commit 2022-09-15 10:49:05 +02:00
Merge remote-tracking branch 'origin/development' into mueller/local-pool-update
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
1db77753e3
muellerr added 1 commit 2022-09-15 11:00:25 +02:00
Merge remote-tracking branch 'origin/development' into mueller/local-pool-update
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
4f7f8310c9
mohr requested changes 2022-10-10 15:11:20 +02:00
src/fsfw/storagemanager/LocalPool.cpp Outdated
@ -349,3 +318,27 @@ bool LocalPool::hasDataAtId(store_address_t storeId) const {
}
return false;
}
mohr commented 2022-10-10 15:11:18 +02:00
Owner
Copy Link

Why are these functions overwritten, calling the base class implementation which is already available per inheritance?

Why are these functions overwritten, calling the base class implementation which is already available per inheritance?
muellerr commented 2022-10-10 15:17:59 +02:00
Author
Owner
Copy Link

These need to "made available", either by re-exposing the IF calls like this or using
using StorageManagerIF::<functionName> in the header. I think the second way is better, will update the code to do it like that. Not doing any of those two will require the caller code to use a fully scoped function call, e.g. they must write myPool.StorageManagerIF::<functionCall>

These need to "made available", either by re-exposing the IF calls like this or using `using StorageManagerIF::<functionName>` in the header. I think the second way is better, will update the code to do it like that. Not doing any of those two will require the caller code to use a fully scoped function call, e.g. they must write `myPool.StorageManagerIF::<functionCall>`
mohr marked this conversation as resolved
muellerr added 1 commit 2022-10-17 15:08:46 +02:00
this should have the same effect
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
bfe120636c
muellerr added 1 commit 2022-10-24 14:34:59 +02:00
Merge branch 'development' into mueller/local-pool-update
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
dd2f42d22b
gaisser added 1 commit 2022-10-24 14:35:30 +02:00
Merge branch 'development' into mueller/local-pool-update
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
73e313c35b
mohr approved these changes 2022-10-24 14:37:16 +02:00
muellerr added 2 commits 2022-10-24 14:39:06 +02:00
Merge branch 'mueller/local-pool-update' of https://egit.irs.uni-stuttgart.de/fsfw/fsfw into mueller/local-pool-update
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
2df66c9304
muellerr added 1 commit 2022-10-28 10:03:28 +02:00
Merge remote-tracking branch 'origin/development' into mueller/local-pool-update
Some checks failed
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
fsfw/fsfw/pipeline/head There was a failure building this commit
Details
1eba774c0a
gaisser commented 2022-11-14 14:52:07 +01:00
Owner
Copy Link

Merged in #701

Merged in #701
gaisser closed this pull request 2022-11-14 14:52:09 +01:00
gaisser deleted branch mueller/local-pool-update 2022-11-14 14:52:37 +01:00
mohr removed this from the v6.0.0 milestone 2023-02-09 16:07:42 +01:00
mohr added this to the v6.0.0 milestone 2023-02-10 10:56:34 +01:00
mohr removed this from the v6.0.0 milestone 2023-02-10 10:56:52 +01:00
Some checks failed
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
fsfw/fsfw/pipeline/head There was a failure building this commit
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
mohr
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
Breaking API Change
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Blocks
#682 CFDP Update
fsfw/fsfw
Reference: fsfw/fsfw#685
No description provided.
Delete Branch "mueller/local-pool-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?