Storage Manager Update #685

muellerr · 2022-09-15T10:32:01+02:00

muellerr commented

2022-09-15 10:32:01 +02:00

Move some generic StorageManagerIF implementations from LocalPool to
interface itself so it can be re-used more easily.
This is only a breaking change for external StorageManagerIF implementations

- Move some generic `StorageManagerIF` implementations from `LocalPool` to interface itself so it can be re-used more easily. - This is only a breaking change for external `StorageManagerIF` implementations

muellerr added 2 commits 2022-09-15 10:32:04 +02:00

ab7c3480f5

storage manager update

fsfw/fsfw/pipeline/head Build started... Details

fsfw/fsfw/pipeline/pr-development This commit looks good Details

b3c0e24611

bump changelog

muellerr added 1 commit 2022-09-15 10:32:19 +02:00

fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details

e063b44899

add link to PR

muellerr changed title from ~~mueller/local-pool-update~~ to Storage Manager Update

2022-09-15 10:32:25 +02:00

muellerr added the

Breaking API Change

label 2022-09-15 10:32:29 +02:00

muellerr added this to the v6.0.0 milestone 2022-09-15 10:32:31 +02:00

muellerr requested review from mohr 2022-09-15 10:32:38 +02:00

muellerr added a new dependency 2022-09-15 10:35:58 +02:00

#682 CFDP Update

muellerr added 1 commit 2022-09-15 10:49:05 +02:00

fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details

1db77753e3

Merge remote-tracking branch 'origin/development' into mueller/local-pool-update

muellerr added 1 commit 2022-09-15 11:00:25 +02:00

fsfw/fsfw/pipeline/pr-development This commit looks good Details

4f7f8310c9

Merge remote-tracking branch 'origin/development' into mueller/local-pool-update

mohr requested changes 2022-10-10 15:11:20 +02:00

src/fsfw/storagemanager/LocalPool.cpp Outdated

													
				@ -349,3 +318,27 @@ bool LocalPool::hasDataAtId(store_address_t storeId) const {

				  }

				  return false;

				}

mohr commented

2022-10-10 15:11:18 +02:00

Why are these functions overwritten, calling the base class implementation which is already available per inheritance?

muellerr commented

2022-10-10 15:17:59 +02:00

These need to "made available", either by re-exposing the IF calls like this or using
using StorageManagerIF::<functionName> in the header. I think the second way is better, will update the code to do it like that. Not doing any of those two will require the caller code to use a fully scoped function call, e.g. they must write myPool.StorageManagerIF::<functionCall>

These need to "made available", either by re-exposing the IF calls like this or using `using StorageManagerIF::<functionName>` in the header. I think the second way is better, will update the code to do it like that. Not doing any of those two will require the caller code to use a fully scoped function call, e.g. they must write `myPool.StorageManagerIF::<functionCall>`

mohr marked this conversation as resolved

muellerr added 1 commit 2022-10-17 15:08:46 +02:00