Storage Manager Update #685
No reviewers
Labels
No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Blocks
#682 CFDP Update
fsfw/fsfw
Reference: fsfw/fsfw#685
Loading…
Reference in New Issue
No description provided.
Delete Branch "mueller/local-pool-update"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
StorageManagerIF
implementations fromLocalPool
tointerface itself so it can be re-used more easily.
StorageManagerIF
implementationsmueller/local-pool-updateto Storage Manager Update@ -349,3 +318,27 @@ bool LocalPool::hasDataAtId(store_address_t storeId) const {
}
return false;
}
Why are these functions overwritten, calling the base class implementation which is already available per inheritance?
These need to "made available", either by re-exposing the IF calls like this or using
using StorageManagerIF::<functionName>
in the header. I think the second way is better, will update the code to do it like that. Not doing any of those two will require the caller code to use a fully scoped function call, e.g. they must writemyPool.StorageManagerIF::<functionCall>
Merged in #701
Pull request closed