fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Minor API tweak #689

Merged
gaisser merged 8 commits from eive/fsfw:mueller/smaller-tweaks into development 2022-10-10 15:10:59 +02:00
Conversation 1 Commits 8 Files Changed 4 +21 -11
muellerr commented 2022-09-16 18:22:31 +02:00
Owner
Copy Link
  • Remove default secondary header argument for uint16_t getTcSpacePacketIdFromApid(uint16_t apid, bool secondaryHeaderFlag) and uint16_t getTmSpacePacketIdFromApid(uint16_t apid, bool secondaryHeaderFlag). That was 10 minutes of annoying debugging too much
  • tweak some returnvalue IDs to avoid duplicate value
- Remove default secondary header argument for `uint16_t getTcSpacePacketIdFromApid(uint16_t apid, bool secondaryHeaderFlag)` and `uint16_t getTmSpacePacketIdFromApid(uint16_t apid, bool secondaryHeaderFlag)`. That was 10 minutes of annoying debugging too much - tweak some returnvalue IDs to avoid duplicate value
muellerr added 1 commit 2022-09-16 18:22:34 +02:00
fixes and tweaks b4b11ebd3b
muellerr added 1 commit 2022-09-16 18:24:04 +02:00
update changelog
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
72172a972b
muellerr changed title from fixes and tweaks to Minor API tweak 2022-09-16 18:25:05 +02:00
muellerr added the
Breaking API Change
 label 2022-09-16 18:25:10 +02:00
muellerr added 1 commit 2022-09-16 18:37:42 +02:00
Merge branch 'development' into mueller/smaller-tweaks
Some checks are pending
fsfw/fsfw/pipeline/pr-development Build queued...
Details
558550ecb9
muellerr added 1 commit 2022-09-26 14:15:13 +02:00
add some tests
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
c54d9d7ba6
gaisser approved these changes 2022-09-26 14:34:35 +02:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
gaisser added 1 commit 2022-09-26 14:34:43 +02:00
Merge branch 'development' into mueller/smaller-tweaks
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
bd64591f30
gaisser added 1 commit 2022-09-26 14:40:34 +02:00
Merge branch 'development' into mueller/smaller-tweaks
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
95ac53c417
muellerr added this to the v6.0.0 milestone 2022-09-28 10:01:55 +02:00
muellerr added 1 commit 2022-10-10 13:41:54 +02:00
Merge branch 'development' into mueller/smaller-tweaks
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
6b991045f7
gaisser added 1 commit 2022-10-10 15:03:08 +02:00
Merge branch 'development' into mueller/smaller-tweaks
Some checks are pending
fsfw/fsfw/pipeline/pr-development Build started...
Details
518dcdef4b
gaisser merged commit d592f1ecbc into development 2022-10-10 15:10:58 +02:00
gaisser deleted branch mueller/smaller-tweaks 2022-10-10 15:11:01 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
Breaking API Change
Milestone
No items
No Milestone v6.0.0
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#689
No description provided.
Delete Branch "eive/fsfw:mueller/smaller-tweaks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?