diff --git a/src/fsfw/objectmanager/ObjectManager.cpp b/src/fsfw/objectmanager/ObjectManager.cpp index ddf5ab802..4afab2968 100644 --- a/src/fsfw/objectmanager/ObjectManager.cpp +++ b/src/fsfw/objectmanager/ObjectManager.cpp @@ -16,11 +16,6 @@ ObjectManager* ObjectManager::instance() { return objManagerInstance; } -void ObjectManager::setObjectFactoryFunction(produce_function_t objFactoryFunc, void* factoryArgs) { - this->objectFactoryFunction = objFactoryFunc; - this->factoryArgs = factoryArgs; -} - ObjectManager::ObjectManager() = default; ObjectManager::~ObjectManager() { @@ -79,17 +74,6 @@ SystemObjectIF* ObjectManager::getSystemObject(object_id_t id) { } void ObjectManager::initialize() { - if (objectFactoryFunction == nullptr) { -#if FSFW_CPP_OSTREAM_ENABLED == 1 - sif::error << "ObjectManager::initialize: Passed produceObjects " - "functions is nullptr!" - << std::endl; -#else - sif::printError("ObjectManager::initialize: Passed produceObjects functions is nullptr!\n"); -#endif - return; - } - objectFactoryFunction(factoryArgs); ReturnValue_t result = returnvalue::FAILED; uint32_t errorCount = 0; for (auto const& it : objectList) { diff --git a/src/fsfw/objectmanager/ObjectManager.h b/src/fsfw/objectmanager/ObjectManager.h index e0e747924..0ef9cae1e 100644 --- a/src/fsfw/objectmanager/ObjectManager.h +++ b/src/fsfw/objectmanager/ObjectManager.h @@ -21,7 +21,6 @@ */ class ObjectManager : public ObjectManagerIF { public: - using produce_function_t = void (*)(void* args); /** * Returns the single instance of TaskFactory. @@ -30,8 +29,6 @@ class ObjectManager : public ObjectManagerIF { */ static ObjectManager* instance(); - void setObjectFactoryFunction(produce_function_t prodFunc, void* args); - template T* get(object_id_t id); @@ -54,8 +51,6 @@ class ObjectManager : public ObjectManagerIF { * @param The id of the object to be created. * @return Returns a pointer to the newly created object or NULL. */ - produce_function_t objectFactoryFunction = nullptr; - void* factoryArgs = nullptr; private: ObjectManager(); diff --git a/src/fsfw_tests/integration/devices/TestDeviceHandler.cpp b/src/fsfw_tests/integration/devices/TestDeviceHandler.cpp index 01f0494b8..fdf02a707 100644 --- a/src/fsfw_tests/integration/devices/TestDeviceHandler.cpp +++ b/src/fsfw_tests/integration/devices/TestDeviceHandler.cpp @@ -646,7 +646,7 @@ ReturnValue_t TestDevice::initializeLocalDataPool(localpool::DataPool& localData /* Subscribe for periodic HK packets but do not enable reporting for now. Non-diangostic with a period of one second */ poolManager.subscribeForRegularPeriodicPacket({sid, false, 1.0}); - return HasReturnvaluesIF::RETURN_OK; + return returnvalue::OK; } ReturnValue_t TestDevice::getParameter(uint8_t domainId, uint8_t uniqueId, diff --git a/unittests/CatchSetup.cpp b/unittests/CatchSetup.cpp index 9206c2e18..aa4cdcbab 100644 --- a/unittests/CatchSetup.cpp +++ b/unittests/CatchSetup.cpp @@ -25,7 +25,7 @@ ServiceInterfaceStream warning("WARNING"); int customSetup() { // global setup ObjectManager* objMan = ObjectManager::instance(); - objMan->setObjectFactoryFunction(Factory::produceFrameworkObjects, nullptr); + Factory::produceFrameworkObjects(nullptr); objMan->initialize(); return 0; }