fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

I2C Linux: remove duplicate printout #718

Merged
gaisser merged 1 commits from eive/fsfw:i2c_remove_duplicate_printout into development 2023-02-06 14:54:59 +01:00
Conversation 0 Commits 1 Files Changed 1 -4
muellerr commented 2023-01-11 08:50:13 +01:00
Owner
Copy Link
No description provided.
muellerr added 1 commit 2023-01-11 08:50:17 +01:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
7adb47aecb remove duplicate printout
muellerr added this to the v6.0.0 milestone 2023-01-11 08:50:26 +01:00
muellerr changed title from remove duplicate printout to I2C Linux: remove duplicate printout 2023-01-13 11:12:55 +01:00
gaisser requested changes 2023-01-13 11:40:23 +01:00
gaisser left a comment
Owner
Copy Link

The change itself LGTM. There is one older line above.

The change itself LGTM. There is one older line above.
src/fsfw_hal/linux/i2c/I2cComIF.cpp
@ -180,10 +180,6 @@ ReturnValue_t I2cComIF::requestReceiveMessage(CookieIF* cookie, size_t requestLe
}
#else
gaisser commented 2023-01-13 11:39:36 +01:00
Owner
Copy Link

Is this #else needed?

Is this #else needed?
muellerr commented 2023-01-13 13:33:03 +01:00
Author
Owner
Copy Link

printf support could be added there theoretically..

printf support could be added there theoretically..
gaisser marked this conversation as resolved
gaisser approved these changes 2023-02-06 14:54:53 +01:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
gaisser merged commit 7b828f233a into development 2023-02-06 14:54:59 +01:00
gaisser deleted branch i2c_remove_duplicate_printout 2023-02-06 14:55:00 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v6.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#718
No description provided.
Delete Branch "eive/fsfw:i2c_remove_duplicate_printout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?