Possible TC scheduler bugfix
#738
Closed
muellerr
wants to merge 3 commits from eive/fsfw:possible_tc_sched_fixes
into development
pull from: eive/fsfw:possible_tc_sched_fixes
merge into: fsfw:development
fsfw:development
fsfw:mohr/timetag_fix
fsfw:master
fsfw:mohr/relsease_helper
fsfw:mohr/warnings
fsfw:mohr/windows
fsfw:mohr/rtems
fsfw:mohr/freeRTOS
fsfw:mueller/new-cfdp-update-with-handlers
fsfw:mohr/dhb2normal
fsfw:mueller/obj-man-remove-weird-proc-func
fsfw:mohr/documentation_ci
fsfw:mohr_introspection
fsfw:mueller/fsfw-from-zero
fsfw:mueller/data-wrapper
fsfw:mueller/dhb-handle-device-tm
fsfw:mueller/refactor-tmtc-stack-with-retval-refactoring
fsfw:mueller/refactor-logging-with-fmt
fsfw:meier/upstream-pus-distributor-bugfix
fsfw:mueller/clang-improvements
Reviewers
Request review
No reviewers
Labels
Changes the API, so Users need to adapted Breaking API Change
Changes the API in a non backwards compatible way bug
Something is not working build
Issues related to the buildsystem, including CI cosmetics
Small change most users won't notice Documentation
Improvement of code documentation duplicate
This issue or pull request already exists feature
New feature help wanted
Need some help hotfix
Quick or important fix that is merged directly into master, causing a new revision invalid
#worksforme question
More information is needed Refactor
Contains a refactoring of some code Tests
Issues related to testing code wontfix
This won't be fixed
Apply labels
Clear labels
API Change
Changes the API, so Users need to adapted Breaking API Change
Changes the API in a non backwards compatible way bug
Something is not working build
Issues related to the buildsystem, including CI cosmetics
Small change most users won't notice Documentation
Improvement of code documentation duplicate
This issue or pull request already exists feature
New feature help wanted
Need some help hotfix
Quick or important fix that is merged directly into master, causing a new revision invalid
#worksforme question
More information is needed Refactor
Contains a refactoring of some code Tests
Issues related to testing code wontfix
This won't be fixed
No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: fsfw/fsfw#738
Reference in new issue
There is no content yet.
Delete Branch 'eive/fsfw:possible_tc_sched_fixes'
Deleting a branch is permanent. It CANNOT be undone. Continue?
No
Yes
I really think that logic is broken.
Possible TC schedulerto Possible TC scheduler bugfix 4 months agoThis is included in #735 so maybe not necessary.
As far as the logic goes, it is intended behavior that commands that are scheduled too close in the future are rejected.
This is an operational requirement as one should not upload scheduled TCs so close to execution time.
Thinking about it, I am not sure if it really belongs into the flight software, but I think the operational impact is minimal and would keep it to be backward compatible.
Also, agree on #735 fixing the integer underflow (unintentionally. While I recognized that line as suboptimal I actually did not realize the underflow).
Solved by #735
Reviewers