Possible TC scheduler bugfix #738

Closed
muellerr wants to merge 3 commits from eive/fsfw:possible_tc_sched_fixes into development
Owner

I really think that logic is broken.

I really think that logic is broken.
muellerr added 2 commits 4 months ago
muellerr changed title from Possible TC scheduler to Possible TC scheduler bugfix 4 months ago
muellerr added this to the v6.0.0 milestone 4 months ago
muellerr added the bug label 4 months ago
muellerr added 1 commit 4 months ago
fsfw/fsfw/pipeline/pr-development This commit looks good Details
341a66c265
changelog
muellerr requested review from gaisser 4 months ago
muellerr requested review from mohr 4 months ago
muellerr removed review request for gaisser 4 months ago
Poster
Owner

This is included in #735 so maybe not necessary.

This is included in https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/735 so maybe not necessary.
mohr commented 4 months ago
Owner

As far as the logic goes, it is intended behavior that commands that are scheduled too close in the future are rejected.
This is an operational requirement as one should not upload scheduled TCs so close to execution time.

Thinking about it, I am not sure if it really belongs into the flight software, but I think the operational impact is minimal and would keep it to be backward compatible.

Also, agree on #735 fixing the integer underflow (unintentionally. While I recognized that line as suboptimal I actually did not realize the underflow).

As far as the logic goes, it is intended behavior that commands that are scheduled too close in the future are rejected. This is an operational requirement as one should not upload scheduled TCs so close to execution time. Thinking about it, I am not sure if it really belongs into the flight software, but I think the operational impact is minimal and would keep it to be backward compatible. Also, agree on #735 fixing the integer underflow (unintentionally. While I recognized that line as suboptimal I actually did not realize the underflow).
Owner

Solved by #735

Solved by #735
gaisser closed this pull request 3 months ago
mohr removed this from the v6.0.0 milestone 3 months ago

Reviewers

mohr was requested for review 4 months ago
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Loading…
There is no content yet.