fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

Possible TC scheduler bugfix #738

Closed
muellerr wants to merge 3 commits from eive/fsfw:possible_tc_sched_fixes into development
pull from: eive/fsfw:possible_tc_sched_fixes
merge into: fsfw:development
Conversation 3 Commits 3 Files Changed 2 +4 -1
muellerr commented 2023-02-09 18:20:42 +01:00
Owner
Copy Link

I really think that logic is broken.

I really think that logic is broken.
muellerr added 2 commits 2023-02-09 18:20:45 +01:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
b9b076aa4c logic error
muellerr changed title from Possible TC scheduler to Possible TC scheduler bugfix 2023-02-09 18:20:51 +01:00
muellerr added this to the v6.0.0 milestone 2023-02-09 18:21:01 +01:00
muellerr added the
bug
 label 2023-02-09 18:21:05 +01:00
muellerr added 1 commit 2023-02-09 18:22:05 +01:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
341a66c265
changelog
muellerr requested review from gaisser 2023-02-09 18:26:11 +01:00
muellerr requested review from mohr 2023-02-09 18:26:17 +01:00
muellerr removed review request for gaisser 2023-02-09 18:26:18 +01:00
muellerr commented 2023-02-10 13:54:08 +01:00
Author
Owner
Copy Link

This is included in #735 so maybe not necessary.

This is included in https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/735 so maybe not necessary.
mohr commented 2023-02-10 21:03:00 +01:00
Owner
Copy Link

As far as the logic goes, it is intended behavior that commands that are scheduled too close in the future are rejected.
This is an operational requirement as one should not upload scheduled TCs so close to execution time.

Thinking about it, I am not sure if it really belongs into the flight software, but I think the operational impact is minimal and would keep it to be backward compatible.

Also, agree on #735 fixing the integer underflow (unintentionally. While I recognized that line as suboptimal I actually did not realize the underflow).

As far as the logic goes, it is intended behavior that commands that are scheduled too close in the future are rejected. This is an operational requirement as one should not upload scheduled TCs so close to execution time. Thinking about it, I am not sure if it really belongs into the flight software, but I think the operational impact is minimal and would keep it to be backward compatible. Also, agree on #735 fixing the integer underflow (unintentionally. While I recognized that line as suboptimal I actually did not realize the underflow).
gaisser commented 2023-02-20 14:27:11 +01:00
Owner
Copy Link

Solved by #735

Solved by #735
gaisser closed this pull request 2023-02-20 14:27:11 +01:00
mohr removed this from the v6.0.0 milestone 2023-02-23 13:26:13 +01:00
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
mohr
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#738
No description provided.
Delete Branch "eive/fsfw:possible_tc_sched_fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?