From 7f80e91a9128854e250012dc1c80ddd60ad2c161 Mon Sep 17 00:00:00 2001
From: Ulrich Mohr <mohr@irs.uni-stuttgart.de>
Date: Mon, 24 Jul 2023 16:01:55 +0200
Subject: [PATCH] removed HasModesIF::getModeDefinitionHelper(), do not think
 this will last

---
 src/fsfw/devicehandlers/DeviceHandlerBase.cpp | 4 ----
 src/fsfw/devicehandlers/DeviceHandlerBase.h   | 1 -
 src/fsfw/modes/HasModesIF.h                   | 2 +-
 3 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/fsfw/devicehandlers/DeviceHandlerBase.cpp b/src/fsfw/devicehandlers/DeviceHandlerBase.cpp
index d001fc948..69f04634e 100644
--- a/src/fsfw/devicehandlers/DeviceHandlerBase.cpp
+++ b/src/fsfw/devicehandlers/DeviceHandlerBase.cpp
@@ -1541,7 +1541,3 @@ MessageQueueId_t DeviceHandlerBase::getCommanderQueueId(DeviceCommandId_t replyI
 }
 
 ModeHelper const* DeviceHandlerBase::getModeHelper() const { return &modeHelper; }
-
-ModeDefinitionHelper DeviceHandlerBase::getModeDefinitionHelper() {
-  return ModeDefinitionHelper::create<DeviceHandlerMode, DefaultSubmode>();
-}
\ No newline at end of file
diff --git a/src/fsfw/devicehandlers/DeviceHandlerBase.h b/src/fsfw/devicehandlers/DeviceHandlerBase.h
index 521d41c2a..2d8e9e3ac 100644
--- a/src/fsfw/devicehandlers/DeviceHandlerBase.h
+++ b/src/fsfw/devicehandlers/DeviceHandlerBase.h
@@ -204,7 +204,6 @@ class DeviceHandlerBase : public DeviceHandlerIF,
   Submode_t getTransitionSourceSubMode() const;
   void getMode(Mode_t *mode, Submode_t *submode) override;
   ModeHelper const *getModeHelper() const override;
-  ModeDefinitionHelper getModeDefinitionHelper() override;
   HealthState getHealth();
   ReturnValue_t setHealth(HealthState health);
   virtual ReturnValue_t getParameter(uint8_t domainId, uint8_t uniqueId,
diff --git a/src/fsfw/modes/HasModesIF.h b/src/fsfw/modes/HasModesIF.h
index 65dc21484..7aeee24f7 100644
--- a/src/fsfw/modes/HasModesIF.h
+++ b/src/fsfw/modes/HasModesIF.h
@@ -53,7 +53,7 @@ class HasModesIF {
   virtual ~HasModesIF() {}
   virtual MessageQueueId_t getCommandQueue() const = 0;
   virtual const ModeHelper * getModeHelper() const = 0;
-  virtual ModeDefinitionHelper getModeDefinitionHelper() = 0;
+  //virtual ModeDefinitionHelper getModeDefinitionHelper() = 0; //TODO do not think this is a good idea
   virtual void getMode(Mode_t *mode, Submode_t *submode) = 0;
 
  protected: