mohr/nexosim
1
0
Fork 0
forked from ROMEO/nexosim
Code Pull Requests Activity

Merge pull request #9 from asynchronics/fix/ci-failures

Browse Source 
Fix comments
This commit is contained in:
Serge Barral 2024-05-07 12:49:57 +02:00 committed by GitHub
commit 287b3b713c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
asynchronix/src/executor/task.rs
View File

@ -287,12 +287,12 @@ where
/// `Waker::will_wake` as the latter tests the pointers to the virtual tables /// `Waker::will_wake` as the latter tests the pointers to the virtual tables
/// for equality. /// for equality.
/// ///
/// Forcing the function to be inlined appears to solve this problem, but we may /// Preventing the function from being inlined appears to solve this problem,
/// want to investigate more robust methods. Tokio has [switched][1] to a single /// but we may want to investigate more robust methods. For unrelated reasons,
/// non-generic virtual table declared as `static`, which then delegates each /// Tokio has switched [1] to a single non-generic virtual table declared as
/// call with another virtual call. This does ensure that `Waker::will_wake` /// `static` which then delegates each call to another virtual call. This does
/// will always work, but the double indirection is a bit unfortunate and its /// ensure that `Waker::will_wake` will always work, but the double indirection
/// cost would need to be evaluated. /// is a bit unfortunate and its cost would need to be evaluated.
/// ///
/// [1]: https://github.com/tokio-rs/tokio/pull/5213 /// [1]: https://github.com/tokio-rs/tokio/pull/5213
#[inline(never)] #[inline(never)]