rust/ops-sat-rs
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

downlink_logfile #21

Merged
lkoester merged 6 commits from downlink_logfile into main 2024-04-25 17:49:19 +02:00
Conversation 1 Commits 6 Files Changed 8 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f8f3bc73ac - Show all commits

4
src/main.rs
View File

@ -55,11 +55,11 @@ mod tmtc;
fn main() {
setup_logger().expect("setting up logging with fern failed");
let version_str = VERSION.unwrap_or("?");
debug!("OPS-SAT Rust Experiment OBSW v{}", version_str);
println!("OPS-SAT Rust Experiment OBSW v{}", version_str);
lkoester marked this conversation as resolved Outdated
muellerr commented 2024-04-25 17:08:46 +02:00
Outdated
Review
Copy Link

I'd leave this a println. There are corner cases where logger output ca nbe invisible, and I always want to see this line at the very least.

I'd leave this a println. There are corner cases where logger output ca nbe invisible, and I always want to see this line at the very least.
create_low_priority_ground_dir();
let app_cfg = create_app_config();
debug!("App Configuration: {:?}", app_cfg);
info!("App Configuration: {:?}", app_cfg);
lkoester marked this conversation as resolved Outdated
muellerr commented 2024-04-25 17:09:13 +02:00
Outdated
Review
Copy Link

I'd transform this to INFO. debug is usually not visible, and this is valuable information, as long as it's not too noisy.

I'd transform this to INFO. debug is usually not visible, and this is valuable information, as long as it's not too noisy.
let stop_signal = Arc::new(AtomicBool::new(false));