From 6dcb9d719c04f2fbddbe2af27caf8a255c156205 Mon Sep 17 00:00:00 2001
From: Robin Mueller <robin.mueller.m@gmail.com>
Date: Sun, 14 Aug 2022 11:13:54 +0200
Subject: [PATCH] some improvements

---
 fsrc-core/src/any.rs              |  4 +--
 fsrc-core/src/tmtc/pus_distrib.rs | 60 +++++++++++++++----------------
 2 files changed, 32 insertions(+), 32 deletions(-)

diff --git a/fsrc-core/src/any.rs b/fsrc-core/src/any.rs
index ea65d65..b762bfb 100644
--- a/fsrc-core/src/any.rs
+++ b/fsrc-core/src/any.rs
@@ -1,8 +1,8 @@
 use std::any::Any;
 
+/// This trait encapsulates being able to cast a trait object to its original concrete type
+/// TODO: Add example code and maybe write derive macro because this code is always the same
 pub trait AsAny {
-    // I am not 100 % sure this is the best idea, but it allows downcasting the trait object
-    // to its original concrete type.
     fn as_any(&self) -> &dyn Any;
     fn as_mut_any(&mut self) -> &mut dyn Any;
 }
diff --git a/fsrc-core/src/tmtc/pus_distrib.rs b/fsrc-core/src/tmtc/pus_distrib.rs
index 9f63f93..59856f5 100644
--- a/fsrc-core/src/tmtc/pus_distrib.rs
+++ b/fsrc-core/src/tmtc/pus_distrib.rs
@@ -17,8 +17,14 @@ pub struct PusDistributor {
 impl ReceivesTc for PusDistributor {
     fn pass_tc(&mut self, tm_raw: &[u8]) {
         // Convert to ccsds and call pass_ccsds
-        let sp_header = SpHeader::from_raw_slice(tm_raw).unwrap();
-        self.pass_ccsds(&sp_header, tm_raw).unwrap();
+        match SpHeader::from_raw_slice(tm_raw) {
+            Ok(sp_header) => {
+                self.pass_ccsds(&sp_header, tm_raw).unwrap();
+            }
+            Err(error) => {
+                // TODO: Error handling
+            }
+        }
     }
 }
 
@@ -126,21 +132,27 @@ mod tests {
         }
     }
 
+    macro_rules! apid_handler_impl {
+        () => {
+            fn valid_apids(&self) -> &'static [u16] {
+                &[0x000, 0x002]
+            }
+
+            fn handle_known_apid(&mut self, sp_header: &SpHeader, tc_raw: &[u8]) {
+                self.handler_base.handle_known_apid(&sp_header, tc_raw);
+                self.pus_distrib
+                    .pass_ccsds(&sp_header, tc_raw)
+                    .expect("Passing PUS packet failed");
+            }
+
+            fn handle_unknown_apid(&mut self, sp_header: &SpHeader, tc_raw: &[u8]) {
+                self.handler_base.handle_unknown_apid(&sp_header, tc_raw);
+            }
+        };
+    }
+
     impl ApidPacketHandler for ApidHandlerShared {
-        fn valid_apids(&self) -> &'static [u16] {
-            &[0x000, 0x002]
-        }
-
-        fn handle_known_apid(&mut self, sp_header: &SpHeader, tc_raw: &[u8]) {
-            self.handler_base.handle_known_apid(&sp_header, tc_raw);
-            self.pus_distrib
-                .pass_ccsds(&sp_header, tc_raw)
-                .expect("Passing PUS packet failed");
-        }
-
-        fn handle_unknown_apid(&mut self, sp_header: &SpHeader, tc_raw: &[u8]) {
-            self.handler_base.handle_unknown_apid(&sp_header, tc_raw);
-        }
+        apid_handler_impl!();
     }
 
     struct ApidHandlerOwned {
@@ -159,21 +171,9 @@ mod tests {
     }
 
     impl ApidPacketHandler for ApidHandlerOwned {
-        fn valid_apids(&self) -> &'static [u16] {
-            &[0x000, 0x002]
-        }
-
-        fn handle_known_apid(&mut self, sp_header: &SpHeader, tc_raw: &[u8]) {
-            self.handler_base.handle_known_apid(&sp_header, tc_raw);
-            self.pus_distrib
-                .pass_ccsds(&sp_header, tc_raw)
-                .expect("Passing PUS packet failed");
-        }
-
-        fn handle_unknown_apid(&mut self, sp_header: &SpHeader, tc_raw: &[u8]) {
-            self.handler_base.handle_unknown_apid(&sp_header, tc_raw);
-        }
+        apid_handler_impl!();
     }
+
     #[test]
     fn test_pus_distribution() {
         let known_packet_queue = Arc::new(Mutex::default());