From 9b63ea3585630326ce3befc6c49f70d0ec1ea7f2 Mon Sep 17 00:00:00 2001 From: Robin Mueller Date: Sun, 14 May 2023 16:03:41 +0200 Subject: [PATCH 1/3] small clippy fix --- satrs-core/src/pool.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/satrs-core/src/pool.rs b/satrs-core/src/pool.rs index 3e276bf..965bd6a 100644 --- a/satrs-core/src/pool.rs +++ b/satrs-core/src/pool.rs @@ -263,7 +263,7 @@ pub trait PoolProvider { if !self.has_element_at(addr)? { return Err(StoreError::DataDoesNotExist(*addr)); } - return Ok(self.read(addr)?.len()); + Ok(self.read(addr)?.len()) } } -- 2.43.0 From 541311d15db3c38defb3c362d145abe76754237c Mon Sep 17 00:00:00 2001 From: Robin Mueller Date: Sun, 14 May 2023 16:08:12 +0200 Subject: [PATCH 2/3] more clippy fixes --- satrs-core/src/pus/verification.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/satrs-core/src/pus/verification.rs b/satrs-core/src/pus/verification.rs index 8f80954..7dfe984 100644 --- a/satrs-core/src/pus/verification.rs +++ b/satrs-core/src/pus/verification.rs @@ -479,6 +479,8 @@ impl VerificationReporterCore { )) } + // Not public, too many arguments is acceptable for this case. + #[allow(clippy::too_many_arguments)] fn sendable_failure_no_step<'src_data, State: Copy>( &mut self, src_data_buf: &'src_data mut [u8], @@ -824,6 +826,8 @@ impl VerificationReporterCore { Ok(()) } + // Internal helper function, too many arguments is acceptable for this case. + #[allow(clippy::too_many_arguments)] fn create_pus_verif_success_tm<'src_data>( &mut self, src_data_buf: &'src_data mut [u8], @@ -858,6 +862,8 @@ impl VerificationReporterCore { )) } + // Internal helper function, too many arguments is acceptable for this case. + #[allow(clippy::too_many_arguments)] fn create_pus_verif_fail_tm<'src_data>( &mut self, src_data_buf: &'src_data mut [u8], -- 2.43.0 From 993c5546e416d0cbed16ef1661430f0f03184084 Mon Sep 17 00:00:00 2001 From: Robin Mueller Date: Sun, 14 May 2023 16:09:09 +0200 Subject: [PATCH 3/3] doc correction --- satrs-core/src/pus/verification.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/satrs-core/src/pus/verification.rs b/satrs-core/src/pus/verification.rs index 7dfe984..b60bc3f 100644 --- a/satrs-core/src/pus/verification.rs +++ b/satrs-core/src/pus/verification.rs @@ -479,7 +479,7 @@ impl VerificationReporterCore { )) } - // Not public, too many arguments is acceptable for this case. + // Internal helper function, too many arguments is acceptable for this case. #[allow(clippy::too_many_arguments)] fn sendable_failure_no_step<'src_data, State: Copy>( &mut self, -- 2.43.0