Merge pull request 'fix formatting' (#42) from auto-formatting into main

Reviewed-on: #42

src/fsfw/cfdp/tlv/FilestoreTlvBase.h

@@ -66,9 +66,9 @@ static constexpr uint8_t FSR_DENY_DIR_NOT_ALLOWED = 0b0010;
 
 class FilestoreTlvBase : public TlvIF {
  public:
-  explicit FilestoreTlvBase(cfdp::StringLv& firstFileName) : firstFileName(firstFileName){};
+  explicit FilestoreTlvBase(cfdp::StringLv& firstFileName) : firstFileName(firstFileName) {};
   FilestoreTlvBase(FilestoreActionCode actionCode, cfdp::StringLv& firstFileName)
-      : actionCode(actionCode), firstFileName(firstFileName){};
+      : actionCode(actionCode), firstFileName(firstFileName) {};
 
   ReturnValue_t commonSerialize(uint8_t** buffer, size_t* size, size_t maxSize,
                                 Endianness streamEndianness, bool isResponse = false,

src/fsfw/cfdp/tlv/TlvIF.h

@@ -5,7 +5,7 @@
 
 class TlvIF : public SerializeIF {
  public:
-  virtual ~TlvIF(){};
+  virtual ~TlvIF() {};
 
   virtual uint8_t getLengthField() const = 0;
   virtual cfdp::TlvType getType() const = 0;

src/fsfw/coordinates/Jgm3Model.h

@@ -29,7 +29,7 @@ class Jgm3Model {
     lastExecutionTime.tv_sec = 0;
     lastExecutionTime.tv_usec = 0;
   }
-  virtual ~Jgm3Model(){};
+  virtual ~Jgm3Model() {};
 
   // double acsNavOrbit(double posECF[3],double velECF[3],timeval gpsTime);
 
@@ -70,10 +70,10 @@ class Jgm3Model {
               W[n][m] = W[n][m] - (((n + m - 1) / (double)(n - m)) *
                                    (pow(Earth::MEAN_RADIUS, 2) / pow(r, 2)) * W[n - 2][m]);
             }  // End of if(n!=(m+1))
-          }    // End of if(n==m){
-        }      // End of if(n==0 and m==0)
-      }        // End of for(uint8_t n=0;n<(DEGREE+1);n++)
-    }          // End of for(uint8_t m=0;m<(ORDER+1);m++)
+          }  // End of if(n==m){
+        }  // End of if(n==0 and m==0)
+      }  // End of for(uint8_t n=0;n<(DEGREE+1);n++)
+    }  // End of for(uint8_t m=0;m<(ORDER+1);m++)
 
     // overwrite accel if not properly initialized
     accel[0] = 0;
@@ -106,7 +106,7 @@ class Jgm3Model {
         accel[1] += partAccel[1];
         accel[2] += partAccel[2];
       }  // End of for(uint8_t n=0;n<DEGREE;n++)
-    }    // End of uint8_t m=0;m<ORDER;m++
+    }  // End of uint8_t m=0;m<ORDER;m++
   }
 
   void initializeNavOrbit(const double position[3], const double velocity[3], timeval timeUTC) {

src/fsfw/datapool/PoolDataSetIF.h

@@ -10,7 +10,7 @@
  */
 class PoolDataSetIF : virtual public DataSetIF, virtual public ReadCommitIF {
  public:
-  virtual ~PoolDataSetIF(){};
+  virtual ~PoolDataSetIF() {};
 
   /**
    * @brief   Most underlying data structures will have a pool like structure

src/fsfw/datapool/SharedDataSetIF.h

@@ -5,7 +5,7 @@
 
 class SharedDataSetIF {
  public:
-  virtual ~SharedDataSetIF(){};
+  virtual ~SharedDataSetIF() {};
 
  private:
   virtual ReturnValue_t lockDataset(MutexIF::TimeoutType timeoutType,

src/fsfw/datapoollocal/AccessLocalPoolF.h

@@ -9,7 +9,7 @@ class MutexIF;
  */
 class AccessPoolManagerIF {
  public:
-  virtual ~AccessPoolManagerIF(){};
+  virtual ~AccessPoolManagerIF() {};
 
   virtual MutexIF* getLocalPoolMutex() = 0;
 

src/fsfw/datapoollocal/HasLocalDataPoolIF.h

@@ -44,7 +44,7 @@ class HasLocalDataPoolIF {
   friend class HasLocalDpIFUserAttorney;
 
  public:
-  virtual ~HasLocalDataPoolIF(){};
+  virtual ~HasLocalDataPoolIF() {};
 
   static constexpr uint32_t INVALID_LPID = localpool::INVALID_LPID;
 

src/fsfw/datapoollocal/LocalDataPoolManager.h

@@ -257,7 +257,7 @@ class LocalDataPoolManager : public ProvidesDataPoolSubscriptionIF, public Acces
   MessageQueueId_t hkDestinationId = MessageQueueIF::NO_QUEUE;
 
   union DataId {
-    DataId() : sid(){};
+    DataId() : sid() {};
     sid_t sid;
     lp_id_t localPoolId;
   };

src/fsfw/datapoollocal/LocalPoolVariable.h

@@ -76,7 +76,7 @@ class LocalPoolVariable : public LocalPoolObjectBase {
   LocalPoolVariable(gp_id_t globalPoolId, DataSetIF* dataSet = nullptr,
                     pool_rwm_t setReadWriteMode = pool_rwm_t::VAR_READ_WRITE);
 
-  virtual ~LocalPoolVariable(){};
+  virtual ~LocalPoolVariable() {};
 
   /**
    * @brief	This is the local copy of the data pool entry.

src/fsfw/datapoollocal/LocalPoolVector.h

@@ -88,7 +88,7 @@ class LocalPoolVector : public LocalPoolObjectBase {
    * @details	If commit() was not called, the local value is
    * 			discarded and not written back to the data pool.
    */
-  ~LocalPoolVector(){};
+  ~LocalPoolVector() {};
   /**
    * @brief	The operation returns the number of array entries
    * 			in this variable.

src/fsfw/datapoollocal/MarkChangedIF.h

@@ -6,7 +6,7 @@
  */
 class MarkChangedIF {
  public:
-  virtual ~MarkChangedIF(){};
+  virtual ~MarkChangedIF() {};
 
   virtual bool hasChanged() const = 0;
   virtual void setChanged(bool changed) = 0;

src/fsfw/devicehandlers/CookieIF.h

@@ -28,7 +28,7 @@ using address_t = uint32_t;
  */
 class CookieIF {
  public:
-  virtual ~CookieIF(){};
+  virtual ~CookieIF() {};
 };
 
 #endif /* FSFW_DEVICEHANDLER_COOKIE_H_ */

src/fsfw/housekeeping/HousekeepingSnapshot.h

@@ -23,7 +23,7 @@ class HousekeepingSnapshot : public SerializeIF {
   HousekeepingSnapshot(CCSDSTime::CDS_short* cdsShort, LocalPoolDataSetBase* dataSetPtr)
       : timeStamp(reinterpret_cast<uint8_t*>(cdsShort)),
         timeStampSize(sizeof(CCSDSTime::CDS_short)),
-        updateData(dataSetPtr){};
+        updateData(dataSetPtr) {};
 
   /**
    * Update packet constructor for datasets.
@@ -32,7 +32,7 @@ class HousekeepingSnapshot : public SerializeIF {
    * @param dataSetPtr        Pointer to the dataset instance to deserialize the data into
    */
   HousekeepingSnapshot(uint8_t* timeStamp, size_t timeStampSize, LocalPoolDataSetBase* dataSetPtr)
-      : timeStamp(timeStamp), timeStampSize(timeStampSize), updateData(dataSetPtr){};
+      : timeStamp(timeStamp), timeStampSize(timeStampSize), updateData(dataSetPtr) {};
 
   /**
    * Update packet constructor for pool variables.
@@ -43,7 +43,7 @@ class HousekeepingSnapshot : public SerializeIF {
   HousekeepingSnapshot(CCSDSTime::CDS_short* cdsShort, LocalPoolObjectBase* dataSetPtr)
       : timeStamp(reinterpret_cast<uint8_t*>(cdsShort)),
         timeStampSize(sizeof(CCSDSTime::CDS_short)),
-        updateData(dataSetPtr){};
+        updateData(dataSetPtr) {};
 
   /**
    * Update packet constructor for pool variables.
@@ -52,7 +52,7 @@ class HousekeepingSnapshot : public SerializeIF {
    * @param dataSetPtr
    */
   HousekeepingSnapshot(uint8_t* timeStamp, size_t timeStampSize, LocalPoolObjectBase* dataSetPtr)
-      : timeStamp(timeStamp), timeStampSize(timeStampSize), updateData(dataSetPtr){};
+      : timeStamp(timeStamp), timeStampSize(timeStampSize), updateData(dataSetPtr) {};
 
   ReturnValue_t serialize(uint8_t** buffer, size_t* size, size_t maxSize,
                           Endianness streamEndianness) const {

src/fsfw/ipc/CommandMessageIF.h

@@ -37,7 +37,7 @@ class CommandMessageIF {
   //! Parameter 1 should contain the error code
   static const Command_t REPLY_REJECTED = MAKE_COMMAND_ID(2);
 
-  virtual ~CommandMessageIF(){};
+  virtual ~CommandMessageIF() {};
 
   /**
    * A command message shall have a uint16_t command ID field.

src/fsfw/ipc/definitions.h

@@ -5,7 +5,7 @@
 #include <fsfw/objectmanager/frameworkObjects.h>
 
 struct MqArgs {
-  MqArgs(){};
+  MqArgs() {};
   MqArgs(object_id_t objectId, void* args = nullptr) : objectId(objectId), args(args) {}
   object_id_t objectId = objects::NO_OBJECT;
   void* args = nullptr;

src/fsfw/objectmanager/ObjectManagerIF.h

@@ -40,7 +40,7 @@ class ObjectManagerIF {
   /**
    * @brief	This is the empty virtual destructor as requested by C++ interfaces.
    */
-  virtual ~ObjectManagerIF(void){};
+  virtual ~ObjectManagerIF(void) {};
   /**
    * @brief	With this call, new objects are inserted to the list.
    * @details	The implementation shall return an error code in case the

src/fsfw/rmap/RMAPChannelIF.h

@@ -9,7 +9,7 @@
 
 class RMAPChannelIF {
  public:
-  virtual ~RMAPChannelIF(){};
+  virtual ~RMAPChannelIF() {};
   /**
    * Reset an RMAP channel
    *

src/fsfw/subsystem/Subsystem.h

@@ -12,7 +12,7 @@
 
 struct TableSequenceBase {
  public:
-  TableSequenceBase(Mode_t mode, ArrayList<ModeListEntry> *table) : mode(mode), table(table){};
+  TableSequenceBase(Mode_t mode, ArrayList<ModeListEntry> *table) : mode(mode), table(table) {};
   Mode_t mode;
   ArrayList<ModeListEntry> *table;
   bool inStore = false;
@@ -21,7 +21,7 @@ struct TableSequenceBase {
 
 struct TableEntry : public TableSequenceBase {
  public:
-  TableEntry(Mode_t mode, ArrayList<ModeListEntry> *table) : TableSequenceBase(mode, table){};
+  TableEntry(Mode_t mode, ArrayList<ModeListEntry> *table) : TableSequenceBase(mode, table) {};
 };
 
 struct SequenceEntry : public TableSequenceBase {

src/fsfw/tasks/ExecutableObjectIF.h

@@ -34,7 +34,7 @@ class ExecutableObjectIF {
    * a reference to the executing task
    * @param task_ Pointer to the taskIF of this task
    */
-  virtual void setTaskIF(PeriodicTaskIF* task_){};
+  virtual void setTaskIF(PeriodicTaskIF* task_) {};
 
   /**
    * This function should be called after the object was assigned to a

src/fsfw/tasks/SemaphoreIF.h

@@ -30,7 +30,7 @@ class SemaphoreIF {
     BLOCKING  //!< Block indefinitely until the mutex becomes available.
   };
 
-  virtual ~SemaphoreIF(){};
+  virtual ~SemaphoreIF() {};
 
   static const uint8_t INTERFACE_ID = CLASS_ID::SEMAPHORE_IF;
   //! Semaphore timeout

src/fsfw/tcdistribution/definitions.h

@@ -27,5 +27,5 @@ static constexpr uint8_t SUBSYSTEM_ID = SUBSYSTEM_ID::TMTC_DISTRIBUTION;
 //! P1: Returnvalue, P2: 0 for TM issues, 1 for TC issues
 static constexpr Event HANDLE_PACKET_FAILED = event::makeEvent(SUBSYSTEM_ID, 0, severity::LOW);
 
-};      // namespace tmtcdistrib
+};  // namespace tmtcdistrib
 #endif  // FSFW_TMTCPACKET_DEFINITIONS_H

src/fsfw/timemanager/CCSDSTime.h

@@ -212,8 +212,8 @@ class CCSDSTime {
   static uint32_t subsecondsToMicroseconds(uint16_t subseconds);
 
  private:
-  CCSDSTime(){};
-  virtual ~CCSDSTime(){};
+  CCSDSTime() {};
+  virtual ~CCSDSTime() {};
   /**
    * checks a ccs time stream for validity
    *

src/fsfw/tmtcpacket/pus/tm/PusTmCreator.h

@@ -22,7 +22,7 @@ struct PusTmSecHeader {
 
 struct PusTmParams {
   PusTmParams() = default;
-  explicit PusTmParams(PusTmSecHeader secHeader) : secHeader(secHeader){};
+  explicit PusTmParams(PusTmSecHeader secHeader) : secHeader(secHeader) {};
   PusTmParams(PusTmSecHeader secHeader, const SerializeIF& data)
       : secHeader(secHeader), sourceData(&data) {}
   PusTmParams(PusTmSecHeader secHeader, const uint8_t* data, size_t dataLen)

src/fsfw_hal/common/gpio/GpioIF.h

@@ -15,7 +15,7 @@ class GpioCookie;
  */
 class GpioIF {
  public:
-  virtual ~GpioIF(){};
+  virtual ~GpioIF() {};
 
   /**
    * @brief   Called by the GPIO using object.

src/fsfw_hal/common/gpio/gpioDefinitions.h

@@ -60,7 +60,7 @@ class GpioBase {
            gpio::Levels initValue)
       : gpioType(gpioType), consumer(consumer), direction(direction), initValue(initValue) {}
 
-  virtual ~GpioBase(){};
+  virtual ~GpioBase() {};
 
   // Can be used to cast GpioBase to a concrete child implementation
   gpio::GpioTypes gpioType = gpio::GpioTypes::NONE;

src/fsfw_hal/stm32h7/definitions.h

@@ -12,10 +12,10 @@ namespace stm32h7 {
  * and the second entry is the pin number
  */
 struct GpioCfg {
-  GpioCfg() : port(nullptr), pin(0), altFnc(0){};
+  GpioCfg() : port(nullptr), pin(0), altFnc(0) {};
 
   GpioCfg(GPIO_TypeDef* port, uint16_t pin, uint8_t altFnc = 0)
-      : port(port), pin(pin), altFnc(altFnc){};
+      : port(port), pin(pin), altFnc(altFnc) {};
   GPIO_TypeDef* port;
   uint16_t pin;
   uint8_t altFnc;

src/fsfw_hal/stm32h7/spi/mspInit.h

@@ -37,7 +37,7 @@ struct MspCfgBase {
 };
 
 struct MspPollingConfigStruct : public MspCfgBase {
-  MspPollingConfigStruct() : MspCfgBase(){};
+  MspPollingConfigStruct() : MspCfgBase() {};
   MspPollingConfigStruct(stm32h7::GpioCfg sck, stm32h7::GpioCfg mosi, stm32h7::GpioCfg miso,
                          mspCb cleanupCb = nullptr, mspCb setupCb = nullptr)
       : MspCfgBase(sck, mosi, miso, cleanupCb, setupCb) {}
@@ -46,7 +46,7 @@ struct MspPollingConfigStruct : public MspCfgBase {
 /* A valid instance of this struct must be passed to the MSP initialization function as a void*
 argument */
 struct MspIrqConfigStruct : public MspPollingConfigStruct {
-  MspIrqConfigStruct() : MspPollingConfigStruct(){};
+  MspIrqConfigStruct() : MspPollingConfigStruct() {};
   MspIrqConfigStruct(stm32h7::GpioCfg sck, stm32h7::GpioCfg mosi, stm32h7::GpioCfg miso,
                      mspCb cleanupCb = nullptr, mspCb setupCb = nullptr)
       : MspPollingConfigStruct(sck, mosi, miso, cleanupCb, setupCb) {}
@@ -64,7 +64,7 @@ struct MspIrqConfigStruct : public MspPollingConfigStruct {
 /* A valid instance of this struct must be passed to the MSP initialization function as a void*
 argument */
 struct MspDmaConfigStruct : public MspIrqConfigStruct {
-  MspDmaConfigStruct() : MspIrqConfigStruct(){};
+  MspDmaConfigStruct() : MspIrqConfigStruct() {};
   MspDmaConfigStruct(stm32h7::GpioCfg sck, stm32h7::GpioCfg mosi, stm32h7::GpioCfg miso,
                      mspCb cleanupCb = nullptr, mspCb setupCb = nullptr)
       : MspIrqConfigStruct(sck, mosi, miso, cleanupCb, setupCb) {}

unittests/container/TestArrayList.cpp

@@ -13,8 +13,8 @@ TEST_CASE("Array List", "[containers]") {
   ArrayList<uint16_t> list(20);
   struct TestClass {
    public:
-    TestClass(){};
-    TestClass(uint32_t number1, uint64_t number2) : number1(number1), number2(number2){};
+    TestClass() {};
+    TestClass(uint32_t number1, uint64_t number2) : number1(number1), number2(number2) {};
     uint32_t number1 = -1;
     uint64_t number2 = -1;
     bool operator==(const TestClass& other) {

unittests/container/TestFixedOrderedMultimap.cpp

@@ -97,9 +97,9 @@ TEST_CASE("FixedOrderedMultimap Non Trivial Type", "[TestFixedOrderedMultimapNon
 
   class TestClass {
    public:
-    TestClass(){};
-    TestClass(uint32_t number1, uint64_t number2) : number1(number1), number2(number2){};
-    ~TestClass(){};
+    TestClass() {};
+    TestClass(uint32_t number1, uint64_t number2) : number1(number1), number2(number2) {};
+    ~TestClass() {};
 
     bool operator==(const TestClass& lhs) {
       return ((this->number1 == lhs.number1) and (this->number2 == lhs.number2));