KSat/fsfw
18
6
Fork 0
forked from fsfw/fsfw
Code Issues Pull Requests 1 Releases Wiki Activity

Changed events definition to macro #51

Closed
msenger wants to merge 2 commits from event-definition into main
pull from: event-definition
merge into: KSat:main
Conversation 2 Commits 2 Files Changed 2 +2 -2
msenger commented 2025-02-24 15:26:08 +01:00
Collaborator
Copy Link
No description provided.
msenger self-assigned this 2025-02-24 15:26:08 +01:00
msenger added 1 commit 2025-02-24 15:26:08 +01:00
msenger requested review from muellerr 2025-02-24 15:26:09 +01:00
msenger added 1 commit 2025-02-24 15:28:27 +01:00
muellerr reviewed 2025-02-25 09:28:26 +01:00
src/fsfw/pus/Service11TelecommandScheduling.h
@ -49,7 +49,7 @@ class Service11TelecommandScheduling final : public PusServiceBase {
//! [EXPORT] : [COMMENT] Deletion of a TC from the map failed.
//! P1: First 32 bit of request ID, P2. Last 32 bit of Request ID
static constexpr Event TC_DELETION_FAILED = event::makeEvent(SUBSYSTEM_ID, 0, severity::MEDIUM);
muellerr commented 2025-02-25 09:28:10 +01:00
Owner
Copy Link

what is the problem with an explicit function. We should be trying to get away from the C pre-processor, not the other way around.

what is the problem with an explicit function. We should be trying to get away from the C pre-processor, not the other way around.
src/fsfw/tcdistribution/definitions.h
@ -26,3 +26,3 @@
static constexpr uint8_t SUBSYSTEM_ID = SUBSYSTEM_ID::TMTC_DISTRIBUTION;
//! P1: Returnvalue, P2: 0 for TM issues, 1 for TC issues
static constexpr Event HANDLE_PACKET_FAILED = event::makeEvent(SUBSYSTEM_ID, 0, severity::LOW);
static constexpr Event HANDLE_PACKET_FAILED = MAKE_EVENT(0, severity::LOW);
muellerr commented 2025-02-25 09:28:20 +01:00
Owner
Copy Link

same as above

same as above
tbaumgartl commented 2025-03-14 12:25:09 +01:00
Member
Copy Link

This can be closed. The underlying issue was the maximum character count in a line for autofmt.
I recommend you disable autofmt for these sensitive sections of code via // clang-format off and // clang-format on.

This can be closed. The underlying issue was the maximum character count in a line for autofmt. I recommend you disable autofmt for these sensitive sections of code via `// clang-format off` and `// clang-format on`.
tbaumgartl closed this pull request 2025-03-14 12:25:10 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
muellerr
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel dwoodward fbalassa gaisser jgerhards lrajer mdemke meierj mluz mohr msenger mspahr mtompert muellerr nehlichp phoffmann PScheurenbrand taheran tbaumgartl
No Assignees msenger
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KSat/fsfw#51
No description provided.
Delete Branch "event-definition"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?