KSat/fsfw
18
6
Fork 0
forked from fsfw/fsfw
Code Issues Pull Requests 1 Releases Wiki Activity

Changed events definition to macro #51

Closed
msenger wants to merge 2 commits from event-definition into main
pull from: event-definition
merge into: KSat:main
Conversation 2 Commits 2 Files Changed 2 +2 -2
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/fsfw/pus/Service11TelecommandScheduling.h
View File

@ -49,7 +49,7 @@ class Service11TelecommandScheduling final : public PusServiceBase {
//! [EXPORT] : [COMMENT] Deletion of a TC from the map failed.
//! P1: First 32 bit of request ID, P2. Last 32 bit of Request ID
static constexpr Event TC_DELETION_FAILED = event::makeEvent(SUBSYSTEM_ID, 0, severity::MEDIUM);
muellerr commented 2025-02-25 09:28:10 +01:00
Review
Copy Link

what is the problem with an explicit function. We should be trying to get away from the C pre-processor, not the other way around.

what is the problem with an explicit function. We should be trying to get away from the C pre-processor, not the other way around.
static constexpr Event TC_DELETION_FAILED = MAKE_EVENT(0, severity::MEDIUM);
// The types of PUS-11 subservices
enum Subservice : uint8_t {

2
src/fsfw/tcdistribution/definitions.h
View File

@ -25,7 +25,7 @@ static constexpr ReturnValue_t INCORRECT_SECONDARY_HEADER = MAKE_RETURN_CODE(11)
static constexpr uint8_t SUBSYSTEM_ID = SUBSYSTEM_ID::TMTC_DISTRIBUTION;
//! P1: Returnvalue, P2: 0 for TM issues, 1 for TC issues
static constexpr Event HANDLE_PACKET_FAILED = event::makeEvent(SUBSYSTEM_ID, 0, severity::LOW);
static constexpr Event HANDLE_PACKET_FAILED = MAKE_EVENT(0, severity::LOW);
muellerr commented 2025-02-25 09:28:20 +01:00
Review
Copy Link

same as above

same as above
}; // namespace tmtcdistrib
#endif // FSFW_TMTCPACKET_DEFINITIONS_H