Better printer task & Bug fix #68

2026-07-30T12:23:24+02:00

blochm commented

2026-07-30 12:23:24 +02:00

See commit messages for more details.
TLDR: 1st commit, replaced ServiceInterfacePrinter with a ringbuffer version utilizing space more efficiently and the consumer now only prints out a fixed amount of bytes per task (no more deadline misses on big prints). 2nd commit, fixes a compile time bug were SerialBufferAdapter type is dependent on target (uses either uint64_t or uint32_t) => now only uint32_t.

Tests: Printed out entire Persistent TM Store on the iOBC without any deadline misses.

See commit messages for more details. TLDR: 1st commit, replaced ServiceInterfacePrinter with a ringbuffer version utilizing space more efficiently and the consumer now only prints out a fixed amount of bytes per task (no more deadline misses on big prints). 2nd commit, fixes a compile time bug were SerialBufferAdapter type is dependent on target (uses either uint64_t or uint32_t) => now only uint32_t. Tests: Printed out entire Persistent TM Store on the iOBC without any deadline misses.

blochm added 2 commits 2026-07-30 12:23:25 +02:00

feat(ServiceInterfacePrinter): ringbuffer printer 23500c8364

Previously the printer used a 2d array mechanism to queue up messages,
by selecting a free slot with help of a etl::bitset for tracking. A
message is then sent to the callback what slot is filled up and the
callback then drains the entire queue and prints out the messages.

This was prone to deadline issues, since the entire queue was always
flushed and often I noticed a deadline missed messages when developing
other stuff. Also memory is inefficiently used with the 2d array.

This new version fixes the above using a ring buffer datastructure. We
use a flat array and 2 integer pointers for storing and tracking the
bytes to print. So now there isn't any wasted space between messages.
Also with the design of the ring buffer messages can be written in and
read out at the same time, so we have minimal mutex use (just for
updating the integer pointers). To address the deadline issue, the
callback also only prints out a limited number of bytes per cycle.

(Also the printer code in general has been optimized a bit, since it was
quite needlessly big)

fix(DeviceHandlerBase): SerialBufferAdapter was missing <uint32_t> b65854eaa0

Previously it simply defaulted to size_t because of the length parameter
type. This is bad, since network serialization is then platform
dependant

muellerr approved these changes

2026-08-06 10:40:05 +02:00

muellerr merged commit 9890a2c52e into main

2026-08-06 10:40:09 +02:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: KSat/fsfw#68

Allow edits from maintainers