this should be better

dummies/TemperatureSensorInserter.cpp

@@ -15,7 +15,7 @@ TemperatureSensorInserter::TemperatureSensorInserter(
       tmp1075DummyMap(std::move(tempTmpSensorDummies_)) {}
 
 ReturnValue_t TemperatureSensorInserter::initialize() {
-  testCase = TestCase::NONE;
+  testCase = TestCase::COLD_PLOC_STAYS_COLD;
   return returnvalue::OK;
 }
 
@@ -126,6 +126,13 @@ ReturnValue_t TemperatureSensorInserter::performOperation(uint8_t opCode) {
         sif::debug << "Setting CAM temperature back to normal" << std::endl;
         max31865DummyMap[objects::RTD_2_IC5_4K_CAMERA]->setTemperature(0, true);
       }
+      break;
+    }
+    case (TestCase::COLD_PLOC_STAYS_COLD): {
+      if (cycles == 15) {
+        sif::debug << "Setting cold PLOC temperature" << std::endl;
+        max31865DummyMap[objects::RTD_0_IC3_PLOC_HEATSPREADER]->setTemperature(-40, true);
+      }
     }
   }
   cycles++;

dummies/TemperatureSensorInserter.h

@@ -33,6 +33,7 @@ class TemperatureSensorInserter : public ExecutableObjectIF, public SystemObject
     COLD_STR_CONSECUTIVE = 5,
     COLD_CAMERA = 6,
     COLD_PLOC_CONSECUTIVE = 7,
+    COLD_PLOC_STAYS_COLD = 8
   };
   int iteration = 0;
   uint32_t cycles = 0;

mission/controller/ThermalController.cpp

@@ -1791,9 +1791,10 @@ void ThermalController::heaterMaxDurationControl(const HeaterSwitchStates& curre
       heaterStates[i].switchTransition = false;
       heaterStates[i].heaterSwitchControlCycles = 0;
       heaterStates[i].trackHeaterMaxPeriod = false;
-      heaterHandler.switchHeater(static_cast<heater::Switch>(i), HeaterHandler::SwitchState::OFF);
       triggerEvent(tcsCtrl::TCS_HEATER_MAX_BURN_TIME_REACHED, static_cast<uint32_t>(i),
                    MAX_HEATER_ON_DURATIONS_MS[i]);
+      heaterSwitchHelper(static_cast<heater::Switch>(i), HeaterHandler::SwitchState::OFF,
+                         std::nullopt);
       // The heater might still be one for some thermal components, so cross-check
       // those components
       crossCheckHeaterStateOfComponentsWhenHeaterGoesOff(static_cast<heater::Switch>(i));
@@ -1847,23 +1848,28 @@ void ThermalController::resetThermalStates() {
 
 void ThermalController::heaterSwitchHelper(heater::Switch switchNr,
                                            HeaterHandler::SwitchState targetState,
-                                           unsigned componentIdx) {
+                                           std::optional<unsigned> componentIdx) {
   timeval currentTime;
   Clock::getClockMonotonic(&currentTime);
   if (targetState == HeaterHandler::SwitchState::ON) {
     heaterHandler.switchHeater(switchNr, targetState);
     heaterStates[switchNr].target = HeaterHandler::SwitchState::ON;
     heaterStates[switchNr].switchTransition = true;
-    thermalStates[componentIdx].sensorIndex = currentSensorIndex;
+    if (componentIdx.has_value()) {
-    thermalStates[componentIdx].heaterSwitch = switchNr;
+      unsigned componentIdxVal = componentIdx.value();
-    thermalStates[componentIdx].heating = true;
+      thermalStates[componentIdxVal].sensorIndex = currentSensorIndex;
-    thermalStates[componentIdx].heaterStartTime = currentTime.tv_sec;
+      thermalStates[componentIdxVal].heaterSwitch = switchNr;
+      thermalStates[componentIdxVal].heating = true;
+      thermalStates[componentIdxVal].heaterStartTime = currentTime.tv_sec;
+    }
     triggerEvent(tcsCtrl::TCS_SWITCHING_HEATER_ON, static_cast<uint32_t>(currThermalComponent),
                  static_cast<uint32_t>(switchNr));
   } else {
     heaterHandler.switchHeater(switchNr, targetState);
-    thermalStates[componentIdx].heating = false;
+    if (componentIdx.has_value()) {
-    thermalStates[componentIdx].heaterEndTime = currentTime.tv_sec;
+      thermalStates[componentIdx.value()].heating = false;
+      thermalStates[componentIdx.value()].heaterEndTime = currentTime.tv_sec;
+    }
     triggerEvent(tcsCtrl::TCS_SWITCHING_HEATER_OFF, static_cast<uint32_t>(currThermalComponent),
                  static_cast<uint32_t>(switchNr));
   }

mission/controller/ThermalController.h

@@ -24,6 +24,7 @@
 
 #include <atomic>
 #include <list>
+#include <optional>
 
 /**
  * NOP Limit: Hard limit for device, usually from datasheet. Device damage is possible lif NOP limit
@@ -110,7 +111,7 @@ class ThermalController : public ExtendedControllerBase {
   // 1 hour
   static constexpr uint32_t DEFAULT_MAX_HEATER_ON_DURATION_MS = 60 * 60 * 1000;
   static constexpr uint32_t MAX_HEATER_ON_DURATIONS_MS[8] = {// PLOC PROC board
-                                                             DEFAULT_MAX_HEATER_ON_DURATION_MS,
+                                                             60 * 1000,
                                                              // PCDU PDU
                                                              DEFAULT_MAX_HEATER_ON_DURATION_MS,
                                                              // ACS Board
@@ -347,7 +348,7 @@ class ThermalController : public ExtendedControllerBase {
 
   void heaterSwitchHelperAllOff();
   void heaterSwitchHelper(heater::Switch switchNr, HeaterHandler::SwitchState state,
-                          unsigned componentIdx);
+                          std::optional<unsigned> componentIdx);
 
   void ctrlAcsBoard();
   void ctrlMgt();