actually lets keep this
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good

This commit is contained in:
Marius Eggert 2023-10-18 13:35:18 +02:00
parent c139457661
commit 665b7d95f7
2 changed files with 6 additions and 1 deletions

View File

@ -97,7 +97,9 @@ ReturnValue_t SusHandler::interpretDeviceReply(DeviceCommandId_t id, const uint8
// appear sometimes for the SUS device: Allow invalid message up to a certain threshold // appear sometimes for the SUS device: Allow invalid message up to a certain threshold
// before triggering FDIR reactions. // before triggering FDIR reactions.
if (reply->tempRaw == 0xfff and not waitingForRecovery) { if (reply->tempRaw == 0xfff and not waitingForRecovery) {
if (invalidMsgCounter == susMax1227::MAX_INVALID_MSG_COUNT) { if (invalidMsgCounter == 0 and invalidMsgPeriodCounter == 0) {
triggerEvent(TEMPERATURE_ALL_ONES_START);
} else if (invalidMsgCounter == susMax1227::MAX_INVALID_MSG_COUNT) {
triggerEvent(DeviceHandlerIF::DEVICE_WANTS_HARD_REBOOT); triggerEvent(DeviceHandlerIF::DEVICE_WANTS_HARD_REBOOT);
waitingForRecovery = true; waitingForRecovery = true;
} }

View File

@ -17,6 +17,9 @@ class SusHandler : public DeviceHandlerBase {
static const uint8_t INTERFACE_ID = CLASS_ID::SUS_HANDLER; static const uint8_t INTERFACE_ID = CLASS_ID::SUS_HANDLER;
static const uint8_t SUBSYSTEM_ID = SUBSYSTEM_ID::SUS_HANDLER; static const uint8_t SUBSYSTEM_ID = SUBSYSTEM_ID::SUS_HANDLER;
//! [EXPORT] : [COMMENT] Detected invalid values, starting invalid message counting
static constexpr Event TEMPERATURE_ALL_ONES_START =
event::makeEvent(SUBSYSTEM_ID, 0, severity::MEDIUM);
//! [EXPORT] : [COMMENT] Detected valid values for a prolonged time again, resetting all counters. //! [EXPORT] : [COMMENT] Detected valid values for a prolonged time again, resetting all counters.
//! P1: Number of periods with invalid messages. //! P1: Number of periods with invalid messages.
//! P2: Maximum invalid message counter. //! P2: Maximum invalid message counter.