run generators

mission/controller/ThermalController.cpp

@@ -1,26 +1,32 @@
 #include "ThermalController.h"
 
+#include <bsp_q7s/core/CoreDefinitions.h>
 #include <fsfw/datapool/PoolReadGuard.h>
+<<<<<<< HEAD
 #include <objects/systemObjectList.h>
+=======
+#include <fsfw_hal/devicehandlers/devicedefinitions/MgmLIS3HandlerDefs.h>
+#include <linux/devices/devicedefinitions/StarTrackerDefinitions.h>
+>>>>>>> develop
 #include <mission/devices/devicedefinitions/BpxBatteryDefinitions.h>
-#include <mission/devices/devicedefinitions/SyrlinksDefinitions.h>
-#include <mission/devices/devicedefinitions/IMTQHandlerDefinitions.h>
-#include <mission/devices/devicedefinitions/RwDefinitions.h>
 #include <mission/devices/devicedefinitions/GomspaceDefinitions.h>
 #include <mission/devices/devicedefinitions/GyroADIS1650XDefinitions.h>
 #include <mission/devices/devicedefinitions/GyroL3GD20Definitions.h>
+#include <mission/devices/devicedefinitions/IMTQHandlerDefinitions.h>
+#include <mission/devices/devicedefinitions/RwDefinitions.h>
+#include <mission/devices/devicedefinitions/SyrlinksDefinitions.h>
 #include <mission/devices/devicedefinitions/payloadPcduDefinitions.h>
-#include <linux/devices/devicedefinitions/StarTrackerDefinitions.h>
-#include <fsfw_hal/devicehandlers/devicedefinitions/MgmLIS3HandlerDefs.h>
+#include <objects/systemObjectList.h>
 
 ThermalController::ThermalController(object_id_t objectId, object_id_t parentId)
     : ExtendedControllerBase(objectId, parentId),
       sensorTemperatures(this),
       susTemperatures(this),
       deviceTemperatures(this),
-      componentTemperatures(this),
-      max31865Set0(objects::RTD_0_IC3_PLOC_HEATSPREADER, EiveMax31855::RtdCommands::EXCHANGE_SET_ID),
-      max31865Set1(objects::RTD_1_IC4_PLOC_MISSIONBOARD, EiveMax31855::RtdCommands::EXCHANGE_SET_ID),
+      max31865Set0(objects::RTD_0_IC3_PLOC_HEATSPREADER,
+                   EiveMax31855::RtdCommands::EXCHANGE_SET_ID),
+      max31865Set1(objects::RTD_1_IC4_PLOC_MISSIONBOARD,
+                   EiveMax31855::RtdCommands::EXCHANGE_SET_ID),
       max31865Set2(objects::RTD_2_IC5_4K_CAMERA, EiveMax31855::RtdCommands::EXCHANGE_SET_ID),
       max31865Set3(objects::RTD_3_IC6_DAC_HEATSPREADER, EiveMax31855::RtdCommands::EXCHANGE_SET_ID),
       max31865Set4(objects::RTD_4_IC7_STARTRACKER, EiveMax31855::RtdCommands::EXCHANGE_SET_ID),
@@ -32,7 +38,8 @@ ThermalController::ThermalController(object_id_t objectId, object_id_t parentId)
       max31865Set10(objects::RTD_10_IC13_PL_TX, EiveMax31855::RtdCommands::EXCHANGE_SET_ID),
       max31865Set11(objects::RTD_11_IC14_MPA, EiveMax31855::RtdCommands::EXCHANGE_SET_ID),
       max31865Set12(objects::RTD_12_IC15_ACU, EiveMax31855::RtdCommands::EXCHANGE_SET_ID),
-      max31865Set13(objects::RTD_13_IC16_PLPCDU_HEATSPREADER, EiveMax31855::RtdCommands::EXCHANGE_SET_ID),
+      max31865Set13(objects::RTD_13_IC16_PLPCDU_HEATSPREADER,
+                    EiveMax31855::RtdCommands::EXCHANGE_SET_ID),
       max31865Set14(objects::RTD_14_IC17_TCS_BOARD, EiveMax31855::RtdCommands::EXCHANGE_SET_ID),
       max31865Set15(objects::RTD_15_IC18_IMTQ, EiveMax31855::RtdCommands::EXCHANGE_SET_ID),
       tmp1075Set1(objects::TMP1075_HANDLER_1),
@@ -52,7 +59,6 @@ ThermalController::ThermalController(object_id_t objectId, object_id_t parentId)
 
 ReturnValue_t ThermalController::initialize() {
   auto result = ExtendedControllerBase::initialize();
-
   return result;
 }
 
@@ -61,6 +67,25 @@ ReturnValue_t ThermalController::handleCommandMessage(CommandMessage* message) {
 }
 
 void ThermalController::performControlOperation() {
+  switch (internalState) {
+    case InternalState::STARTUP: {
+      initialCountdown.resetTimer();
+      internalState = InternalState::INITIAL_DELAY;
+      return;
+    }
+    case InternalState::INITIAL_DELAY: {
+      if (initialCountdown.hasTimedOut()) {
+        internalState = InternalState::READY;
+      }
+      return;
+    }
+    case InternalState::READY: {
+      break;
+    }
+    default:
+      break;
+  }
+
   ReturnValue_t result = sensorTemperatures.read();
   if (result == RETURN_OK) {
     copySensors();
@@ -78,13 +103,6 @@ void ThermalController::performControlOperation() {
     copyDevices();
     deviceTemperatures.commit();
   }
-
-  result = componentTemperatures.read();
-  if (result != RETURN_OK) {
-    return;
-  }
-
-  componentTemperatures.commit();
 }
 
 ReturnValue_t ThermalController::initializeLocalDataPool(localpool::DataPool& localDataPoolMap,
@@ -162,17 +180,15 @@ ReturnValue_t ThermalController::initializeLocalDataPool(localpool::DataPool& lo
   localDataPoolMap.emplace(thermalControllerDefinitions::TEMP_STAR_TRACKER,
                            new PoolEntry<float>({0.0}));
   localDataPoolMap.emplace(thermalControllerDefinitions::TEMP_SYRLINKS_POWER_AMPLIFIER,
-                           new PoolEntry<uint16_t>({0}));
+                           new PoolEntry<float>({0}));
   localDataPoolMap.emplace(thermalControllerDefinitions::TEMP_SYRLINKS_BASEBAND_BOARD,
-                           new PoolEntry<uint16_t>({0}));
-  localDataPoolMap.emplace(thermalControllerDefinitions::TEMP_MGT, new PoolEntry<uint16_t>({0}));
+                           new PoolEntry<float>({0}));
+  localDataPoolMap.emplace(thermalControllerDefinitions::TEMP_MGT, new PoolEntry<int16_t>({0}));
   localDataPoolMap.emplace(thermalControllerDefinitions::TEMP_ACU, new PoolEntry<float>({0}));
   localDataPoolMap.emplace(thermalControllerDefinitions::TEMP_PDU1, new PoolEntry<float>({0}));
   localDataPoolMap.emplace(thermalControllerDefinitions::TEMP_PDU2, new PoolEntry<float>({0}));
-  localDataPoolMap.emplace(thermalControllerDefinitions::TEMP_1_P60DOCK,
-                           new PoolEntry<float>({0}));
-  localDataPoolMap.emplace(thermalControllerDefinitions::TEMP_2_P60DOCK,
-                           new PoolEntry<float>({0}));
+  localDataPoolMap.emplace(thermalControllerDefinitions::TEMP_1_P60DOCK, new PoolEntry<float>({0}));
+  localDataPoolMap.emplace(thermalControllerDefinitions::TEMP_2_P60DOCK, new PoolEntry<float>({0}));
   localDataPoolMap.emplace(thermalControllerDefinitions::TEMP_GYRO_0_SIDE_A,
                            new PoolEntry<float>({0.0}));
   localDataPoolMap.emplace(thermalControllerDefinitions::TEMP_GYRO_1_SIDE_A,
@@ -202,7 +218,7 @@ LocalPoolDataSetBase* ThermalController::getDataSetHandle(sid_t sid) {
     case thermalControllerDefinitions::SUS_TEMPERATURES:
       return &susTemperatures;
     case thermalControllerDefinitions::DEVICE_TEMPERATURES:
-          return &deviceTemperatures;
+      return &deviceTemperatures;
     default:
       return nullptr;
   }
@@ -499,8 +515,7 @@ void ThermalController::copyDevices() {
     sif::warning << "ThermalController: Failed to read Q7S temperature" << std::endl;
     deviceTemperatures.q7s.setValid(false);
     deviceTemperatures.q7s = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.q7s = tempQ7s;
     deviceTemperatures.q7s.setValid(tempQ7s.isValid());
   }
@@ -508,14 +523,14 @@ void ThermalController::copyDevices() {
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to commit" << std::endl;
   }
-  lp_var_t<int16_t> battTemp1 = lp_var_t<int16_t>(objects::BPX_BATT_HANDLER, BpxBattery::BATT_TEMP_1);
+  lp_var_t<int16_t> battTemp1 =
+      lp_var_t<int16_t>(objects::BPX_BATT_HANDLER, BpxBattery::BATT_TEMP_1);
   result = battTemp1.read();
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to read battery temperature 1" << std::endl;
     deviceTemperatures.batteryTemp1.setValid(false);
     deviceTemperatures.batteryTemp1 = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.batteryTemp1 = battTemp1;
     deviceTemperatures.batteryTemp1.setValid(battTemp1.isValid());
   }
@@ -523,14 +538,14 @@ void ThermalController::copyDevices() {
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to commit" << std::endl;
   }
-  lp_var_t<int16_t> battTemp2 = lp_var_t<int16_t>(objects::BPX_BATT_HANDLER, BpxBattery::BATT_TEMP_2);
+  lp_var_t<int16_t> battTemp2 =
+      lp_var_t<int16_t>(objects::BPX_BATT_HANDLER, BpxBattery::BATT_TEMP_2);
   result = battTemp2.read();
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to read battery temperature 2" << std::endl;
     deviceTemperatures.batteryTemp2.setValid(false);
     deviceTemperatures.batteryTemp2 = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.batteryTemp2 = battTemp2;
     deviceTemperatures.batteryTemp2.setValid(battTemp2.isValid());
   }
@@ -538,14 +553,14 @@ void ThermalController::copyDevices() {
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to commit" << std::endl;
   }
-  lp_var_t<int16_t> battTemp3 = lp_var_t<int16_t>(objects::BPX_BATT_HANDLER, BpxBattery::BATT_TEMP_3);
+  lp_var_t<int16_t> battTemp3 =
+      lp_var_t<int16_t>(objects::BPX_BATT_HANDLER, BpxBattery::BATT_TEMP_3);
   result = battTemp3.read();
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to read battery temperature 3" << std::endl;
     deviceTemperatures.batteryTemp3.setValid(false);
     deviceTemperatures.batteryTemp3 = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.batteryTemp3 = battTemp3;
     deviceTemperatures.batteryTemp3.setValid(battTemp3.isValid());
   }
@@ -553,14 +568,14 @@ void ThermalController::copyDevices() {
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to commit" << std::endl;
   }
-  lp_var_t<int16_t> battTemp4 = lp_var_t<int16_t>(objects::BPX_BATT_HANDLER, BpxBattery::BATT_TEMP_4);
+  lp_var_t<int16_t> battTemp4 =
+      lp_var_t<int16_t>(objects::BPX_BATT_HANDLER, BpxBattery::BATT_TEMP_4);
   result = battTemp4.read();
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to read battery temperature 4" << std::endl;
     deviceTemperatures.batteryTemp4.setValid(false);
     deviceTemperatures.batteryTemp4 = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.batteryTemp4 = battTemp4;
     deviceTemperatures.batteryTemp4.setValid(battTemp4.isValid());
   }
@@ -574,8 +589,7 @@ void ThermalController::copyDevices() {
     sif::warning << "ThermalController: Failed to read reaction wheel 1 temperature" << std::endl;
     deviceTemperatures.rw1.setValid(false);
     deviceTemperatures.rw1 = static_cast<int32_t>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.rw1.setValid(tempRw1.isValid());
     deviceTemperatures.rw1 = tempRw1;
   }
@@ -589,8 +603,7 @@ void ThermalController::copyDevices() {
     sif::warning << "ThermalController: Failed to read reaction wheel 2 temperature" << std::endl;
     deviceTemperatures.rw2.setValid(false);
     deviceTemperatures.rw2 = static_cast<int32_t>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.rw2.setValid(tempRw2.isValid());
     deviceTemperatures.rw2 = tempRw2;
   }
@@ -604,8 +617,7 @@ void ThermalController::copyDevices() {
     sif::warning << "ThermalController: Failed to read reaction wheel 3 temperature" << std::endl;
     deviceTemperatures.rw3.setValid(false);
     deviceTemperatures.rw3 = static_cast<int32_t>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.rw3.setValid(tempRw3.isValid());
     deviceTemperatures.rw3 = tempRw3;
   }
@@ -619,8 +631,7 @@ void ThermalController::copyDevices() {
     sif::warning << "ThermalController: Failed to read reaction wheel 4 temperature" << std::endl;
     deviceTemperatures.rw4.setValid(false);
     deviceTemperatures.rw4 = static_cast<int32_t>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.rw4.setValid(tempRw4.isValid());
     deviceTemperatures.rw4 = tempRw4;
   }
@@ -635,8 +646,7 @@ void ThermalController::copyDevices() {
     sif::warning << "ThermalController: Failed to read startracker temperature" << std::endl;
     deviceTemperatures.startracker.setValid(false);
     deviceTemperatures.startracker = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.startracker.setValid(tempStartracker.isValid());
     deviceTemperatures.startracker = tempStartracker;
   }
@@ -644,15 +654,15 @@ void ThermalController::copyDevices() {
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to commit" << std::endl;
   }
-  lp_var_t<uint16_t> tempSyrlinksPowerAmplifier =
-      lp_var_t<uint16_t>(objects::SYRLINKS_HK_HANDLER, syrlinks::TEMP_POWER_AMPLIFIER);
+  lp_var_t<float> tempSyrlinksPowerAmplifier =
+      lp_var_t<float>(objects::SYRLINKS_HK_HANDLER, syrlinks::TEMP_POWER_AMPLIFIER);
   result = tempSyrlinksPowerAmplifier.read();
   if (result != RETURN_OK) {
-    sif::warning << "ThermalController: Failed to read syrlinks power amplifier temperature" << std::endl;
+    sif::warning << "ThermalController: Failed to read syrlinks power amplifier temperature"
+                 << std::endl;
     deviceTemperatures.syrlinksPowerAmplifier.setValid(false);
     deviceTemperatures.syrlinksPowerAmplifier = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.syrlinksPowerAmplifier.setValid(tempSyrlinksPowerAmplifier.isValid());
     deviceTemperatures.syrlinksPowerAmplifier = tempSyrlinksPowerAmplifier;
   }
@@ -660,15 +670,15 @@ void ThermalController::copyDevices() {
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to commit" << std::endl;
   }
-  lp_var_t<uint16_t> tempSyrlinksBasebandBoard =
-      lp_var_t<uint16_t>(objects::SYRLINKS_HK_HANDLER, syrlinks::TEMP_BASEBAND_BOARD);
+  lp_var_t<float> tempSyrlinksBasebandBoard =
+      lp_var_t<float>(objects::SYRLINKS_HK_HANDLER, syrlinks::TEMP_BASEBAND_BOARD);
   result = tempSyrlinksBasebandBoard.read();
   if (result != RETURN_OK) {
-    sif::warning << "ThermalController: Failed to read syrlinks baseband board temperature" << std::endl;
+    sif::warning << "ThermalController: Failed to read syrlinks baseband board temperature"
+                 << std::endl;
     deviceTemperatures.syrlinksBasebandBoard.setValid(false);
     deviceTemperatures.syrlinksBasebandBoard = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.syrlinksBasebandBoard.setValid(tempSyrlinksBasebandBoard.isValid());
     deviceTemperatures.syrlinksBasebandBoard = tempSyrlinksBasebandBoard;
   }
@@ -676,15 +686,13 @@ void ThermalController::copyDevices() {
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to commit" << std::endl;
   }
-  lp_var_t<uint16_t> tempMgt =
-      lp_var_t<uint16_t>(objects::IMTQ_HANDLER, IMTQ::MCU_TEMPERATURE);
+  lp_var_t<int16_t> tempMgt = lp_var_t<int16_t>(objects::IMTQ_HANDLER, IMTQ::MCU_TEMPERATURE);
   result = tempMgt.read();
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to read MGT temperature" << std::endl;
     deviceTemperatures.mgt.setValid(false);
-    deviceTemperatures.mgt = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+    deviceTemperatures.mgt = static_cast<int16_t>(INVALID_TEMPERATURE);
+  } else {
     deviceTemperatures.mgt.setValid(tempMgt.isValid());
     deviceTemperatures.mgt = tempMgt;
   }
@@ -698,10 +706,10 @@ void ThermalController::copyDevices() {
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to read ACU temperatures" << std::endl;
     deviceTemperatures.acu.setValid(false);
-    std::memset(deviceTemperatures.acu.value, INVALID_TEMPERATURE,
-                deviceTemperatures.acu.getSize());
-  }
-  else {
+    deviceTemperatures.acu[0] = static_cast<float>(INVALID_TEMPERATURE);
+    deviceTemperatures.acu[1] = static_cast<float>(INVALID_TEMPERATURE);
+    deviceTemperatures.acu[2] = static_cast<float>(INVALID_TEMPERATURE);
+  } else {
     deviceTemperatures.acu.setValid(tempAcu.isValid());
     deviceTemperatures.acu = tempAcu;
   }
@@ -716,8 +724,7 @@ void ThermalController::copyDevices() {
     sif::warning << "ThermalController: Failed to read PDU1 temperature" << std::endl;
     deviceTemperatures.pdu1.setValid(false);
     deviceTemperatures.pdu1 = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.pdu1.setValid(tempPdu1.isValid());
     deviceTemperatures.pdu1 = tempPdu1;
   }
@@ -732,8 +739,7 @@ void ThermalController::copyDevices() {
     sif::warning << "ThermalController: Failed to read PDU2 temperature" << std::endl;
     deviceTemperatures.pdu2.setValid(false);
     deviceTemperatures.pdu2 = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.pdu2.setValid(tempPdu1.isValid());
     deviceTemperatures.pdu2 = tempPdu1;
   }
@@ -748,8 +754,7 @@ void ThermalController::copyDevices() {
     sif::warning << "ThermalController: Failed to read P60 dock temperature 1" << std::endl;
     deviceTemperatures.temp1P60dock.setValid(false);
     deviceTemperatures.temp1P60dock = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.temp1P60dock.setValid(temp1P60dock.isValid());
     deviceTemperatures.temp1P60dock = temp1P60dock;
   }
@@ -764,8 +769,7 @@ void ThermalController::copyDevices() {
     sif::warning << "ThermalController: Failed to read P60 dock temperature 2" << std::endl;
     deviceTemperatures.temp2P60dock.setValid(false);
     deviceTemperatures.temp2P60dock = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.temp2P60dock.setValid(temp2P60dock.isValid());
     deviceTemperatures.temp2P60dock = temp2P60dock;
   }
@@ -773,15 +777,13 @@ void ThermalController::copyDevices() {
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to commit" << std::endl;
   }
-  lp_var_t<float> tempGyro0 =
-      lp_var_t<float>(objects::GYRO_0_ADIS_HANDLER, ADIS1650X::TEMPERATURE);
+  lp_var_t<float> tempGyro0 = lp_var_t<float>(objects::GYRO_0_ADIS_HANDLER, ADIS1650X::TEMPERATURE);
   result = tempGyro0.read();
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to read gyro 0 temperature" << std::endl;
     deviceTemperatures.gyro0SideA.setValid(false);
     deviceTemperatures.gyro0SideA = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.gyro0SideA.setValid(tempGyro0.isValid());
     deviceTemperatures.gyro0SideA = tempGyro0;
   }
@@ -789,15 +791,13 @@ void ThermalController::copyDevices() {
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to commit" << std::endl;
   }
-  lp_var_t<float> tempGyro1 =
-      lp_var_t<float>(objects::GYRO_1_L3G_HANDLER, L3GD20H::TEMPERATURE);
+  lp_var_t<float> tempGyro1 = lp_var_t<float>(objects::GYRO_1_L3G_HANDLER, L3GD20H::TEMPERATURE);
   result = tempGyro1.read();
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to read gyro 1 temperature" << std::endl;
     deviceTemperatures.gyro1SideA.setValid(false);
     deviceTemperatures.gyro1SideA = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.gyro1SideA.setValid(tempGyro1.isValid());
     deviceTemperatures.gyro1SideA = tempGyro1;
   }
@@ -805,15 +805,13 @@ void ThermalController::copyDevices() {
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to commit" << std::endl;
   }
-  lp_var_t<float> tempGyro2 =
-      lp_var_t<float>(objects::GYRO_2_ADIS_HANDLER, ADIS1650X::TEMPERATURE);
+  lp_var_t<float> tempGyro2 = lp_var_t<float>(objects::GYRO_2_ADIS_HANDLER, ADIS1650X::TEMPERATURE);
   result = tempGyro2.read();
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to read gyro 2 temperature" << std::endl;
     deviceTemperatures.gyro2SideB.setValid(false);
     deviceTemperatures.gyro2SideB = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.gyro2SideB.setValid(tempGyro2.isValid());
     deviceTemperatures.gyro2SideB = tempGyro2;
   }
@@ -821,15 +819,13 @@ void ThermalController::copyDevices() {
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to commit" << std::endl;
   }
-  lp_var_t<float> tempGyro3 =
-      lp_var_t<float>(objects::GYRO_3_L3G_HANDLER, L3GD20H::TEMPERATURE);
+  lp_var_t<float> tempGyro3 = lp_var_t<float>(objects::GYRO_3_L3G_HANDLER, L3GD20H::TEMPERATURE);
   result = tempGyro3.read();
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to read gyro 3 temperature" << std::endl;
     deviceTemperatures.gyro3SideB.setValid(false);
     deviceTemperatures.gyro3SideB = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.gyro3SideB.setValid(tempGyro3.isValid());
     deviceTemperatures.gyro3SideB = tempGyro3;
   }
@@ -844,8 +840,7 @@ void ThermalController::copyDevices() {
     sif::warning << "ThermalController: Failed to read MGM 0 temperature" << std::endl;
     deviceTemperatures.mgm0SideA.setValid(false);
     deviceTemperatures.mgm0SideA = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.mgm0SideA.setValid(tempMgm0.isValid());
     deviceTemperatures.mgm0SideA = tempMgm0;
   }
@@ -860,8 +855,7 @@ void ThermalController::copyDevices() {
     sif::warning << "ThermalController: Failed to read MGM 2 temperature" << std::endl;
     deviceTemperatures.mgm2SideB.setValid(false);
     deviceTemperatures.mgm2SideB = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.mgm2SideB.setValid(tempMgm2.isValid());
     deviceTemperatures.mgm2SideB = tempMgm2;
   }
@@ -869,15 +863,13 @@ void ThermalController::copyDevices() {
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to commit" << std::endl;
   }
-  lp_var_t<float> tempAdcPayloadPcdu =
-      lp_var_t<float>(objects::PLPCDU_HANDLER, plpcdu::TEMP);
+  lp_var_t<float> tempAdcPayloadPcdu = lp_var_t<float>(objects::PLPCDU_HANDLER, plpcdu::TEMP);
   result = tempAdcPayloadPcdu.read();
   if (result != RETURN_OK) {
     sif::warning << "ThermalController: Failed to read payload PCDU ADC temperature" << std::endl;
     deviceTemperatures.adcPayloadPcdu.setValid(false);
     deviceTemperatures.adcPayloadPcdu = static_cast<float>(INVALID_TEMPERATURE);
-  }
-  else {
+  } else {
     deviceTemperatures.adcPayloadPcdu.setValid(tempAdcPayloadPcdu.isValid());
     deviceTemperatures.adcPayloadPcdu = tempAdcPayloadPcdu;
   }

mission/controller/ThermalController.h

@@ -2,6 +2,7 @@
 #define MISSION_CONTROLLER_THERMALCONTROLLER_H_
 
 #include <fsfw/controller/ExtendedControllerBase.h>
+#include <fsfw/timemanager/Countdown.h>
 #include <mission/controller/controllerdefinitions/ThermalControllerDefinitions.h>
 #include <mission/devices/devicedefinitions/Max31865Definitions.h>
 #include <mission/devices/devicedefinitions/SusDefinitions.h>
@@ -27,10 +28,15 @@ class ThermalController : public ExtendedControllerBase {
                                          uint32_t* msToReachTheMode) override;
 
  private:
+  static const uint32_t DELAY = 500;
+
+  enum class InternalState { STARTUP, INITIAL_DELAY, READY };
+
+  InternalState internalState = InternalState::STARTUP;
+
   thermalControllerDefinitions::SensorTemperatures sensorTemperatures;
   thermalControllerDefinitions::SusTemperatures susTemperatures;
   thermalControllerDefinitions::DeviceTemperatures deviceTemperatures;
-  thermalControllerDefinitions::ComponentTemperatures componentTemperatures;
 
   // Temperature Sensors
   MAX31865::Max31865Set max31865Set0;
@@ -66,6 +72,9 @@ class ThermalController : public ExtendedControllerBase {
   SUS::SusDataset susSet10;
   SUS::SusDataset susSet11;
 
+  // Initial delay to make sure all pool variables have been initialized their owners
+  Countdown initialCountdown = Countdown(DELAY);
+
   void copySensors();
   void copySus();
   void copyDevices();

mission/controller/controllerdefinitions/ThermalControllerDefinitions.h

@@ -48,31 +48,31 @@ enum PoolIds : lp_id_t {
 
   COMPONENT_RW,
 
-	TEMP_Q7S,
-	BATTERY_TEMP_1,
-	BATTERY_TEMP_2,
-	BATTERY_TEMP_3,
-	BATTERY_TEMP_4,
-	TEMP_RW1,
-	TEMP_RW2,
-	TEMP_RW3,
-	TEMP_RW4,
-	TEMP_STAR_TRACKER,
-	TEMP_SYRLINKS_POWER_AMPLIFIER,
-	TEMP_SYRLINKS_BASEBAND_BOARD,
-	TEMP_MGT,
-	TEMP_ACU,
-	TEMP_PDU1,
-	TEMP_PDU2,
-	TEMP_1_P60DOCK,
-	TEMP_2_P60DOCK,
-	TEMP_GYRO_0_SIDE_A,
-	TEMP_GYRO_1_SIDE_A,
-	TEMP_GYRO_2_SIDE_B,
-	TEMP_GYRO_3_SIDE_B,
-	TEMP_MGM_0_SIDE_A,
-	TEMP_MGM_2_SIDE_B,
-	TEMP_ADC_PAYLOAD_PCDU
+  TEMP_Q7S,
+  BATTERY_TEMP_1,
+  BATTERY_TEMP_2,
+  BATTERY_TEMP_3,
+  BATTERY_TEMP_4,
+  TEMP_RW1,
+  TEMP_RW2,
+  TEMP_RW3,
+  TEMP_RW4,
+  TEMP_STAR_TRACKER,
+  TEMP_SYRLINKS_POWER_AMPLIFIER,
+  TEMP_SYRLINKS_BASEBAND_BOARD,
+  TEMP_MGT,
+  TEMP_ACU,
+  TEMP_PDU1,
+  TEMP_PDU2,
+  TEMP_1_P60DOCK,
+  TEMP_2_P60DOCK,
+  TEMP_GYRO_0_SIDE_A,
+  TEMP_GYRO_1_SIDE_A,
+  TEMP_GYRO_2_SIDE_B,
+  TEMP_GYRO_3_SIDE_B,
+  TEMP_MGM_0_SIDE_A,
+  TEMP_MGM_2_SIDE_B,
+  TEMP_ADC_PAYLOAD_PCDU
 };
 
 static const uint8_t ENTRIES_SENSOR_TEMPERATURE_SET = 18;
@@ -136,11 +136,11 @@ class DeviceTemperatures : public StaticLocalDataSet<ENTRIES_DEVICE_TEMPERATURE_
   lp_var_t<int32_t> rw3 = lp_var_t<int32_t>(sid.objectId, PoolIds::TEMP_RW3, this);
   lp_var_t<int32_t> rw4 = lp_var_t<int32_t>(sid.objectId, PoolIds::TEMP_RW4, this);
   lp_var_t<float> startracker = lp_var_t<float>(sid.objectId, PoolIds::TEMP_STAR_TRACKER, this);
-  lp_var_t<uint16_t> syrlinksPowerAmplifier =
-      lp_var_t<uint16_t>(sid.objectId, PoolIds::TEMP_SYRLINKS_POWER_AMPLIFIER, this);
-  lp_var_t<uint16_t> syrlinksBasebandBoard =
-      lp_var_t<uint16_t>(sid.objectId, PoolIds::TEMP_SYRLINKS_BASEBAND_BOARD, this);
-  lp_var_t<uint16_t> mgt = lp_var_t<uint16_t>(sid.objectId, PoolIds::TEMP_MGT, this);
+  lp_var_t<float> syrlinksPowerAmplifier =
+      lp_var_t<float>(sid.objectId, PoolIds::TEMP_SYRLINKS_POWER_AMPLIFIER, this);
+  lp_var_t<float> syrlinksBasebandBoard =
+      lp_var_t<float>(sid.objectId, PoolIds::TEMP_SYRLINKS_BASEBAND_BOARD, this);
+  lp_var_t<int16_t> mgt = lp_var_t<int16_t>(sid.objectId, PoolIds::TEMP_MGT, this);
   lp_vec_t<float, 3> acu = lp_vec_t<float, 3>(sid.objectId, PoolIds::TEMP_ACU, this);
   lp_var_t<float> pdu1 = lp_var_t<float>(sid.objectId, PoolIds::TEMP_PDU1, this);
   lp_var_t<float> pdu2 = lp_var_t<float>(sid.objectId, PoolIds::TEMP_PDU2, this);
@@ -164,8 +164,7 @@ class SusTemperatures : public StaticLocalDataSet<ENTRIES_SUS_TEMPERATURE_SET> {
  public:
   SusTemperatures(HasLocalDataPoolIF* owner) : StaticLocalDataSet(owner, SUS_TEMPERATURES) {}
 
-  SusTemperatures(object_id_t objectId)
-      : StaticLocalDataSet(sid_t(objectId, SUS_TEMPERATURES)) {}
+  SusTemperatures(object_id_t objectId) : StaticLocalDataSet(sid_t(objectId, SUS_TEMPERATURES)) {}
 
   lp_var_t<float> sus_0_n_loc_xfyfzm_pt_xf =
       lp_var_t<float>(sid.objectId, PoolIds::SUS_0_N_LOC_XFYFZM_PT_XF, this);
@@ -193,20 +192,6 @@ class SusTemperatures : public StaticLocalDataSet<ENTRIES_SUS_TEMPERATURE_SET> {
       lp_var_t<float>(sid.objectId, PoolIds::SUS_11_R_LOC_XBYMZB_PT_ZB, this);
 };
 
-/**
- * @brief   This dataset can be used to store the collected temperatures of all components
- */
-class ComponentTemperatures : public StaticLocalDataSet<2> {
- public:
-  ComponentTemperatures(HasLocalDataPoolIF* owner)
-      : StaticLocalDataSet(owner, COMPONENT_TEMPERATURES) {}
-
-  ComponentTemperatures(object_id_t objectId)
-      : StaticLocalDataSet(sid_t(objectId, COMPONENT_TEMPERATURES)) {}
-
-  lp_var_t<float> rw = lp_var_t<float>(sid.objectId, PoolIds::COMPONENT_RW, this);
-};
-
 }  // namespace thermalControllerDefinitions
 
 #endif /* MISSION_CONTROLLER_CONTROLLERDEFINITIONS_THERMALCONTROLLERDEFINITIONS_H_ */